LayoutTests:
authorlweintraub <lweintraub@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Jul 2006 19:33:28 +0000 (19:33 +0000)
committerlweintraub <lweintraub@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Jul 2006 19:33:28 +0000 (19:33 +0000)
commit45299d982d0a5511b271aa0ad0e3c2a7fa8975c0
treeb3df6038a08cd4a69386d19657c32698284f5122
parenta01aad004d8bf176acf63a649e9e03b9810a157c
LayoutTests:

        Reviewed by justin

        Improved table editing

        * editing/deleting/delete-to-select-table-expected.checksum: Added.
        * editing/deleting/delete-to-select-table-expected.png: Added.
        * editing/deleting/delete-to-select-table-expected.txt: Added.
        * editing/deleting/delete-to-select-table.html: Added.
        * editing/input/text-input-controller-expected.txt:

WebCore:

        Reviewed by justin

        Improved table editing: pressing delete directly before or after a table will now select
        the table first, then delete it, instead of just deleting it. Useful for when the table's
        existence is non-obvious.

        * bridge/mac/FrameMac.h: Added shouldDeleteSelection, which allows WebCore to trigger
        deletion editing deligates
        * bridge/mac/FrameMac.mm: ditto
        (WebCore::FrameMac::shouldDeleteSelection):
        * bridge/mac/WebCoreFrameBridge.h: ditto
        * editing/TypingCommand.cpp: Implemented check for a caret position next to a table, and
        subsequent selection (as opposed to removal)
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * page/Frame.cpp: shouldDeleteSelection added
        (WebCore::Frame::shouldDeleteSelection):
        * page/Frame.h: ditto

WebKit:

        Reviewed by justin

        Improved table editing

        * WebCoreSupport/WebFrameBridge.m: Added method to allow WebCore to trigger
        deletion editing delegate
        (-[WebFrameBridge shouldDeleteSelectedDOMRange:]):
        * WebView/WebHTMLView.m: Moved code that expanded a selection when the delete
        key is pressed over to WebCore so we can be more intelligent about how to handle it
        (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]):
        (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
16 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/deleting/delete-to-select-table-expected.checksum [new file with mode: 0644]
LayoutTests/editing/deleting/delete-to-select-table-expected.png [new file with mode: 0644]
LayoutTests/editing/deleting/delete-to-select-table-expected.txt [new file with mode: 0644]
LayoutTests/editing/deleting/delete-to-select-table.html [new file with mode: 0644]
LayoutTests/editing/input/text-input-controller-expected.txt
WebCore/ChangeLog
WebCore/bridge/mac/FrameMac.h
WebCore/bridge/mac/FrameMac.mm
WebCore/bridge/mac/WebCoreFrameBridge.h
WebCore/editing/TypingCommand.cpp
WebCore/page/Frame.cpp
WebCore/page/Frame.h
WebKit/ChangeLog
WebKit/WebCoreSupport/WebFrameBridge.m
WebKit/WebView/WebHTMLView.m