2007-01-11 Mitz Pettel <mitz@webkit.org>
authorbdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 Jan 2007 04:29:50 +0000 (04:29 +0000)
committerbdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 Jan 2007 04:29:50 +0000 (04:29 +0000)
commit43c7fd94599055595ca19b02e02f13d3490e15f5
tree82794349805315093d88685ef769704c96459922
parentdcc63bc77eb8988bc4629c89efd48ca1256bd72e
2007-01-11  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12124
          RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}

        * rendering/RenderTable.cpp:
        (WebCore::resetSectionPointerIfNotBefore): Added this function to help with
        checking if a section being inserted is the going to be the first of its kind.
        (WebCore::RenderTable::addChild): Changed to maintain the pointers to the
        header, the footer, the caption and the first table body properly when objects
        are inserted in the middle. Also changed to make the first caption win over
        any other captions. This matches Firefox and what already used to happen when a
        section recalc took place.
        (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating
        over the sections from top to bottom.
        (WebCore::RenderTable::calcBorderLeft): Changed to really find the section
        containing the first row.
        (WebCore::RenderTable::calcBorderRight): Ditto.
        (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was
        skipped if the input was the footer.
        (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header"
        respectively.

2007-01-11  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Hyatt.

        - updated results for http://bugs.webkit.org/show_bug.cgi?id=12124
          RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}

        Collapsed borders changed in the "marvin" tests, as the footer cells now
        collapse correctly with the last row of the body. Visual differences not
        captured by the pixel results since they occurred below 600px.

        The "other" test has changed since in a table with multiple captions,
        now the first one wins. No visual difference in this case since both captions
        are the same.

        * tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
        * tables/mozilla/marvin/backgr_position-table-expected.txt:
        * tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
        * tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
        * tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
        * tables/mozilla/marvin/backgr_simple-table-expected.txt:
        * tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
        * tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
        * tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
27 files changed:
LayoutTests/ChangeLog
LayoutTests/tables/mozilla/marvin/backgr_layers-opacity-expected.txt
LayoutTests/tables/mozilla/marvin/backgr_position-table-expected.txt
LayoutTests/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt
LayoutTests/tables/mozilla/marvin/backgr_simple-table-column-expected.txt
LayoutTests/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt
LayoutTests/tables/mozilla/marvin/backgr_simple-table-expected.txt
LayoutTests/tables/mozilla/marvin/backgr_simple-table-row-expected.txt
LayoutTests/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt
LayoutTests/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt
LayoutTests/tables/mozilla_expected_failures/other/test4-expected.txt
WebCore/ChangeLog
WebCore/rendering/RenderTable.cpp