REGRESSION (r143643): Buttons containing floats render differently
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Mar 2013 02:46:44 +0000 (02:46 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Mar 2013 02:46:44 +0000 (02:46 +0000)
commit405d8b5b95d14b92763db25a3e16ad3fa0da1706
treeb56f34d2832857d4f797f2e514f8fc2799cc2070
parentb244aac8672dd72eb9425c7126380dc3c2cf4f2b
REGRESSION (r143643): Buttons containing floats render differently
https://bugs.webkit.org/show_bug.cgi?id=110933

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-04
Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/forms/button-with-float.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
Also include new flexbox as a renderer that needs to enclose
overhanging floats. Flex boxes establish a block formatting context,
so they need to contain floats:
http://dev.w3.org/csswg/css3-flexbox/#flex-items

LayoutTests:

* css3/flexbox/float-inside-flexitem-expected.html: Added.
* css3/flexbox/float-inside-flexitem.html: Added.
* fast/forms/button-with-float-expected.html: Added.
* fast/forms/button-with-float.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/css3/flexbox/float-inside-flexitem-expected.html [new file with mode: 0644]
LayoutTests/css3/flexbox/float-inside-flexitem.html [new file with mode: 0644]
LayoutTests/fast/forms/button-with-float-expected.html [new file with mode: 0644]
LayoutTests/fast/forms/button-with-float.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBlock.cpp