update-work-items should never delete items
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Oct 2014 23:49:30 +0000 (23:49 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Oct 2014 23:49:30 +0000 (23:49 +0000)
commit3e3b64d1718936b94582bfc1ea47faa48103314d
treeddd87d2f289c2f5210240ed77bb6edfd716d2e3b
parent5f4ba9ed094827d1fa985cbe91812dc63f2930a4
update-work-items should never delete items
https://bugs.webkit.org/show_bug.cgi?id=137366

Reviewed by Ryosuke Niwa.

As we don't just replace the whole list any more, indicate which items are high
priority, and which are not. Hight priority ones will be prepended to the queue,
others will be appended.

This creates a bit of unfairness in that high priority item queue becomes a LIFO.
But hopefully we will never have many rollouts competing like that.

* QueueStatusServer/app.yaml: Update version.

* QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
priority and regular items separately. Removed some error handling that used to
end up in returning status 500 - an uncaught exception does that automatically.

* QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.

* QueueStatusServer/model/workitems.py: Added a way to add high priority items.

* QueueStatusServer/templates/updateworkitems.html: Added a field for high
priority items.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
line that complicated testing.

* Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.

* Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
priority items into separate lists.

* Scripts/webkitpy/common/net/statusserver_mock.py:
* Scripts/webkitpy/tool/bot/feeders_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
Updated tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
12 files changed:
Tools/ChangeLog
Tools/QueueStatusServer/app.yaml
Tools/QueueStatusServer/handlers/updateworkitems.py
Tools/QueueStatusServer/main.py
Tools/QueueStatusServer/model/workitems.py
Tools/QueueStatusServer/templates/updateworkitems.html
Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
Tools/Scripts/webkitpy/common/net/statusserver.py
Tools/Scripts/webkitpy/common/net/statusserver_mock.py
Tools/Scripts/webkitpy/tool/bot/feeders.py
Tools/Scripts/webkitpy/tool/bot/feeders_unittest.py
Tools/Scripts/webkitpy/tool/commands/queues_unittest.py