Remove now-unnecessary Connection::sendMessageWithReply
authorachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 May 2019 19:40:21 +0000 (19:40 +0000)
committerachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 May 2019 19:40:21 +0000 (19:40 +0000)
commit3c57544803cd7b4dce64b4a6c8f0d5e043f2d3d1
treee01c417fe5b01ddd0b80ead5c3d3ae00404648de
parentb56240c93d3b04936cc9b6a349e27db47b6f643e
Remove now-unnecessary Connection::sendMessageWithReply
https://bugs.webkit.org/show_bug.cgi?id=197747

Reviewed by Tim Horton.

The WebProcess messages that use it already do the right thing with CompletionHandlers and can be replaced by sendWithAsyncReply.
The SecItemShim message that uses it can be replaced by sendSync.

This patch only increases responsiveness when clearing website data and removes the need for a WorkQueue dedicated entirely to the SecItemShim.

* Platform/IPC/Connection.cpp:
(IPC::Connection::invalidate):
(IPC::Connection::processIncomingSyncReply):
(IPC::Connection::connectionDidClose):
(IPC::Connection::sendMessageWithReply): Deleted.
* Platform/IPC/Connection.h:
(IPC::Connection::send):
(IPC::Connection::sendWithReply): Deleted.
* Shared/mac/SecItemResponseData.h:
* Shared/mac/SecItemShim.cpp:
(WebKit::sendSecItemRequest):
(WebKit::workQueue): Deleted.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebKit/ChangeLog
Source/WebKit/Platform/IPC/Connection.cpp
Source/WebKit/Platform/IPC/Connection.h
Source/WebKit/Shared/mac/SecItemResponseData.h
Source/WebKit/Shared/mac/SecItemShim.cpp
Source/WebKit/UIProcess/WebProcessProxy.cpp
Source/WebKit/WebProcess/WebProcess.messages.in