perf-o-matic should store test results' units
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 2 Apr 2012 04:48:35 +0000 (04:48 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 2 Apr 2012 04:48:35 +0000 (04:48 +0000)
commit39be08f5609040ce98d7cdefbaa95e3013f520f9
tree58c482d33772c4468a8197011da64255adf88541
parentbcf7985f579cc3e6ad27df026b6956276e406f47
perf-o-matic should store test results' units
https://bugs.webkit.org/show_bug.cgi?id=82852

Reviewed by Kentaro Hara.

.:

* Websites/webkit-perf.appspot.com/models.py:
(Test):
(Test.update_or_insert): Added "unit" to the argument list.
(Test.update_or_insert.execute): Store the unit.
(ReportLog.results_are_well_formed): Moved from ReportHandler.
(ReportLog.results_are_well_formed._is_float_convertible): Ditto.
* Websites/webkit-perf.appspot.com/models_unittest.py:
(TestModelTests.test_update_or_insert): Added a test case for "unit" argument.
(TestModelTests.test_update_or_insert_to_update): Ditto.
(ReportLogTests.test_results_are_well_formed): Added.
(ReportLogTests.test_results_are_well_formed.assert_results_are_well_formed): Added.
* Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post): Calls ReportLog.results_are_well_formed.
* Websites/webkit-perf.appspot.com/report_process_handler.py:
(ReportProcessHandler.post): Passes results['unit'] to Test.update_or_insert.

Tools:

Include units in the results JSON.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ChangeLog
Tools/ChangeLog
Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
Websites/webkit-perf.appspot.com/models.py
Websites/webkit-perf.appspot.com/models_unittest.py
Websites/webkit-perf.appspot.com/report_handler.py
Websites/webkit-perf.appspot.com/report_process_handler.py