[CSS Grid Layout] Vertical rectangles not considered as valid grid areas
authorsvillar@igalia.com <svillar@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 Mar 2014 12:43:47 +0000 (12:43 +0000)
committersvillar@igalia.com <svillar@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 Mar 2014 12:43:47 +0000 (12:43 +0000)
commit39acf8bfb6df1b614a7c2ac9f79da6becc2d8cb6
tree070ac9d4443f3d0d63c0228c4d872f08b4503373
parent00e40cbe961da1aa91a791cd977f4d4fa336792b
[CSS Grid Layout] Vertical rectangles not considered as valid grid areas
https://bugs.webkit.org/show_bug.cgi?id=130513

Reviewed by Andreas Kling.

Source/WebCore:

Grid areas sized as vertical rectangles were incorrectly
considered as invalid by the parser. That's because the condition
checking that each new row was adjacent to the previous one was
using the first row of the currently parsed grid area instead of
the last one.

Test: fast/css-grid-layout/grid-template-areas-get-set.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateAreas):

LayoutTests:

Added tests for grid areas sized as horizontal and vertical
rectangles. The tests were also renamed from grid-template to
grid-template-areas which better describe their nature.

* fast/css-grid-layout/grid-template-areas-get-set-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-template-get-set-expected.txt.
* fast/css-grid-layout/grid-template-areas-get-set.html: Renamed from LayoutTests/fast/css-grid-layout/grid-template-get-set.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/css-grid-layout/grid-template-areas-get-set-expected.txt [moved from LayoutTests/fast/css-grid-layout/grid-template-get-set-expected.txt with 89% similarity]
LayoutTests/fast/css-grid-layout/grid-template-areas-get-set.html [moved from LayoutTests/fast/css-grid-layout/grid-template-get-set.html with 89% similarity]
Source/WebCore/ChangeLog
Source/WebCore/css/CSSParser.cpp