Reviewed by Darin Adler.
authorap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 20 Oct 2008 15:13:11 +0000 (15:13 +0000)
committerap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 20 Oct 2008 15:13:11 +0000 (15:13 +0000)
commit37042241ee5e982662341d992f4f24e9c6987ac9
treed74fa99c4959892858416443a1407823923f85b3
parent3382c61912be5e79fca0efc1f1523278b217cfd3
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=21750
        Eliminate the notion of "temporary events"

        We mark some events as temporary when dispatching, for the sole reason of
        manually calling forgetDOMObject when done dispatching.

        There doesn't seem to be any reason to call it manually, as JSEvent destructor
        will do this automatically right away.

        * bindings/js/ScriptController.cpp:
        * bindings/js/ScriptController.h:
        Removed ScriptController::finishedWithEvent(), which was called after dispatching
        a temporary event.

        * dom/ContainerNode.cpp:
        (WebCore::dispatchChildInsertionEvents):
        (WebCore::dispatchChildRemovalEvents):
        * dom/EventTarget.h:
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchEvent):
        (WebCore::EventTargetNode::dispatchGenericEvent):
        (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
        (WebCore::EventTargetNode::dispatchWindowEvent):
        (WebCore::EventTargetNode::dispatchUIEvent):
        (WebCore::EventTargetNode::dispatchKeyEvent):
        (WebCore::EventTargetNode::dispatchMouseEvent):
        (WebCore::EventTargetNode::dispatchWheelEvent):
        (WebCore::EventTargetNode::dispatchWebKitAnimationEvent):
        (WebCore::EventTargetNode::dispatchWebKitTransitionEvent):
        (WebCore::EventTargetNode::dispatchEventForType):
        (WebCore::EventTargetNode::dispatchProgressEvent):
        (WebCore::EventTargetNode::dispatchStorageEvent):
        * dom/EventTargetNode.h:
        * dom/MessagePort.cpp:
        (WebCore::MessagePort::dispatchMessages):
        (WebCore::MessagePort::dispatchCloseEvent):
        (WebCore::MessagePort::dispatchEvent):
        * dom/MessagePort.h:
        * editing/Editor.cpp:
        (WebCore::Editor::dispatchCPPEvent):
        (WebCore::dispatchEditableContentChangedEvents):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::insertText):
        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::dispatchEvent):
        (WebCore::DOMApplicationCache::callListener):
        * loader/appcache/DOMApplicationCache.h:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchDragEvent):
        (WebCore::EventHandler::keyEvent):
        (WebCore::EventHandler::handleTextInputEvent):
        * page/FrameView.cpp:
        (WebCore::FrameView::scheduleEvent):
        (WebCore::FrameView::updateOverflowStatus):
        (WebCore::FrameView::dispatchScheduledEvents):
        * page/FrameView.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollToOffset):
        (WebCore::RenderLayer::updateOverflowStatus):
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::sendSVGLoadEventIfPossible):
        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::dispatchEvent):
        * svg/SVGElementInstance.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::dispatchEvent):
        (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent):
        (WebCore::XMLHttpRequest::dispatchXMLHttpRequestProgressEvent):
        * xml/XMLHttpRequest.h:
        * xml/XMLHttpRequestUpload.cpp:
        (WebCore::XMLHttpRequestUpload::dispatchEvent):
        (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent):
        * xml/XMLHttpRequestUpload.h:
        Don't pass the tempEvent boolean around.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
24 files changed:
WebCore/ChangeLog
WebCore/bindings/js/ScriptController.cpp
WebCore/bindings/js/ScriptController.h
WebCore/dom/ContainerNode.cpp
WebCore/dom/EventTarget.h
WebCore/dom/EventTargetNode.cpp
WebCore/dom/EventTargetNode.h
WebCore/dom/MessagePort.cpp
WebCore/dom/MessagePort.h
WebCore/editing/Editor.cpp
WebCore/editing/ReplaceSelectionCommand.cpp
WebCore/editing/TypingCommand.cpp
WebCore/loader/appcache/DOMApplicationCache.cpp
WebCore/loader/appcache/DOMApplicationCache.h
WebCore/page/EventHandler.cpp
WebCore/page/FrameView.cpp
WebCore/page/FrameView.h
WebCore/svg/SVGElement.cpp
WebCore/svg/SVGElementInstance.cpp
WebCore/svg/SVGElementInstance.h
WebCore/xml/XMLHttpRequest.cpp
WebCore/xml/XMLHttpRequest.h
WebCore/xml/XMLHttpRequestUpload.cpp
WebCore/xml/XMLHttpRequestUpload.h