iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test...
authordfarler@apple.com <dfarler@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Sep 2014 23:31:41 +0000 (23:31 +0000)
committerdfarler@apple.com <dfarler@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Sep 2014 23:31:41 +0000 (23:31 +0000)
commit348babaf258cc06cfa71245d0a5022270f159708
tree64667d5d29eabd179ce46fe2dfa8fc98e9a621f0
parent5aa2b49e60beae9a71599793136d7d88412cb29c
iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
https://bugs.webkit.org/show_bug.cgi?id=135551

Reviewed by Daniel Bates.

Prevent printing invalid Unicode strings going to stderr.
Also, make filesystem.py more tolerant about receiving
Unicode (encoded as UTF-8) when writing to files, in the
rare case that an NSError description will make it to
stderr, such as -[LTRelayController createUniqueApp].

* LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
(-[LTRelayController launchSimulator]): Removed.
(-[LTRelayController createUniqueApp]):
Don't explicitly try to uninstall the app. It is automatically handled
when installing an app with the same bundle identifier.
(-[LTRelayController start]):
(-[LTRelayController bootDevice]): Removed.
The device already boots as a part of starting the simulator. Attempting
to boot a second time may cause spurious stderr output.
* Scripts/webkitpy/port/driver.py:
(IOSSimulatorDriver._setup_environ_for_driver):
Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
Open the iOS Simulator once instead of the LayoutTestRelay trying
to do it.
* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._get_crash_log):
Make sure stderr is at least an empty string.
(IOSSimulatorPort):
(IOSSimulatorPort.developer_dir):
New property for setting up DEVELOPER_DIR in the driver environment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/fast/block/border-fit-with-right-alignment-expected.html
Tools/ChangeLog
Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m
Tools/Scripts/webkitpy/common/system/filesystem.py
Tools/Scripts/webkitpy/port/driver.py
Tools/Scripts/webkitpy/port/image_diff.py
Tools/Scripts/webkitpy/port/ios.py