2010-06-25 Alex Milowski <alex@milowski.com>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jun 2010 13:55:06 +0000 (13:55 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jun 2010 13:55:06 +0000 (13:55 +0000)
commit33b15d8faa3a384463f8dab4d18d2bf46550c8b7
tree36f477c09f04b2ed216df36167ab73db575262a5
parentce8b087a5c2b2fe124c789cc79504e50ad234d65
2010-06-25  Alex Milowski  <alex@milowski.com>

        Reviewed by Kenneth Rohde Christiansen.

        Added a test for row alignment, adjusted tests to better demonstrate their
        respective area of MathML, and updated the output for all the tests due to
        the change in vertical alignment of all MathML constructs.

        * mathml/presentation/mo.xhtml:
        * mathml/presentation/row-alignment.xhtml: Added.
        * mathml/presentation/row.xhtml:
        * mathml/presentation/sub.xhtml:
        * platform/mac/mathml/presentation/fractions-expected.checksum:
        * platform/mac/mathml/presentation/fractions-expected.png:
        * platform/mac/mathml/presentation/fractions-expected.txt:
        * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
        * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
        * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
        * platform/mac/mathml/presentation/mo-expected.checksum:
        * platform/mac/mathml/presentation/mo-expected.png:
        * platform/mac/mathml/presentation/mo-expected.txt:
        * platform/mac/mathml/presentation/over-expected.checksum:
        * platform/mac/mathml/presentation/over-expected.png:
        * platform/mac/mathml/presentation/over-expected.txt:
        * platform/mac/mathml/presentation/roots-expected.checksum:
        * platform/mac/mathml/presentation/roots-expected.png:
        * platform/mac/mathml/presentation/roots-expected.txt:
        * platform/mac/mathml/presentation/row-alignment-expected.checksum: Added.
        * platform/mac/mathml/presentation/row-alignment-expected.png: Added.
        * platform/mac/mathml/presentation/row-alignment-expected.txt: Added.
        * platform/mac/mathml/presentation/row-expected.checksum:
        * platform/mac/mathml/presentation/row-expected.png:
        * platform/mac/mathml/presentation/row-expected.txt:
        * platform/mac/mathml/presentation/sub-expected.checksum:
        * platform/mac/mathml/presentation/sub-expected.png:
        * platform/mac/mathml/presentation/sub-expected.txt:
        * platform/mac/mathml/presentation/subsup-expected.checksum:
        * platform/mac/mathml/presentation/subsup-expected.png:
        * platform/mac/mathml/presentation/subsup-expected.txt:
        * platform/mac/mathml/presentation/sup-expected.checksum:
        * platform/mac/mathml/presentation/sup-expected.png:
        * platform/mac/mathml/presentation/sup-expected.txt:
        * platform/mac/mathml/presentation/tables-expected.checksum:
        * platform/mac/mathml/presentation/tables-expected.png:
        * platform/mac/mathml/presentation/tables-expected.txt:
        * platform/mac/mathml/presentation/under-expected.checksum:
        * platform/mac/mathml/presentation/under-expected.png:
        * platform/mac/mathml/presentation/under-expected.txt:
        * platform/mac/mathml/presentation/underover-expected.checksum:
        * platform/mac/mathml/presentation/underover-expected.png:
        * platform/mac/mathml/presentation/underover-expected.txt:
2010-06-25  Alex Milowski  <alex@milowski.com>

        Reviewed by Kenneth Rohde Christiansen.

        This patch changes the vertical alignment to rely upon baseline
        alignment for all MathML rendering.  This fixes a number of layout
        issues and the implementation is much more clean.

        Also, this patch adds a horizontal green line in the debug layout
        so you can see the top padding of any RenderMathMLBlock instance.

        Test: mathml/presentation/row-alignment.xhtml

        * css/mathml.css:
        * mathml/RenderMathMLBlock.cpp:
        * mathml/RenderMathMLFraction.cpp:
        * mathml/RenderMathMLFraction.h:
        * mathml/RenderMathMLOperator.cpp:
        * mathml/RenderMathMLOperator.h:
        * mathml/RenderMathMLRoot.cpp:
        * mathml/RenderMathMLRow.cpp:
        * mathml/RenderMathMLRow.h:
        * mathml/RenderMathMLSquareRoot.cpp:
        * mathml/RenderMathMLSubSup.cpp:
        * mathml/RenderMathMLUnderOver.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
57 files changed:
LayoutTests/ChangeLog
LayoutTests/mathml/presentation/mo.xhtml
LayoutTests/mathml/presentation/row-alignment.xhtml [new file with mode: 0644]
LayoutTests/mathml/presentation/row.xhtml
LayoutTests/mathml/presentation/sub.xhtml
LayoutTests/platform/mac/mathml/presentation/fractions-expected.checksum
LayoutTests/platform/mac/mathml/presentation/fractions-expected.png
LayoutTests/platform/mac/mathml/presentation/fractions-expected.txt
LayoutTests/platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum
LayoutTests/platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png
LayoutTests/platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt
LayoutTests/platform/mac/mathml/presentation/mo-expected.checksum
LayoutTests/platform/mac/mathml/presentation/mo-expected.png
LayoutTests/platform/mac/mathml/presentation/mo-expected.txt
LayoutTests/platform/mac/mathml/presentation/over-expected.checksum
LayoutTests/platform/mac/mathml/presentation/over-expected.png
LayoutTests/platform/mac/mathml/presentation/over-expected.txt
LayoutTests/platform/mac/mathml/presentation/roots-expected.checksum
LayoutTests/platform/mac/mathml/presentation/roots-expected.png
LayoutTests/platform/mac/mathml/presentation/roots-expected.txt
LayoutTests/platform/mac/mathml/presentation/row-alignment-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/mathml/presentation/row-alignment-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/mathml/presentation/row-alignment-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/mathml/presentation/row-expected.checksum
LayoutTests/platform/mac/mathml/presentation/row-expected.png
LayoutTests/platform/mac/mathml/presentation/row-expected.txt
LayoutTests/platform/mac/mathml/presentation/sub-expected.checksum
LayoutTests/platform/mac/mathml/presentation/sub-expected.png
LayoutTests/platform/mac/mathml/presentation/sub-expected.txt
LayoutTests/platform/mac/mathml/presentation/subsup-expected.checksum
LayoutTests/platform/mac/mathml/presentation/subsup-expected.png
LayoutTests/platform/mac/mathml/presentation/subsup-expected.txt
LayoutTests/platform/mac/mathml/presentation/sup-expected.checksum
LayoutTests/platform/mac/mathml/presentation/sup-expected.png
LayoutTests/platform/mac/mathml/presentation/sup-expected.txt
LayoutTests/platform/mac/mathml/presentation/tables-expected.checksum
LayoutTests/platform/mac/mathml/presentation/tables-expected.png
LayoutTests/platform/mac/mathml/presentation/tables-expected.txt
LayoutTests/platform/mac/mathml/presentation/under-expected.checksum
LayoutTests/platform/mac/mathml/presentation/under-expected.png
LayoutTests/platform/mac/mathml/presentation/under-expected.txt
LayoutTests/platform/mac/mathml/presentation/underover-expected.checksum
LayoutTests/platform/mac/mathml/presentation/underover-expected.png
LayoutTests/platform/mac/mathml/presentation/underover-expected.txt
WebCore/ChangeLog
WebCore/css/mathml.css
WebCore/mathml/RenderMathMLBlock.cpp
WebCore/mathml/RenderMathMLFraction.cpp
WebCore/mathml/RenderMathMLFraction.h
WebCore/mathml/RenderMathMLOperator.cpp
WebCore/mathml/RenderMathMLOperator.h
WebCore/mathml/RenderMathMLRoot.cpp
WebCore/mathml/RenderMathMLRow.cpp
WebCore/mathml/RenderMathMLRow.h
WebCore/mathml/RenderMathMLSquareRoot.cpp
WebCore/mathml/RenderMathMLSubSup.cpp
WebCore/mathml/RenderMathMLUnderOver.cpp