Remove feature: CSS variables
authorantti@apple.com <antti@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Nov 2013 15:46:53 +0000 (15:46 +0000)
committerantti@apple.com <antti@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Nov 2013 15:46:53 +0000 (15:46 +0000)
commit32c5693f92fbbcdc736b29f04aaadfcf92d4b2a7
tree997b743d5c307bdb391e6f7dd44e98cb2ce768c5
parent5ecc4b3c9c74e830043389997c31d496b2f082a3
Remove feature: CSS variables
https://bugs.webkit.org/show_bug.cgi?id=114119

.:

Reviewed by Andreas Kling.

* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Reviewed by Andreas Kling.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Andreas Kling.

The feature is unmaintained and it is getting in the way of refactoring. Code quality is not up to
WebKit standards either.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.list.am:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSBasicShapes.cpp:
* css/CSSBasicShapes.h:
* css/CSSCalculationValue.cpp:
(WebCore::unitCategory):
(WebCore::hasDoubleValue):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::determineCategory):
(WebCore::CSSCalcBinaryOperation::primitiveType):
* css/CSSCalculationValue.h:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::realLex):
* css/CSSParser.h:
* css/CSSParserMode.h:
* css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
* css/CSSParserValues.h:
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::equals):
* css/CSSPrimitiveValue.h:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
* css/CSSProperty.cpp:
* css/CSSProperty.h:
(WebCore::CSSProperty::CSSProperty):
* css/CSSReflectValue.cpp:
* css/CSSReflectValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::setCssText):
* css/CSSValueList.cpp:
* css/CSSValueList.h:
* css/CSSVariableValue.h: Removed.
* css/Pair.h:
* css/Rect.h:
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::PropertyReference::cssName):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):
* css/StyleResolver.h:
* css/WebKitCSSTransformValue.cpp:
* css/WebKitCSSTransformValue.h:
(WebCore::WebKitCSSTransformValue::equals):
* css/makeprop.pl:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleVariableData.h: Removed.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit/mac:

Reviewed by Andreas Kling.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Andreas Kling.

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Andreas Kling.

* wtf/FeatureDefines.h:

Tools:

Reviewed by Andreas Kling.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Reviewed by Andreas Kling.

* fast/css/variables: Removed.
* fast/css/variables/border-width-expected.html: Removed.
* fast/css/variables/border-width.html: Removed.
* fast/css/variables/build-supports-variables-expected.txt: Removed.
* fast/css/variables/build-supports-variables.html: Removed.
* fast/css/variables/calc-expected.html: Removed.
* fast/css/variables/calc-inside-calc-expected.html: Removed.
* fast/css/variables/calc-inside-calc.html: Removed.
* fast/css/variables/calc-invalid-value-expected.html: Removed.
* fast/css/variables/calc-invalid-value.html: Removed.
* fast/css/variables/calc-invalid-variable-expected.html: Removed.
* fast/css/variables/calc-invalid-variable.html: Removed.
* fast/css/variables/calc-negated-variable-expected.html: Removed.
* fast/css/variables/calc-negated-variable.html: Removed.
* fast/css/variables/calc-vw-crash-expected.txt: Removed.
* fast/css/variables/calc-vw-crash.html: Removed.
* fast/css/variables/calc.html: Removed.
* fast/css/variables/case-sensitive-expected.html: Removed.
* fast/css/variables/case-sensitive.html: Removed.
* fast/css/variables/colors-test-expected.html: Removed.
* fast/css/variables/colors-test.html: Removed.
* fast/css/variables/complex-cycle-expected.html: Removed.
* fast/css/variables/complex-cycle.html: Removed.
* fast/css/variables/computed-style-expected.html: Removed.
* fast/css/variables/computed-style.html: Removed.
* fast/css/variables/deferred-image-load-from-variable-expected.txt: Removed.
* fast/css/variables/deferred-image-load-from-variable.html: Removed.
* fast/css/variables/inherited-values-expected.html: Removed.
* fast/css/variables/inherited-values.html: Removed.
* fast/css/variables/inline-styles-expected.html: Removed.
* fast/css/variables/inline-styles.html: Removed.
* fast/css/variables/invalid-font-reference-expected.txt: Removed.
* fast/css/variables/invalid-font-reference.html: Removed.
* fast/css/variables/invalid-shorthand-expected.html: Removed.
* fast/css/variables/invalid-shorthand.html: Removed.
* fast/css/variables/invalid-value-list-crash-expected.txt: Removed.
* fast/css/variables/invalid-value-list-crash.html: Removed.
* fast/css/variables/invalid-variable-value-expected.html: Removed.
* fast/css/variables/invalid-variable-value.html: Removed.
* fast/css/variables/multi-level-cycle-expected.html: Removed.
* fast/css/variables/multi-level-cycle.html: Removed.
* fast/css/variables/redefinition-expected.html: Removed.
* fast/css/variables/redefinition.html: Removed.
* fast/css/variables/root-background-size-expected.html: Removed.
* fast/css/variables/root-background-size.html: Removed.
* fast/css/variables/shorthand-expected.html: Removed.
* fast/css/variables/shorthand.html: Removed.
* fast/css/variables/simple-cycle-expected.html: Removed.
* fast/css/variables/simple-cycle.html: Removed.
* fast/css/variables/transform-test-expected.html: Removed.
* fast/css/variables/transform-test.html: Removed.
* fast/css/variables/undefined-expected.html: Removed.
* fast/css/variables/undefined.html: Removed.
* fast/css/variables/use-before-defined-expected.html: Removed.
* fast/css/variables/use-before-defined.html: Removed.
* fast/css/variables/var-filter-expected.txt: Removed.
* fast/css/variables/var-filter.html: Removed.
* fast/css/variables/var-inside-box-reflect-expected.html: Removed.
* fast/css/variables/var-inside-box-reflect.html: Removed.
* fast/css/variables/var-inside-pair-expected.html: Removed.
* fast/css/variables/var-inside-pair.html: Removed.
* fast/css/variables/var-inside-quad-expected.html: Removed.
* fast/css/variables/var-inside-quad.html: Removed.
* fast/css/variables/var-inside-shape-expected.html: Removed.
* fast/css/variables/var-inside-shape.html: Removed.
* fast/css/variables/var-inside-shorthand-expected.html: Removed.
* fast/css/variables/var-inside-shorthand.html: Removed.
* fast/css/variables/variable-chain-expected.html: Removed.
* fast/css/variables/variable-chain.html: Removed.
* fast/css/variables/variable-unparseable-value-crash-expected.txt: Removed.
* fast/css/variables/variable-unparseable-value-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
132 files changed:
ChangeLog
LayoutTests/ChangeLog
LayoutTests/fast/css/variables/border-width-expected.html [deleted file]
LayoutTests/fast/css/variables/border-width.html [deleted file]
LayoutTests/fast/css/variables/build-supports-variables-expected.txt [deleted file]
LayoutTests/fast/css/variables/build-supports-variables.html [deleted file]
LayoutTests/fast/css/variables/calc-expected.html [deleted file]
LayoutTests/fast/css/variables/calc-inside-calc-expected.html [deleted file]
LayoutTests/fast/css/variables/calc-inside-calc.html [deleted file]
LayoutTests/fast/css/variables/calc-invalid-value-expected.html [deleted file]
LayoutTests/fast/css/variables/calc-invalid-value.html [deleted file]
LayoutTests/fast/css/variables/calc-invalid-variable-expected.html [deleted file]
LayoutTests/fast/css/variables/calc-invalid-variable.html [deleted file]
LayoutTests/fast/css/variables/calc-negated-variable-expected.html [deleted file]
LayoutTests/fast/css/variables/calc-negated-variable.html [deleted file]
LayoutTests/fast/css/variables/calc-vw-crash-expected.txt [deleted file]
LayoutTests/fast/css/variables/calc-vw-crash.html [deleted file]
LayoutTests/fast/css/variables/calc.html [deleted file]
LayoutTests/fast/css/variables/case-sensitive-expected.html [deleted file]
LayoutTests/fast/css/variables/case-sensitive.html [deleted file]
LayoutTests/fast/css/variables/colors-test-expected.html [deleted file]
LayoutTests/fast/css/variables/colors-test.html [deleted file]
LayoutTests/fast/css/variables/complex-cycle-expected.html [deleted file]
LayoutTests/fast/css/variables/complex-cycle.html [deleted file]
LayoutTests/fast/css/variables/computed-style-expected.html [deleted file]
LayoutTests/fast/css/variables/computed-style.html [deleted file]
LayoutTests/fast/css/variables/deferred-image-load-from-variable-expected.txt [deleted file]
LayoutTests/fast/css/variables/deferred-image-load-from-variable.html [deleted file]
LayoutTests/fast/css/variables/inherited-values-expected.html [deleted file]
LayoutTests/fast/css/variables/inherited-values.html [deleted file]
LayoutTests/fast/css/variables/inline-styles-expected.html [deleted file]
LayoutTests/fast/css/variables/inline-styles.html [deleted file]
LayoutTests/fast/css/variables/invalid-font-reference-expected.txt [deleted file]
LayoutTests/fast/css/variables/invalid-font-reference.html [deleted file]
LayoutTests/fast/css/variables/invalid-shorthand-expected.html [deleted file]
LayoutTests/fast/css/variables/invalid-shorthand.html [deleted file]
LayoutTests/fast/css/variables/invalid-value-list-crash-expected.txt [deleted file]
LayoutTests/fast/css/variables/invalid-value-list-crash.html [deleted file]
LayoutTests/fast/css/variables/invalid-variable-value-expected.html [deleted file]
LayoutTests/fast/css/variables/invalid-variable-value.html [deleted file]
LayoutTests/fast/css/variables/multi-level-cycle-expected.html [deleted file]
LayoutTests/fast/css/variables/multi-level-cycle.html [deleted file]
LayoutTests/fast/css/variables/redefinition-expected.html [deleted file]
LayoutTests/fast/css/variables/redefinition.html [deleted file]
LayoutTests/fast/css/variables/root-background-size-expected.html [deleted file]
LayoutTests/fast/css/variables/root-background-size.html [deleted file]
LayoutTests/fast/css/variables/shorthand-expected.html [deleted file]
LayoutTests/fast/css/variables/shorthand.html [deleted file]
LayoutTests/fast/css/variables/simple-cycle-expected.html [deleted file]
LayoutTests/fast/css/variables/simple-cycle.html [deleted file]
LayoutTests/fast/css/variables/transform-test-expected.html [deleted file]
LayoutTests/fast/css/variables/transform-test.html [deleted file]
LayoutTests/fast/css/variables/undefined-expected.html [deleted file]
LayoutTests/fast/css/variables/undefined.html [deleted file]
LayoutTests/fast/css/variables/use-before-defined-expected.html [deleted file]
LayoutTests/fast/css/variables/use-before-defined.html [deleted file]
LayoutTests/fast/css/variables/var-filter-expected.txt [deleted file]
LayoutTests/fast/css/variables/var-filter.html [deleted file]
LayoutTests/fast/css/variables/var-inside-box-reflect-expected.html [deleted file]
LayoutTests/fast/css/variables/var-inside-box-reflect.html [deleted file]
LayoutTests/fast/css/variables/var-inside-pair-expected.html [deleted file]
LayoutTests/fast/css/variables/var-inside-pair.html [deleted file]
LayoutTests/fast/css/variables/var-inside-quad-expected.html [deleted file]
LayoutTests/fast/css/variables/var-inside-quad.html [deleted file]
LayoutTests/fast/css/variables/var-inside-shape-expected.html [deleted file]
LayoutTests/fast/css/variables/var-inside-shape.html [deleted file]
LayoutTests/fast/css/variables/var-inside-shorthand-expected.html [deleted file]
LayoutTests/fast/css/variables/var-inside-shorthand.html [deleted file]
LayoutTests/fast/css/variables/variable-chain-expected.html [deleted file]
LayoutTests/fast/css/variables/variable-chain.html [deleted file]
LayoutTests/fast/css/variables/variable-unparseable-value-crash-expected.txt [deleted file]
LayoutTests/fast/css/variables/variable-unparseable-value-crash.html [deleted file]
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Source/WTF/ChangeLog
Source/WTF/wtf/FeatureDefines.h
Source/WTF/wtf/nix/FeatureDefinesNix.h
Source/WebCore/ChangeLog
Source/WebCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/GNUmakefile.list.am
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/css/CSSBasicShapes.cpp
Source/WebCore/css/CSSBasicShapes.h
Source/WebCore/css/CSSCalculationValue.cpp
Source/WebCore/css/CSSCalculationValue.h
Source/WebCore/css/CSSComputedStyleDeclaration.cpp
Source/WebCore/css/CSSGrammar.y.in
Source/WebCore/css/CSSParser.cpp
Source/WebCore/css/CSSParser.h
Source/WebCore/css/CSSParserMode.h
Source/WebCore/css/CSSParserValues.cpp
Source/WebCore/css/CSSParserValues.h
Source/WebCore/css/CSSPrimitiveValue.cpp
Source/WebCore/css/CSSPrimitiveValue.h
Source/WebCore/css/CSSPrimitiveValueMappings.h
Source/WebCore/css/CSSProperty.cpp
Source/WebCore/css/CSSProperty.h
Source/WebCore/css/CSSReflectValue.cpp
Source/WebCore/css/CSSReflectValue.h
Source/WebCore/css/CSSValue.cpp
Source/WebCore/css/CSSValue.h
Source/WebCore/css/CSSValueList.cpp
Source/WebCore/css/CSSValueList.h
Source/WebCore/css/CSSVariableValue.h [deleted file]
Source/WebCore/css/Pair.h
Source/WebCore/css/Rect.h
Source/WebCore/css/StylePropertySet.cpp
Source/WebCore/css/StyleResolver.cpp
Source/WebCore/css/StyleResolver.h
Source/WebCore/css/WebKitCSSTransformValue.cpp
Source/WebCore/css/WebKitCSSTransformValue.h
Source/WebCore/css/makeprop.pl
Source/WebCore/page/Settings.cpp
Source/WebCore/page/Settings.h
Source/WebCore/rendering/style/RenderStyle.h
Source/WebCore/rendering/style/StyleRareInheritedData.cpp
Source/WebCore/rendering/style/StyleRareInheritedData.h
Source/WebCore/rendering/style/StyleVariableData.h [deleted file]
Source/WebCore/testing/InternalSettings.cpp
Source/WebCore/testing/InternalSettings.h
Source/WebCore/testing/InternalSettings.idl
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
Source/WebKit2/ChangeLog
Source/WebKit2/Configurations/FeatureDefines.xcconfig
Source/autotools/SetupWebKitFeatures.m4
Source/cmake/OptionsEfl.cmake
Source/cmake/OptionsGTK.cmake
Source/cmake/WebKitFeatures.cmake
Source/cmakeconfig.h.cmake
Tools/ChangeLog
Tools/Scripts/webkitperl/FeatureList.pm