Remove WebKitCSSFilterValue to make Hyatt happy
authordino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 1 Nov 2016 22:31:52 +0000 (22:31 +0000)
committerdino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 1 Nov 2016 22:31:52 +0000 (22:31 +0000)
commit31add2215b27857b2a98b9118f07bf73c75ea4bc
treead006b1ac8e027d8da76d5d38c9379c07b387d19
parentab2317b3613fb5a9a17a8f50f750269826203fa5
Remove WebKitCSSFilterValue to make Hyatt happy
https://bugs.webkit.org/show_bug.cgi?id=164289
<rdar://problems/29050973>

Reviewed by Simon Fraser.

Source/WebCore:

The new CSS parser should not use WebKitCSSFilterValue. It's non-standard,
very likely only used in our tests, doesn't provide much benefit, and will be
covered by the new CSSOM function interface.

Covered by modifying existing tests.

* DerivedSources.make: Remove WebKitCSSFilterValue.idl.

* WebCore.xcodeproj/project.pbxproj: Make CSSFunctionValue.h private so API testing
can see it.

* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJSNewlyCreated): No WebKitCSSFilterValue.

* css/CSSComputedStyleDeclaration.cpp: Use CSSFunctionValue or CSSPrimitiveValue to
build up the computed style.
(WebCore::ComputedStyleExtractor::valueForFilter):

* css/CSSValue.cpp: No WebKitCSSFilterValue.
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
* css/CSSValue.h:
(WebCore::CSSValue::isFilterImageValue):
(WebCore::CSSValue::isWebKitCSSFilterValue): Deleted.

* css/StyleResolver.cpp: Resolve against CSSFunctionValues with
CSSValueIDs as name, rather than WebKitCSSFilterValue.
(WebCore::filterOperationForType):
(WebCore::StyleResolver::createFilterOperations):
* css/StyleResolver.h:

* css/WebKitCSSFilterValue.cpp: Removed.
* css/WebKitCSSFilterValue.h: Removed.
* css/WebKitCSSFilterValue.idl: Removed.

* css/parser/CSSParser.cpp: Parse into CSSPrimitiveValue and CSSFunctionValue.
(WebCore::isValidPrimitiveFilterFunction):
(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::cssValueKeywordIDForFunctionName):
(WebCore::CSSParser::parseFilter):
(WebCore::filterInfoForName): Deleted.
* css/parser/CSSParser.h:
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeFilterFunction):

LayoutTests:

Update the filters tests now that WebKitCSSFilterValue no longer exists.
Unfortunately CSSFunctionValue isn't exposed to the Web, so we just
rely on the cssText of the resulting CSSStyleDeclaration.

I also moved all the script-tests into the HTML files, since there is
no point them being separate.

* css3/filters/backdrop/backdropfilter-property-computed-style-expected.txt:
* css3/filters/backdrop/backdropfilter-property-computed-style.html:
* css3/filters/backdrop/backdropfilter-property-parsing-expected.txt:
* css3/filters/backdrop/backdropfilter-property-parsing-invalid.html:
* css3/filters/backdrop/backdropfilter-property-parsing.html:
* css3/filters/backdrop/backdropfilter-property.html:
* css3/filters/backdrop/script-tests/backdropfilter-property-computed-style.js: Removed.
* css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js: Removed.
* css3/filters/backdrop/script-tests/backdropfilter-property-parsing.js: Removed.
* css3/filters/backdrop/script-tests/backdropfilter-property.js: Removed.
* css3/filters/effect-reference-delete-crash.html:
* css3/filters/effect-reference-reset-style-delete-crash.html:
* css3/filters/filter-property-computed-style-expected.txt:
* css3/filters/filter-property-computed-style.html:
* css3/filters/filter-property-parsing-expected.txt:
* css3/filters/filter-property-parsing-invalid.html:
* css3/filters/filter-property-parsing.html:
* css3/filters/filter-property.html:
* css3/filters/script-tests/TEMPLATE.html: Removed.
* css3/filters/script-tests/effect-reference-delete-crash.js: Removed.
* css3/filters/script-tests/effect-reference-reset-style-delete-crash.js: Removed.
* css3/filters/script-tests/filter-property-computed-style.js: Removed.
* css3/filters/script-tests/filter-property-parsing-invalid.js: Removed.
* css3/filters/script-tests/filter-property-parsing.js: Removed.
* css3/filters/script-tests/filter-property.js: Removed.
* css3/filters/script-tests/unprefixed.js: Removed.
* css3/filters/unprefixed-expected.txt:
* css3/filters/unprefixed.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@208253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
55 files changed:
LayoutTests/ChangeLog
LayoutTests/css3/filters/backdrop/add-remove-add-backdrop-filter.html
LayoutTests/css3/filters/backdrop/backdropfilter-property-computed-style-expected.txt
LayoutTests/css3/filters/backdrop/backdropfilter-property-computed-style.html
LayoutTests/css3/filters/backdrop/backdropfilter-property-parsing-expected.txt
LayoutTests/css3/filters/backdrop/backdropfilter-property-parsing-invalid.html
LayoutTests/css3/filters/backdrop/backdropfilter-property-parsing.html
LayoutTests/css3/filters/backdrop/backdropfilter-property.html
LayoutTests/css3/filters/backdrop/script-tests/backdropfilter-property-computed-style.js [deleted file]
LayoutTests/css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js [deleted file]
LayoutTests/css3/filters/backdrop/script-tests/backdropfilter-property-parsing.js [deleted file]
LayoutTests/css3/filters/backdrop/script-tests/backdropfilter-property.js [deleted file]
LayoutTests/css3/filters/effect-reference-delete-crash.html
LayoutTests/css3/filters/effect-reference-reset-style-delete-crash.html
LayoutTests/css3/filters/filter-property-computed-style-expected.txt
LayoutTests/css3/filters/filter-property-computed-style.html
LayoutTests/css3/filters/filter-property-parsing-expected.txt
LayoutTests/css3/filters/filter-property-parsing-invalid.html
LayoutTests/css3/filters/filter-property-parsing.html
LayoutTests/css3/filters/filter-property.html
LayoutTests/css3/filters/script-tests/TEMPLATE.html [deleted file]
LayoutTests/css3/filters/script-tests/effect-reference-delete-crash.js [deleted file]
LayoutTests/css3/filters/script-tests/effect-reference-reset-style-delete-crash.js [deleted file]
LayoutTests/css3/filters/script-tests/filter-property-computed-style.js [deleted file]
LayoutTests/css3/filters/script-tests/filter-property-parsing-invalid.js [deleted file]
LayoutTests/css3/filters/script-tests/filter-property-parsing.js [deleted file]
LayoutTests/css3/filters/script-tests/filter-property.js [deleted file]
LayoutTests/css3/filters/script-tests/unprefixed.js [deleted file]
LayoutTests/css3/filters/unprefixed-expected.txt
LayoutTests/css3/filters/unprefixed.html
LayoutTests/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/WebCore/DerivedSources.cpp
Source/WebCore/DerivedSources.make
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/bindings/js/JSCSSValueCustom.cpp
Source/WebCore/css/CSSAllInOne.cpp
Source/WebCore/css/CSSComputedStyleDeclaration.cpp
Source/WebCore/css/CSSValue.cpp
Source/WebCore/css/CSSValue.h
Source/WebCore/css/StyleResolver.cpp
Source/WebCore/css/StyleResolver.h
Source/WebCore/css/WebKitCSSFilterValue.cpp [deleted file]
Source/WebCore/css/WebKitCSSFilterValue.h [deleted file]
Source/WebCore/css/WebKitCSSFilterValue.idl [deleted file]
Source/WebCore/css/parser/CSSParser.cpp
Source/WebCore/css/parser/CSSParser.h
Source/WebCore/css/parser/CSSPropertyParser.cpp