Alias "system-ui" for the System font name
authorjonlee@apple.com <jonlee@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 25 Feb 2017 02:07:12 +0000 (02:07 +0000)
committerjonlee@apple.com <jonlee@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 25 Feb 2017 02:07:12 +0000 (02:07 +0000)
commit2f38caf9391e31be20b717938d51fb2e6b6786a3
tree5bdaab1ee8a60f6afc8ade9c87652774748b829a
parent936b6ee758fefd70457a4901bb4c7bf3ae04e1a0
Alias "system-ui" for the System font name
https://bugs.webkit.org/show_bug.cgi?id=151493

Reviewed by Tim Horton and Joseph Pecoraro.

Source/WebCore:

Updated existing tests.

* WebCore.xcodeproj/project.pbxproj: Add WebKitFontFamilyNames.in for
convenience.
* css/CSSValueKeywords.in: Add system-ui as a keyword.
* css/WebKitFontFamilyNames.in: Add system-ui.

* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::platformFontWithFamilySpecialCase): Include "system-ui" as an
alias.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::platformFontWithFamilySpecialCase): Ditto.

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::updateCachedSystemFontDescription): Update
serialization to "system-ui" from "-apple-system".

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::identifierForFamily):
* css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::familyNameFromPrimitive):
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueFontFamily):

Source/WebInspectorUI:

* UserInterface/Models/CSSKeywordCompletions.js: Ditto.

LayoutTests:

Add "system-ui" to the test.
* fast/css/font-family-builtins.html:
* fast/css/font-family-builtins-expected.txt:
* fast/text/system-font-features.html:
* fast/text/system-font-features-expected.html:
* fast/text/system-font-legacy-name.html:
* fast/text/system-font-legacy-name-expected.txt:
* platform/ios-simulator/ios/fast/text/opticalFont.html:
* platform/ios-simulator/ios/fast/text/opticalFont-expected.txt:
* platform/ios-simulator/ios/fast/text/opticalFontWithTextStyle-expected.txt:

Unskip opticalFont* tests.
* platform/ios-simulator/TestExpectations:

Update tests to use "system-ui" instead of "-apple-system" or the even
older "-apple-system-font".
* fast/css/multiple-tabs-expected.html:
* fast/css/multiple-tabs.html:
* fast/text/international/system-language/han-quotes-expected-mismatch.html:
* fast/text/international/system-language/han-quotes.html:
* fast/text/international/system-language/hindi-system-font-punctuation-expected.html:
* fast/text/international/system-language/hindi-system-font-punctuation.html:
* fast/text/letterpress-different-expected-mismatch.html:
* fast/text/letterpress-different.html:
* fast/text/letterpress-paint.html:
* fast/text/system-font-weight-italic.html:
* fast/text/system-font-weight.html:
* fast/text/text-node-remains-dirty-after-calling-surroundContents-expected.html:
* fast/text/text-node-remains-dirty-after-calling-surroundContents.html:
* fast/text/trak-optimizeLegibility.html:
* fast/text/weighted-italicized-system-font-expected.html:
* fast/text/weighted-italicized-system-font.html:
* platform/ios-simulator/ios/fast/text/apple-logo.html:
* platform/ios-simulator/ios/fast/text/opticalFontWithWeight-expected.txt:
* platform/ios-simulator/ios/fast/text/opticalFontWithWeight.html:
* platform/ios-simulator/ios/fast/text/underline-scaling.html:
* platform/mac/fast/css/css2-system-fonts-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@212985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
44 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/css/font-family-builtins-expected.txt
LayoutTests/fast/css/font-family-builtins.html
LayoutTests/fast/css/multiple-tabs-expected.html
LayoutTests/fast/css/multiple-tabs.html
LayoutTests/fast/text/international/system-language/han-quotes-expected-mismatch.html
LayoutTests/fast/text/international/system-language/han-quotes.html
LayoutTests/fast/text/international/system-language/hindi-system-font-punctuation-expected.html
LayoutTests/fast/text/international/system-language/hindi-system-font-punctuation.html
LayoutTests/fast/text/letterpress-different-expected-mismatch.html
LayoutTests/fast/text/letterpress-different.html
LayoutTests/fast/text/letterpress-paint.html
LayoutTests/fast/text/system-font-features-expected.html
LayoutTests/fast/text/system-font-features.html
LayoutTests/fast/text/system-font-legacy-name-expected.txt
LayoutTests/fast/text/system-font-legacy-name.html
LayoutTests/fast/text/system-font-weight-italic.html
LayoutTests/fast/text/system-font-weight.html
LayoutTests/fast/text/text-node-remains-dirty-after-calling-surroundContents-expected.html
LayoutTests/fast/text/text-node-remains-dirty-after-calling-surroundContents.html
LayoutTests/fast/text/trak-optimizeLegibility.html
LayoutTests/fast/text/weighted-italicized-system-font-expected.html
LayoutTests/fast/text/weighted-italicized-system-font.html
LayoutTests/platform/ios-simulator/TestExpectations
LayoutTests/platform/ios-simulator/ios/fast/text/apple-logo.html
LayoutTests/platform/ios-simulator/ios/fast/text/opticalFont-expected.txt
LayoutTests/platform/ios-simulator/ios/fast/text/opticalFont.html
LayoutTests/platform/ios-simulator/ios/fast/text/opticalFontWithTextStyle-expected.txt
LayoutTests/platform/ios-simulator/ios/fast/text/opticalFontWithWeight-expected.txt
LayoutTests/platform/ios-simulator/ios/fast/text/opticalFontWithWeight.html
LayoutTests/platform/ios-simulator/ios/fast/text/underline-scaling.html
LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/css/CSSComputedStyleDeclaration.cpp
Source/WebCore/css/CSSFontFaceSet.cpp
Source/WebCore/css/CSSValueKeywords.in
Source/WebCore/css/StyleBuilderCustom.h
Source/WebCore/css/WebKitFontFamilyNames.in
Source/WebCore/platform/graphics/ios/FontCacheIOS.mm
Source/WebCore/platform/graphics/mac/FontCacheMac.mm
Source/WebCore/rendering/RenderThemeMac.mm
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js