Tests don't work on some bots: Failed to stop wptwk
authoryouenn.fablet@crf.canon.fr <youenn.fablet@crf.canon.fr@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 21 Feb 2015 20:22:07 +0000 (20:22 +0000)
committeryouenn.fablet@crf.canon.fr <youenn.fablet@crf.canon.fr@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 21 Feb 2015 20:22:07 +0000 (20:22 +0000)
commit2db61c3f35545ae549cc7c2381e047f81affaf41
tree75f38dcf1715c8383d9d328831ff9b37c26a475d
parent1a1db496bc3d5d7f59033da14c54cb882db8d6f7
Tests don't work on some bots: Failed to stop wptwk
https://bugs.webkit.org/show_bug.cgi?id=141235

Reviewed by Ryosuke Niwa.

Tools:

Logging of server subprocesses in launcher script.
Killing of server subprocesses when stopping/before starting.
Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.

* Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
(main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
* Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(WebPlatformTestServer.__init__):
(WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
(WebPlatformTestServer):
(WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
(WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
* Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
(TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
(TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
(TestWebPlatformTestServer):
(TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.

LayoutTests:

* TestExpectations: Marking web-platform-tests as failed or passed until wpt server proves to be stable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/TestExpectations
Tools/ChangeLog
Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py
Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py
Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py