2011-01-10 Eric Seidel <eric@webkit.org>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Jan 2011 11:21:36 +0000 (11:21 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Jan 2011 11:21:36 +0000 (11:21 +0000)
commit2c01041063d163a39d30164d0172ba36503ff3c8
treef99899298f2b0413db0c07934b7388f7763f5fae
parent108f48260f7f6e07626a145957a43ff252f4c272
2011-01-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Commit bot tried to land r? cq+ patch
        https://bugs.webkit.org/show_bug.cgi?id=36638

        It should now be possible to post a patch with r? and cq+ and the
        commit-queue will correctly wait for the r+ before attempting to land the patch.
        (This was a feature requested by several users.)

        One caveat: We don't actually reject r-, cq+ patches from the queue
        (we just ignore them), but I think that's OK for now.

        I also noticed that setting r- once a commit-queue node had grabbed
        a patch would not properly cancel the landing.  That's fixed and
        tested in this patch.

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/feeders.py:
        * Scripts/webkitpy/tool/bot/feeders_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Tools/ChangeLog
Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py
Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
Tools/Scripts/webkitpy/tool/bot/feeders.py
Tools/Scripts/webkitpy/tool/bot/feeders_unittest.py