WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 Jul 2017 00:25:41 +0000 (00:25 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 Jul 2017 00:25:41 +0000 (00:25 +0000)
commit29f6890792ea7705334d0c8bbf7cc767056f1283
tree97a1cb7797872a50c282a639f78cc77149f2fe39
parent736e6996b69711d8ca1c4664a57709c3ccf20350
WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
https://bugs.webkit.org/show_bug.cgi?id=174239

Patch by Ansh Shukla <ansh_shukla@apple.com> on 2017-07-11
Reviewed by Brady Eidson.

Source/WebKit2:

Add a new private header to expose getters for window feature properties already available
in the TFB APIWindowFeatures class. These properties are necessary for Safari to adopt more
modern API.

* UIProcess/API/Cocoa/WKWindowFeatures.mm:
(-[WKWindowFeatures _locationBarVisibility]):
(-[WKWindowFeatures _scrollbarsVisibility]):
(-[WKWindowFeatures _fullscreenDisplay]):
(-[WKWindowFeatures _dialogDisplay]):
* UIProcess/API/Cocoa/WKWindowFeaturesInternal.h: Expose some window features as read-only
properties.
* UIProcess/API/Cocoa/WKWindowFeaturesPrivate.h:
* WebKit2.xcodeproj/project.pbxproj:

Tools:

Create windows with specific features set and make sure those are properly reflected in the
WKWindowFeatures object.

* TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
(resetToConsistentState):
(-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@219378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeatures.mm
Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeaturesInternal.h
Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeaturesPrivate.h [new file with mode: 0644]
Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm