Drop support for cross-origin-window-policy header
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 28 Sep 2018 23:18:28 +0000 (23:18 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 28 Sep 2018 23:18:28 +0000 (23:18 +0000)
commit29747ed70da33b04607181f7ce65cac24e48e511
tree7b874940ae1acb0a021ba0a3046aea8b44a0841d
parentcd8860f2ee86c7176b71e8a399183b2c2f590ee0
Drop support for cross-origin-window-policy header
https://bugs.webkit.org/show_bug.cgi?id=190081

Reviewed by Ryosuke Niwa.

Source/WebCore:

Drop support for cross-origin-window-policy header as this was never enabled and its design has
some issues we have not resolved. An alternative is being worked on but will be substantially
different so there is not much value in keeping this code around.

* bindings/js/JSDOMBindingSecurity.cpp:
* bindings/js/JSDOMBindingSecurity.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::addCrossOriginWindowPropertyNames):
(WebCore::addScopedChildrenIndexes):
(WebCore::addCrossOriginWindowOwnPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
* bindings/js/JSDOMWindowCustom.h:
* bindings/js/JSRemoteDOMWindowCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
(GenerateOperationBodyDefinition):
* bindings/scripts/IDLAttributes.json:
* dom/Document.cpp:
(WebCore::Document::canNavigate):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
* page/AbstractDOMWindow.cpp:
(WebCore::AbstractDOMWindow::AbstractDOMWindow):
* page/AbstractDOMWindow.h:
* page/DOMWindow.idl:
* page/Settings.yaml:
* platform/network/HTTPParsers.cpp:
* platform/network/HTTPParsers.h:

Source/WebKit:

* Shared/WebPreferences.yaml:
* UIProcess/API/C/WKPreferences.cpp:
* UIProcess/API/C/WKPreferencesRef.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::frameBecameRemote):

Source/WebKitLegacy/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::crossOriginWindowPolicySupportEnabled):
(WebPreferences::setCrossOriginWindowPolicySupportEnabled):
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Tools:

190081_DropCrossOriginWindowPolicy

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
* DumpRenderTree/win/DumpRenderTree.cpp:
(enableExperimentalFeatures):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

* http/wpt/cross-origin-window-policy/allow-postmessage-expected.txt: Removed.
* http/wpt/cross-origin-window-policy/allow-postmessage-from-deny-expected.txt: Removed.
* http/wpt/cross-origin-window-policy/allow-postmessage-from-deny.html: Removed.
* http/wpt/cross-origin-window-policy/allow-postmessage-from-deny.html.headers: Removed.
* http/wpt/cross-origin-window-policy/allow-postmessage.html: Removed.
* http/wpt/cross-origin-window-policy/cross-origin-window-policy-header-expected.txt: Removed.
* http/wpt/cross-origin-window-policy/cross-origin-window-policy-header.html: Removed.
* http/wpt/cross-origin-window-policy/navigation-from-opener-via-open-target-expected.txt: Removed.
* http/wpt/cross-origin-window-policy/navigation-from-opener-via-open-target.html: Removed.
* http/wpt/cross-origin-window-policy/navigation-from-subframe-via-anchor-target-expected.txt: Removed.
* http/wpt/cross-origin-window-policy/navigation-from-subframe-via-anchor-target.html: Removed.
* http/wpt/cross-origin-window-policy/resources/cross-origin-window-policy-allow-postmessage-pong.html: Removed.
* http/wpt/cross-origin-window-policy/resources/cross-origin-window-policy-allow-postmessage-pong.html.headers: Removed.
* http/wpt/cross-origin-window-policy/resources/destination.html: Removed.
* http/wpt/cross-origin-window-policy/resources/navigate-parent-via-anchor.html: Removed.
* http/wpt/cross-origin-window-policy/resources/navigation-from-subframe-frame.py: Removed.
* http/wpt/cross-origin-window-policy/resources/serve-cross-origin-window-policy-header.py: Removed.
* http/wpt/cross-origin-window-policy/resources/utils.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
53 files changed:
LayoutTests/ChangeLog
LayoutTests/http/wpt/cross-origin-window-policy/allow-postmessage-expected.txt [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/allow-postmessage-from-deny-expected.txt [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/allow-postmessage-from-deny.html [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/allow-postmessage-from-deny.html.headers [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/allow-postmessage.html [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/cross-origin-window-policy-header-expected.txt [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/cross-origin-window-policy-header.html [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/navigation-from-opener-via-open-target-expected.txt [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/navigation-from-opener-via-open-target.html [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/navigation-from-subframe-via-anchor-target-expected.txt [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/navigation-from-subframe-via-anchor-target.html [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/resources/cross-origin-window-policy-allow-postmessage-pong.html [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/resources/cross-origin-window-policy-allow-postmessage-pong.html.headers [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/resources/destination.html [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/resources/navigate-parent-via-anchor.html [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/resources/navigation-from-subframe-frame.py [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/resources/serve-cross-origin-window-policy-header.py [deleted file]
LayoutTests/http/wpt/cross-origin-window-policy/resources/utils.js [deleted file]
Source/WebCore/ChangeLog
Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp
Source/WebCore/bindings/js/JSDOMBindingSecurity.h
Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
Source/WebCore/bindings/js/JSDOMWindowCustom.h
Source/WebCore/bindings/js/JSRemoteDOMWindowCustom.cpp
Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Source/WebCore/bindings/scripts/IDLAttributes.json
Source/WebCore/dom/Document.cpp
Source/WebCore/loader/FrameLoader.cpp
Source/WebCore/page/AbstractDOMWindow.cpp
Source/WebCore/page/AbstractDOMWindow.h
Source/WebCore/page/DOMWindow.idl
Source/WebCore/page/Settings.yaml
Source/WebCore/platform/network/HTTPParsers.cpp
Source/WebCore/platform/network/HTTPParsers.h
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml
Source/WebKit/UIProcess/API/C/WKPreferences.cpp
Source/WebKit/UIProcess/API/C/WKPreferencesRef.h
Source/WebKit/WebProcess/WebPage/WebPage.cpp
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
Source/WebKitLegacy/mac/WebView/WebPreferences.mm
Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
Source/WebKitLegacy/mac/WebView/WebView.mm
Source/WebKitLegacy/win/ChangeLog
Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h
Source/WebKitLegacy/win/WebPreferences.cpp
Source/WebKitLegacy/win/WebView.cpp
Tools/ChangeLog
Tools/DumpRenderTree/mac/DumpRenderTree.mm
Tools/DumpRenderTree/win/DumpRenderTree.cpp
Tools/WebKitTestRunner/TestController.cpp