Caps lock indicator should not be shown in read-only or disabled field
authordbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Jun 2015 22:35:44 +0000 (22:35 +0000)
committerdbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Jun 2015 22:35:44 +0000 (22:35 +0000)
commit2853dc0140fd1c198d83b52c1126a5f60803e243
treea21d42ce6e3afb75d36d4518c54db907d7753e12
parent50291c67ce4c5079fd8990bb2ea5b5057aac70ad
Caps lock indicator should not be shown in read-only or disabled field
https://bugs.webkit.org/show_bug.cgi?id=145612
<rdar://problem/21227454>

Reviewed by Darin Adler.

.:

* ManualTests/password-caps-lock-should-not-show-in-read-only-field.html: Added.
* ManualTests/password-caps-lock-should-not-show-when-field-becomes-disabled.html: Added.
* ManualTests/password-caps-lock-should-not-show-when-field-becomes-read-only.html: Added.

Source/WebCore:

* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::disabledAttributeChanged): Update caps lock indicator state.
(WebCore::TextFieldInputType::readonlyAttributeChanged): Ditto.
(WebCore::TextFieldInputType::shouldDrawCapsLockIndicator): Do not draw the caps lock indicator
when the field is read-only or disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@185173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ChangeLog
ManualTests/password-caps-lock-should-not-show-in-read-only-field.html [new file with mode: 0644]
ManualTests/password-caps-lock-should-not-show-when-field-becomes-disabled.html [new file with mode: 0644]
ManualTests/password-caps-lock-should-not-show-when-field-becomes-read-only.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/html/TextFieldInputType.cpp