Settings::devicePixelRatio doesn't do anything and is confusing
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 16 Jun 2012 22:35:36 +0000 (22:35 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 16 Jun 2012 22:35:36 +0000 (22:35 +0000)
commit2608c5a1355a123196b2321b83678aaefcc49695
treeb378ef753b84aa11569d9d13b4e7f00fbff112f9
parenta5542298c5986a668152cda639a510019d203fde
Settings::devicePixelRatio doesn't do anything and is confusing
https://bugs.webkit.org/show_bug.cgi?id=89272

Reviewed by James Robinson.

Source/WebCore:

Settings::devicePixelRatio is yet another piece of state trying to
represent the device scale factor. The canonical place to store this
state is Page::m_deviceScaleFactor. Nothing in WebCore references
Settings::devicePixelRatio anymore, so we can remove it.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(Settings):

Source/WebKit2:

* Shared/WebPreferencesStore.h:
(WebKit):
    - Remove boilerplate code for the setting.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::devicePixelRatio):
(QQuickWebViewExperimental::setDevicePixelRatio):
    - Change these functions to get and set the real device scale factor.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
    - Use the real device scale factor for the viewport calculation.
(WebKit::WebPage::updatePreferences):
    - Remove boilerplate code for the setting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/page/Settings.cpp
Source/WebCore/page/Settings.h
Source/WebKit2/ChangeLog
Source/WebKit2/Shared/WebPreferencesStore.h
Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
Source/WebKit2/WebProcess/WebPage/WebPage.cpp