IndexedDB: Remove IDBVersionChangeRequest
authorjsbell@chromium.org <jsbell@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 Jan 2013 22:58:20 +0000 (22:58 +0000)
committerjsbell@chromium.org <jsbell@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 Jan 2013 22:58:20 +0000 (22:58 +0000)
commit259a6e869bba91c5263d8728fd3812b4b0ecf202
tree52b897a03ae92f5990ae073b86678072755c833b
parent465b9d267d49868b9572e4b31b55ca0409fa9161
IndexedDB: Remove IDBVersionChangeRequest
https://bugs.webkit.org/show_bug.cgi?id=107711

Reviewed by Tony Chang.

Source/WebCore:

When the setVersion() API was removed from the Indexed DB spec the IDBVersionChangeRequest
interface was replaced with IDBOpenDBRequest. We switched over for open(), this completes
the work by switching over for deleteDatabase() and removing the old code. (On the Event
side we still need to combine IDBVersionChangeEvent and IDBUpgradeNeededEvent.)

Test: storage/indexeddb/intversion-long-queue.html
      storage/indexeddb/intversion-upgrades.html

* CMakeLists.txt: Remove references to deleted code.
* DerivedSources.make: Ditto.
* GNUmakefile.list.am: Ditto.
* Modules/indexeddb/IDBCallbacks.h: Remove unused onBlocked() overload.
* Modules/indexeddb/IDBDatabase.cpp: Remove references to deleted code.
* Modules/indexeddb/IDBDatabase.h: Ditto.
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::deleteDatabase): Fire onBlocked with current version.
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal): Don't need to specify source.
(WebCore::IDBFactory::deleteDatabase): Use an IDBOpenDBRequest.
* Modules/indexeddb/IDBFactory.h: Change return type of deleteDatabase()
* Modules/indexeddb/IDBFactory.idl: Ditto.
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create): Always use a null source.
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest): Pass null source to base class.
(WebCore::IDBOpenDBRequest::dispatchEvent): Don't assume result is a database in existing
special case.
* Modules/indexeddb/IDBOpenDBRequest.h: Don't need a source argument (always null).
* Modules/indexeddb/IDBVersionChangeRequest.cpp: Removed.
* Modules/indexeddb/IDBVersionChangeRequest.h: Removed.
* Modules/indexeddb/IDBVersionChangeRequest.idl: Removed.
* WebCore.gypi: Remove references to deleted code.
* WebCore.xcodeproj/project.pbxproj: Remove references to deleted code.
* dom/EventTarget.h: Remove references to deleted code.
* dom/EventTargetFactory.in: Ditto.

Source/WebKit/chromium:

* public/WebIDBCallbacks.h: Note to delete onBlocked() once Chromium is cleaned up.
* src/IDBCallbacksProxy.cpp: Remove unused onBlocked() overload.
* src/IDBCallbacksProxy.h: Ditto.
* src/WebIDBCallbacksImpl.cpp: Ditto.
* src/WebIDBCallbacksImpl.h: Ditto.
* tests/IDBAbortOnCorruptTest.cpp: Ditto.
* tests/IDBDatabaseBackendTest.cpp: Ditto.

LayoutTests:

Update expectations - change a handful of FAIL to PASS because past-us were awesome.

* storage/indexeddb/intversion-long-queue-expected.txt:
* storage/indexeddb/intversion-upgrades-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
31 files changed:
LayoutTests/ChangeLog
LayoutTests/storage/indexeddb/intversion-long-queue-expected.txt
LayoutTests/storage/indexeddb/intversion-upgrades-expected.txt
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/WebCore/DerivedSources.make
Source/WebCore/GNUmakefile.list.am
Source/WebCore/Modules/indexeddb/IDBCallbacks.h
Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
Source/WebCore/Modules/indexeddb/IDBDatabase.h
Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp
Source/WebCore/Modules/indexeddb/IDBFactory.cpp
Source/WebCore/Modules/indexeddb/IDBFactory.h
Source/WebCore/Modules/indexeddb/IDBFactory.idl
Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp
Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.h
Source/WebCore/Modules/indexeddb/IDBVersionChangeRequest.cpp [deleted file]
Source/WebCore/Modules/indexeddb/IDBVersionChangeRequest.h [deleted file]
Source/WebCore/Modules/indexeddb/IDBVersionChangeRequest.idl [deleted file]
Source/WebCore/WebCore.gypi
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/dom/EventTarget.h
Source/WebCore/dom/EventTargetFactory.in
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/public/WebIDBCallbacks.h
Source/WebKit/chromium/src/IDBCallbacksProxy.cpp
Source/WebKit/chromium/src/IDBCallbacksProxy.h
Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp
Source/WebKit/chromium/src/WebIDBCallbacksImpl.h
Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp
Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp