WebCore:
authorjustin.garcia@apple.com <justin.garcia@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Feb 2008 21:51:29 +0000 (21:51 +0000)
committerjustin.garcia@apple.com <justin.garcia@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Feb 2008 21:51:29 +0000 (21:51 +0000)
commit23c906f28288431c3dce93d3bdd61a7ec93a9339
treeb3f0bd37b0ac10be9ba2594238d3440c920c72dd
parenta3ca89b6c499c94a850dfbf2e63d1536d9d3ea28
WebCore:

        Reviewed by Alexey Proskuryakov.

        <rdar://problem/5685601> webkit-block-placeholder class on placeholders seems unnecessary (12317)

        * editing/CompositeEditCommand.cpp:
        (WebCore::createBlockPlaceholderElement): The khtml-block-placeholder class was needed
        when the editing code actively looked for <br>s of that type in order to handle them
        specially.  That is no longer the case.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Fixed a bug where an extra block
        would be inserted when hitting return inside an editable root held open by a placeholder
        <br> or '\n'.  Added test cases for the bug and for the special case code that was incorrectly
        triggered to cause the bug.

LayoutTests:

        Reviewed by Alexey Proskuryakov.

        <rdar://problem/5685601> webkit-block-placeholder class on placeholders seems unnecessary (12317)

        * editing/inserting/5685601-1-expected.txt: Added.
        * editing/inserting/5685601-1.html: Added.
        * editing/inserting/5685601-2-expected.txt: Added.
        * editing/inserting/5685601-2.html: Added.
        * editing/inserting/5685601-3-expected.txt: Added.
        * editing/inserting/5685601-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/editing/inserting/5685601-1-expected.txt [new file with mode: 0644]
LayoutTests/editing/inserting/5685601-1.html [new file with mode: 0644]
LayoutTests/editing/inserting/5685601-2-expected.txt [new file with mode: 0644]
LayoutTests/editing/inserting/5685601-2.html [new file with mode: 0644]
LayoutTests/editing/inserting/5685601-3-expected.txt [new file with mode: 0644]
LayoutTests/editing/inserting/5685601-3.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/editing/CompositeEditCommand.cpp
WebCore/editing/InsertParagraphSeparatorCommand.cpp