Reviewed by Sam Weinig.
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 1 Jun 2010 17:48:03 +0000 (17:48 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 1 Jun 2010 17:48:03 +0000 (17:48 +0000)
commit22db112b3ad690705430edfd38dcc1ca6d3ed0b8
treed9812aa25285091860dc3fbec9787cc9561f87f7
parent025ed276f433e55b037a65bd444e947eee6ff75d
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=39434
        REGRESSION (r59811): Geolocation callbacks cannot be created

        * DerivedSources.make: Don't append both WebCore.Geolocation.exp and WebCore.ClientBasedGeolocation.exp,
        they are mutually exclusive.

        * WebCore.Geolocation.exp: Touched to force .exp file rebuild.

        * WebCore.xcodeproj/project.pbxproj: Removed GeolocationService related files.

        * bindings/js/JSGeolocationCustom.cpp:
        (WebCore::createPositionCallback): Functions defined in JavaScript code no longer inherit
        from InternalFunction, they inherit from JSFunction. This check is still imperfect, because
        it's not clear what definition of "function" should really be used, if any - other bindings
        code never checks callback type.
        (WebCore::createPositionErrorCallback): Ditto.

        * page/Geolocation.h: Don't include GeolocationService.h unless it's going to be used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
25 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/dom/Geolocation/script-tests/error.js
LayoutTests/fast/dom/Geolocation/script-tests/maximum-age.js
LayoutTests/fast/dom/Geolocation/script-tests/reentrant-error.js
LayoutTests/fast/dom/Geolocation/script-tests/watch.js
LayoutTests/platform/gtk/Skipped
LayoutTests/platform/mac/Skipped
WebCore/ChangeLog
WebCore/DerivedSources.make
WebCore/WebCore.Geolocation.exp
WebCore/WebCore.xcodeproj/project.pbxproj
WebCore/bindings/js/JSGeolocationCustom.cpp
WebCore/page/Geolocation.h
WebKit/ChangeLog
WebKit/WebKit.xcodeproj/project.pbxproj
WebKit/mac/ChangeLog
WebKit/mac/WebCoreSupport/WebGeolocationMock.mm [deleted file]
WebKit/mac/WebKit.exp
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm
WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm
WebKitTools/DumpRenderTree/mac/MockGeolocationProvider.h [moved from WebKit/mac/WebCoreSupport/WebGeolocationMockPrivate.h with 70% similarity]
WebKitTools/DumpRenderTree/mac/MockGeolocationProvider.mm [new file with mode: 0644]
WebKitTools/DumpRenderTree/mac/UIDelegate.mm