Web Inspector: REGRESSION(r222057): recording state doesn't update when changing...
authorwebkit@devinrousso.com <webkit@devinrousso.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 16 Sep 2017 02:12:17 +0000 (02:12 +0000)
committerwebkit@devinrousso.com <webkit@devinrousso.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 16 Sep 2017 02:12:17 +0000 (02:12 +0000)
commit21e1092f4c32d0188a51c6c2739380ce84e040f3
treede067de04ee4a70d053736804ec204ccd47b197f
parentf60b8c63b8213255ee9e20b2761ede357dfc0b86
Web Inspector: REGRESSION(r222057): recording state doesn't update when changing actions
https://bugs.webkit.org/show_bug.cgi?id=176988

Reviewed by Matt Baker.

Replace `updateActionIndex` with `updateAction`, where the currently selected RecordingAction
is passed to the DetailsSidebarPanel. Also remove the call to `this._recording.actions` in
order to ensure that all logic performed by both DetailsSidebarPanel is synchronous.

* Localizations/en.lproj/localizedStrings.js:

* UserInterface/Views/RecordingTabContentView.js:
(WI.RecordingTabContentView.prototype._updateActionIndex):

* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView.prototype.async._generateContentCanvas2D):
(WI.RecordingContentView.prototype.async._generateContentCanvasWebGL):

* UserInterface/Views/RecordingStateDetailsSidebarPanel.js:
(WI.RecordingStateDetailsSidebarPanel):
(WI.RecordingStateDetailsSidebarPanel.prototype.set recording):
(WI.RecordingStateDetailsSidebarPanel.prototype.updateAction):
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D):
(WI.RecordingStateDetailsSidebarPanel.prototype.updateActionIndex): Deleted.

* UserInterface/Views/RecordingTraceDetailsSidebarPanel.js:
(WI.RecordingTraceDetailsSidebarPanel):
(WI.RecordingTraceDetailsSidebarPanel.prototype.set recording):
(WI.RecordingTraceDetailsSidebarPanel.prototype.updateAction):
(WI.RecordingTraceDetailsSidebarPanel.prototype.updateActionIndex): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js
Source/WebInspectorUI/UserInterface/Views/RecordingStateDetailsSidebarPanel.js
Source/WebInspectorUI/UserInterface/Views/RecordingTabContentView.js
Source/WebInspectorUI/UserInterface/Views/RecordingTraceDetailsSidebarPanel.js