[Web Animations] Crash when setting an animation style on an existing animation that...
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Jul 2018 19:32:10 +0000 (19:32 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Jul 2018 19:32:10 +0000 (19:32 +0000)
commit20f8cd2ef1c388ed20f31aaffb83dbb8c33cf4b7
treece14f82aa7036e467a11eb650d97c66cff18c0a7
parent1eaa9e881203e278c34ad7aa5daa6312e688f6e7
[Web Animations] Crash when setting an animation style on an existing animation that had its effect set to null
https://bugs.webkit.org/show_bug.cgi?id=187953

Reviewed by Dean Jackson.

Source/WebCore:

Test: webanimations/setting-css-animation-timing-property-via-style-after-clearing-effect.html

Ensure that we have a valid effect before proceeding to update its timing.

* animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):

LayoutTests:

Add a new test that sets an animation property via style after setting the initial animation's effect to null.

* webanimations/setting-css-animation-timing-property-via-style-after-clearing-effect-expected.txt: Added.
* webanimations/setting-css-animation-timing-property-via-style-after-clearing-effect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/webanimations/setting-css-animation-timing-property-via-style-after-clearing-effect-expected.txt [new file with mode: 0644]
LayoutTests/webanimations/setting-css-animation-timing-property-via-style-after-clearing-effect.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/animation/CSSAnimation.cpp