Only include "deep color" in layer tree dumps if a tests requests it
authorsimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Oct 2019 04:24:09 +0000 (04:24 +0000)
committersimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Oct 2019 04:24:09 +0000 (04:24 +0000)
commit1f7ab1f6722bb965fab06c24faac86b0792a6a35
tree71d96b2da6844402ec40607754b1f1e9d36907ce
parentef084ac60eb9e793ce5a15232064450037974f59
Only include "deep color" in layer tree dumps if a tests requests it
https://bugs.webkit.org/show_bug.cgi?id=203125

Reviewed by Tim Horton.
Source/WebCore:

Layer tree dumping tests can fail when run on different devices because the "deep color"
property on layers is device-dependent. Stop dumping this by default, and have one test
that sets the bit. iphone-7 is the only device we test that has deep color support.

Tests: compositing/contents-format/deep-color-backing-store.html
       compositing/contents-format/ipad/deep-color-backing-store.html
       compositing/contents-format/iphone-7/deep-color-backing-store.html

* page/Frame.h:
* platform/graphics/GraphicsLayerClient.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
* testing/Internals.cpp:
(WebCore::toLayerTreeFlags):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* TestExpectations:
* compositing/contents-format/deep-color-backing-store-expected.txt: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.
* compositing/contents-format/deep-color-backing-store.html: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html.
* compositing/contents-format/ipad/deep-color-backing-store-expected.txt: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.
* compositing/contents-format/ipad/deep-color-backing-store.html: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html.
* compositing/contents-format/iphone-7/deep-color-backing-store-expected.txt: Copied from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.
* compositing/contents-format/iphone-7/deep-color-backing-store.html: Renamed from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html.
* platform/ipad/TestExpectations:
* platform/iphone-7/TestExpectations: Added.
* platform/mac-wk1/compositing/contents-format/deep-color-backing-store-expected.txt: Renamed from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
19 files changed:
LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/compositing/contents-format/deep-color-backing-store-expected.txt [new file with mode: 0644]
LayoutTests/compositing/contents-format/deep-color-backing-store.html [moved from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html with 94% similarity]
LayoutTests/compositing/contents-format/ipad/deep-color-backing-store-expected.txt [new file with mode: 0644]
LayoutTests/compositing/contents-format/ipad/deep-color-backing-store.html [new file with mode: 0644]
LayoutTests/compositing/contents-format/iphone-7/deep-color-backing-store-expected.txt [moved from LayoutTests/platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt with 100% similarity]
LayoutTests/compositing/contents-format/iphone-7/deep-color-backing-store.html [new file with mode: 0644]
LayoutTests/platform/ipad/TestExpectations
LayoutTests/platform/iphone-7/TestExpectations [new file with mode: 0644]
LayoutTests/platform/mac-wk1/compositing/contents-format/deep-color-backing-store-expected.txt [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/page/Frame.h
Source/WebCore/platform/graphics/GraphicsLayerClient.h
Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
Source/WebCore/rendering/RenderLayerCompositor.cpp
Source/WebCore/testing/Internals.cpp
Source/WebCore/testing/Internals.h
Source/WebCore/testing/Internals.idl