2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>
authorjchaffraix@webkit.org <jchaffraix@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Jun 2011 21:51:17 +0000 (21:51 +0000)
committerjchaffraix@webkit.org <jchaffraix@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Jun 2011 21:51:17 +0000 (21:51 +0000)
commit1eab8325e2d1a494da19d182b737326c4765a226
tree5ee66d8b060fd56c4e7749ef0a7dae18f8de4279
parentc573bbafe63bd83c663385c5bd4a74253c502d73
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Update SVG position values on SVG DOM updates
        https://bugs.webkit.org/show_bug.cgi?id=62439

        * svg/custom/crash-textPath-attributes-expected.txt: Added.
        * svg/custom/crash-textPath-attributes.html: Added.
        * svg/custom/resources/crash-textPath-attributes-iframe.svg: Added.
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Update SVG position values on SVG DOM updates
        https://bugs.webkit.org/show_bug.cgi?id=62439

        Test: svg/custom/crash-textPath-attributes.html

        * rendering/svg/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::destroy): Notify our containing RenderSVGText that it needs
        to update its positioning information.

        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::calculateBoundaries): Check the type of the InlineBox
        like the rest of the code (fixes an ASSERT_NOT_REACHED in InlineBox::calculateBoudaries).

        * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
        (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): Clear
        our cached layout attributes every time we invalidate them. This avoids keeping stale
        attribute that have a backpointer to a RenderObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/svg/custom/crash-textPath-attributes-expected.txt [new file with mode: 0644]
LayoutTests/svg/custom/crash-textPath-attributes.html [new file with mode: 0755]
LayoutTests/svg/custom/resources/crash-textPath-attributes-iframe.svg [new file with mode: 0755]
Source/WebCore/ChangeLog
Source/WebCore/rendering/svg/RenderSVGInline.cpp
Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp
Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp