Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Nov 2014 02:27:49 +0000 (02:27 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Nov 2014 02:27:49 +0000 (02:27 +0000)
commit1e8a431015d4fa1b5a84fbcda579267cae3fd847
treeb72462cbce1d32e0d82e51240a77208eda2f9be7
parent3b037de17c5462b9a70dfc886f9bb2867fa55774
Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
regarding incorrect call to PatchAnalysisTask.report_failure
https://bugs.webkit.org/show_bug.cgi?id=138229

Patch by Jake Nielsen <jacob_nielsen@apple.com> on 2014-11-06
Reviewed by Daniel Bates.

* Scripts/webkitpy/common/net/layouttestresults.py:
Makes sure test_results returns a list.
(LayoutTestResults.test_results):
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
Makes unit tests also check to make sure
task.results_from_patch_test_run() and
task.results_from_test_run_without_patch return instances of
LayoutTestResults.
(CommitQueueTaskTest._run_and_expect_patch_analysis_result):
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
Condenses duplicate code into _should_defer_patch_or_throw, and
removes the now-unused _clean_tree_results member.
(PatchAnalysisTask.__init__):
(PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
(PatchAnalysisTask._should_defer_patch_or_throw):
(PatchAnalysisTask._test_patch):
(PatchAnalysisTask.results_from_patch_test_run):
(PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Removes needless call to results_from_test_run_without_patch
(AbstractEarlyWarningSystem._failing_tests_message):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Changes order of test failure messages to be in the order that they
appear.
(AbstractEarlyWarningSystemTest.test_failing_tests_message):
* Scripts/webkitpy/tool/commands/queues.py:
Removes needless call to results_from_test_run_without_patch.
(CommitQueue._failing_tests_message):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(MockCommitQueueTask.results_from_test_run_without_patch): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@175735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Tools/ChangeLog
Tools/Scripts/webkitpy/common/net/layouttestresults.py
Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py
Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py
Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py
Tools/Scripts/webkitpy/tool/commands/queues.py
Tools/Scripts/webkitpy/tool/commands/queues_unittest.py