Remove forEach use from Fetch Headers builtin constructor
authoryouenn.fablet@crf.canon.fr <youenn.fablet@crf.canon.fr@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 31 Mar 2016 08:31:25 +0000 (08:31 +0000)
committeryouenn.fablet@crf.canon.fr <youenn.fablet@crf.canon.fr@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 31 Mar 2016 08:31:25 +0000 (08:31 +0000)
commit1c2f140b3f1aa8d06c26cb94e895208e00a645b0
tree9fa6e5145a9e5b3bc68d264e6b8e1b9edff97548
parent1c2b1d88ed36908853eacf737207b21a06aff3eb
Remove forEach use from Fetch Headers builtin constructor
https://bugs.webkit.org/show_bug.cgi?id=155967

Reviewed by Joseph Pecoraro.

Source/WebCore:

Tests: fetch/shadowing-forEach.html
       streams/shadowing-Promise.html
       streams/shadowing-defineProperty.html

* Modules/fetch/FetchHeaders.idl: Adding fillFromJS private method.
* Modules/fetch/FetchHeaders.js:
(initializeFetchHeaders): Using fillFromJS private method. Using
instanceof test to check whether parameter is Headers or subclass of it.
* bindings/js/WebCoreBuiltinNames.h: Adding fillFromJS private symbol.

LayoutTests:

Renaming tests covering user scripts breaking some WebCore JS built ins.

* fetch/header-constructor-subclass-expected.txt: Added.
* fetch/header-constructor-subclass.html: Added.
* fetch/shadowing-forEach-expected.txt: Renamed from LayoutTests/streams/builtin-overrides-expected.txt.
* fetch/shadowing-forEach.html: Renamed from LayoutTests/fetch/builtin-overrides.html.
* streams/shadowing-Promise-expected.txt: Renamed from LayoutTests/streams/streams-promises-expected.txt.
* streams/shadowing-Promise.html: Renamed from LayoutTests/streams/streams-promises.html.
* streams/shadowing-defineProperty-expected.txt: Renamed from LayoutTests/fetch/builtin-overrides-expected.txt.
* streams/shadowing-defineProperty.html: Renamed from LayoutTests/streams/builtin-overrides.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@198889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
13 files changed:
LayoutTests/ChangeLog
LayoutTests/fetch/header-constructor-subclass-expected.txt [new file with mode: 0644]
LayoutTests/fetch/header-constructor-subclass.html [new file with mode: 0644]
LayoutTests/fetch/shadowing-forEach-expected.txt [moved from LayoutTests/fetch/builtin-overrides-expected.txt with 100% similarity]
LayoutTests/fetch/shadowing-forEach.html [moved from LayoutTests/fetch/builtin-overrides.html with 81% similarity]
LayoutTests/streams/shadowing-Promise-expected.txt [moved from LayoutTests/streams/streams-promises-expected.txt with 100% similarity]
LayoutTests/streams/shadowing-Promise.html [moved from LayoutTests/streams/streams-promises.html with 100% similarity]
LayoutTests/streams/shadowing-defineProperty-expected.txt [moved from LayoutTests/streams/builtin-overrides-expected.txt with 100% similarity]
LayoutTests/streams/shadowing-defineProperty.html [moved from LayoutTests/streams/builtin-overrides.html with 100% similarity]
Source/WebCore/ChangeLog
Source/WebCore/Modules/fetch/FetchHeaders.idl
Source/WebCore/Modules/fetch/FetchHeaders.js
Source/WebCore/bindings/js/WebCoreBuiltinNames.h