WebBackForwardListItem::setPageState should receive pageState by rvalue reference
authormcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 Jul 2019 20:58:43 +0000 (20:58 +0000)
committermcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 Jul 2019 20:58:43 +0000 (20:58 +0000)
commit1c2e22f8d0b3ef232efc5c1de10339ad85563015
treea0a42a1ecdac0db542cf6280e4f6a83f9a795ad0
parent0d33bbac514a93abcdeb9a634b5cd039fff443b1
WebBackForwardListItem::setPageState should receive pageState by rvalue reference
https://bugs.webkit.org/show_bug.cgi?id=199535

Reviewed by Alex Christensen

Coverity is complaining here about copying PageState by value in the parameter list. It's
sort of a false positive, in that the PageState really does need to be copied here, so this
is the best we can do. But pass by value and then WTFMove() is a pretty strange way to write
it. Passing by rvalue reference would be better. This makes the copy more clear.

* Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::setPageState):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::updateBackForwardItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebBackForwardListItem.h
Source/WebKit/UIProcess/WebProcessProxy.cpp