CSS Transitions and CSS Animations properties should treat unitless 0 as an invalid...
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 28 Oct 2019 17:01:55 +0000 (17:01 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 28 Oct 2019 17:01:55 +0000 (17:01 +0000)
commit1be01b96a55369a7b834d1aa8be69b87055c3055
tree63c3aab9f0e0226551a26b3b07431cb9a96bb3e0
parent48334a98623d5e74c6efab17e316072fae11b479
CSS Transitions and CSS Animations properties should treat unitless 0 as an invalid value for times
https://bugs.webkit.org/show_bug.cgi?id=203484

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Mark WPT progressions.

* web-platform-tests/css/css-animations/parsing/animation-delay-invalid-expected.txt:
* web-platform-tests/css/css-animations/parsing/animation-duration-invalid-expected.txt:
* web-platform-tests/css/css-transitions/parsing/transition-delay-invalid-expected.txt:

Source/WebCore:

The CSS specification does not allow for "0" as a valid time (https://drafts.csswg.org/css-values-3/#time).
We change the way we parse time values to only allow for "0" if the UnitlessQuirk is set to Allow, which is
only the case for the -webkit-marquee-speed property.

* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeTime):

Source/WebInspectorUI:

Use 0s instead of 0 in places where unitless times were used but shouldn't have been.

* UserInterface/Views/FindBanner.css:
(.no-find-banner-transition:matches(.find-banner, .supports-find-banner)):
* UserInterface/Views/TabBar.css:
(.tab-bar > .item > .close):

LayoutTests:

Use 0s instead of 0 in places where unitless times were used but shouldn't have been.

* animations/fill-mode-forwards-zero-duration.html:
* compositing/animation/keyframe-order.html:
* css1/units/zero-duration-without-units.html:
* legacy-animation-engine/animations/fill-mode-forwards-zero-duration.html:
* legacy-animation-engine/compositing/animation/keyframe-order.html:
* legacy-animation-engine/css1/units/zero-duration-without-units.html:
* legacy-animation-engine/transitions/zero-duration-in-list.html:
* legacy-animation-engine/transitions/zero-duration-without-units.html:
* transitions/zero-duration-in-list.html:
* transitions/zero-duration-without-units.html:
* webanimations/css-animations-expected.txt:
* webanimations/css-animations.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
22 files changed:
LayoutTests/ChangeLog
LayoutTests/animations/fill-mode-forwards-zero-duration.html
LayoutTests/compositing/animation/keyframe-order.html
LayoutTests/css1/units/zero-duration-without-units.html
LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-delay-invalid-expected.txt
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-duration-invalid-expected.txt
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/transition-delay-invalid-expected.txt
LayoutTests/legacy-animation-engine/animations/fill-mode-forwards-zero-duration.html
LayoutTests/legacy-animation-engine/compositing/animation/keyframe-order.html
LayoutTests/legacy-animation-engine/css1/units/zero-duration-without-units.html
LayoutTests/legacy-animation-engine/transitions/zero-duration-in-list.html
LayoutTests/legacy-animation-engine/transitions/zero-duration-without-units.html
LayoutTests/transitions/zero-duration-in-list.html
LayoutTests/transitions/zero-duration-without-units.html
LayoutTests/webanimations/css-animations-expected.txt
LayoutTests/webanimations/css-animations.html
Source/WebCore/ChangeLog
Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/FindBanner.css
Source/WebInspectorUI/UserInterface/Views/TabBar.css