The commit-queue can hang when the test_expectations.txt style check fails during...
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Mar 2012 22:48:57 +0000 (22:48 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Mar 2012 22:48:57 +0000 (22:48 +0000)
commit1b4fe768bcf3044dbc16cac2fd199c237d737f29
tree5c92683b011c89998a7aabe3700ea0f3ae5a7100
parent34f4ebc0f3bd4a9414c99d2f6b4afab8dbc15a6f
The commit-queue can hang when the test_expectations.txt style check fails during commit
https://bugs.webkit.org/show_bug.cgi?id=81251

Reviewed by Eric Seidel.

We forgot to check the --non-interactive flag, so we end up prompting
the "user" who doesn't exist on the bot.  We might consider teaching
the User class about non-interactive if we have this sort of bug again.

* Scripts/webkitpy/tool/steps/commit.py:
(Commit.options):
(Commit._check_test_expectations):
(Commit.run):
* Scripts/webkitpy/tool/steps/commit_unittest.py:
(CommitTest.test_check_test_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Tools/ChangeLog
Tools/Scripts/webkitpy/tool/steps/commit.py
Tools/Scripts/webkitpy/tool/steps/commit_unittest.py