[css-grid] Height percentages are not properly resolved for item's children
authorrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Jul 2016 13:02:43 +0000 (13:02 +0000)
committerrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Jul 2016 13:02:43 +0000 (13:02 +0000)
commit191762e5b94d864891ce8388d2f99eaab5c9d9cf
tree90e8a0c5e1491cf14efe1d5418fb11c67828d31a
parent3e364c434033cffab79108c19d4c426ea9ee6732
[css-grid] Height percentages are not properly resolved for item's children
https://bugs.webkit.org/show_bug.cgi?id=159258

Reviewed by Sergio Villar Senin.

Source/WebCore:

When grid items are vertically stretched (default behavior)
they store their height on RenderBox::overrideLogicalContentHeight().
In order to resolve the percentage height on the grid item's children
we need to use that size.

Test: fast/css-grid-layout/percent-resolution-grid-item-children.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):

LayoutTests:

* fast/css-grid-layout/percent-resolution-grid-item-children-expected.txt: Added.
* fast/css-grid-layout/percent-resolution-grid-item-children.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/css-grid-layout/percent-resolution-grid-item-children-expected.txt [new file with mode: 0644]
LayoutTests/fast/css-grid-layout/percent-resolution-grid-item-children.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBox.cpp