WebCore:
authoradele@apple.com <adele@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jan 2008 22:28:49 +0000 (22:28 +0000)
committeradele@apple.com <adele@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jan 2008 22:28:49 +0000 (22:28 +0000)
commit181b6874bdc095b0383fafab99cda27f76a2554a
treeab0ebf9c1ff80d39f9ddbb9034a3c187444af36d
parentcf1c24344e66e3136c306dc8debfb9a957aa44f6
WebCore:

        Reviewed by Sam.

        Fix for <rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

        * css/html4.css: Add horizontal padding to the media slider.
        * rendering/RenderSlider.cpp:
        (WebCore::HTMLSliderThumbElement::defaultEventHandler): Replace use of absoluteBoundingBox() with width() and height()
        (WebCore::RenderSlider::positionForOffset): ditto. Also, use the trackSize() for the maximum offset.
        (WebCore::RenderSlider::layout):  Use contentWidth() and contentHeight() to take padding into account.
        (WebCore::RenderSlider::trackSize): ditto.

LayoutTests:

        Reviewed by Sam.

        Adding new test and updated results for:
        <rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

        * fast/forms/slider-padding.html: Added.
        * platform/mac/fast/forms/slider-padding-expected.checksum: Added.
        * platform/mac/fast/forms/slider-padding-expected.png: Added.
        * platform/mac/fast/forms/slider-padding-expected.txt: Added.
        * platform/mac/media/audio-controls-rendering-expected.checksum:
        * platform/mac/media/audio-controls-rendering-expected.png:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/broken-video-expected.checksum:
        * platform/mac/media/broken-video-expected.png:
        * platform/mac/media/progress-event-expected.checksum:
        * platform/mac/media/progress-event-expected.png:
        * platform/mac/media/unsupported-rtsp-expected.checksum:
        * platform/mac/media/unsupported-rtsp-expected.png:
        * platform/mac/media/unsupported-tracks-expected.checksum:
        * platform/mac/media/unsupported-tracks-expected.png:
        * platform/mac/media/video-append-source-expected.checksum:
        * platform/mac/media/video-append-source-expected.png:
        * platform/mac/media/video-autoplay-expected.checksum:
        * platform/mac/media/video-autoplay-expected.png:
        * platform/mac/media/video-buffered-expected.checksum:
        * platform/mac/media/video-buffered-expected.png:
        * platform/mac/media/video-controls-expected.checksum:
        * platform/mac/media/video-controls-expected.png:
        * platform/mac/media/video-controls-rendering-expected.checksum:
        * platform/mac/media/video-controls-rendering-expected.png:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/media/video-currentTime-set2-expected.checksum:
        * platform/mac/media/video-currentTime-set2-expected.png:
        * platform/mac/media/video-display-toggle-expected.checksum:
        * platform/mac/media/video-display-toggle-expected.png:
        * platform/mac/media/video-display-toggle-expected.txt:
        * platform/mac/media/video-dom-autoplay-expected.checksum:
        * platform/mac/media/video-dom-autoplay-expected.png:
        * platform/mac/media/video-dom-src-expected.checksum:
        * platform/mac/media/video-dom-src-expected.png:
        * platform/mac/media/video-dom-start-expected.checksum:
        * platform/mac/media/video-dom-start-expected.png:
        * platform/mac/media/video-error-abort-expected.checksum:
        * platform/mac/media/video-error-abort-expected.png:
        * platform/mac/media/video-error-does-not-exist-expected.checksum:
        * platform/mac/media/video-error-does-not-exist-expected.png:
        * platform/mac/media/video-load-networkState-expected.checksum:
        * platform/mac/media/video-load-networkState-expected.png:
        * platform/mac/media/video-load-readyState-expected.checksum:
        * platform/mac/media/video-load-readyState-expected.png:
        * platform/mac/media/video-muted-expected.checksum:
        * platform/mac/media/video-muted-expected.png:
        * platform/mac/media/video-no-autoplay-expected.checksum:
        * platform/mac/media/video-no-autoplay-expected.png:
        * platform/mac/media/video-pause-empty-events-expected.checksum:
        * platform/mac/media/video-pause-empty-events-expected.png:
        * platform/mac/media/video-play-empty-events-expected.checksum:
        * platform/mac/media/video-play-empty-events-expected.png:
        * platform/mac/media/video-play-pause-events-expected.checksum:
        * platform/mac/media/video-play-pause-events-expected.png:
        * platform/mac/media/video-play-pause-exception-expected.checksum:
        * platform/mac/media/video-play-pause-exception-expected.png:
        * platform/mac/media/video-seek-past-end-paused-expected.checksum:
        * platform/mac/media/video-seek-past-end-paused-expected.png:
        * platform/mac/media/video-seek-past-end-playing-expected.checksum:
        * platform/mac/media/video-seek-past-end-playing-expected.png:
        * platform/mac/media/video-seekable-expected.checksum:
        * platform/mac/media/video-seekable-expected.png:
        * platform/mac/media/video-seeking-expected.checksum:
        * platform/mac/media/video-seeking-expected.png:
        * platform/mac/media/video-size-expected.checksum:
        * platform/mac/media/video-size-expected.png:
        * platform/mac/media/video-source-expected.checksum:
        * platform/mac/media/video-source-expected.png:
        * platform/mac/media/video-source-media-expected.checksum:
        * platform/mac/media/video-source-media-expected.png:
        * platform/mac/media/video-source-type-expected.checksum:
        * platform/mac/media/video-source-type-expected.png:
        * platform/mac/media/video-src-change-expected.checksum:
        * platform/mac/media/video-src-change-expected.png:
        * platform/mac/media/video-src-expected.checksum:
        * platform/mac/media/video-src-expected.png:
        * platform/mac/media/video-src-remove-expected.checksum:
        * platform/mac/media/video-src-remove-expected.png:
        * platform/mac/media/video-src-set-expected.checksum:
        * platform/mac/media/video-src-set-expected.png:
        * platform/mac/media/video-src-source-expected.checksum:
        * platform/mac/media/video-src-source-expected.png:
        * platform/mac/media/video-start-expected.checksum:
        * platform/mac/media/video-start-expected.png:
        * platform/mac/media/video-volume-expected.checksum:
        * platform/mac/media/video-volume-expected.png:
        * platform/mac/media/video-width-height-expected.checksum:
        * platform/mac/media/video-width-height-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
93 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/forms/slider-padding.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/forms/slider-padding-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/forms/slider-padding-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/forms/slider-padding-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/media/audio-controls-rendering-expected.checksum
LayoutTests/platform/mac/media/audio-controls-rendering-expected.png
LayoutTests/platform/mac/media/audio-controls-rendering-expected.txt
LayoutTests/platform/mac/media/broken-video-expected.checksum
LayoutTests/platform/mac/media/broken-video-expected.png
LayoutTests/platform/mac/media/progress-event-expected.checksum
LayoutTests/platform/mac/media/progress-event-expected.png
LayoutTests/platform/mac/media/unsupported-rtsp-expected.checksum
LayoutTests/platform/mac/media/unsupported-rtsp-expected.png
LayoutTests/platform/mac/media/unsupported-tracks-expected.checksum
LayoutTests/platform/mac/media/unsupported-tracks-expected.png
LayoutTests/platform/mac/media/video-append-source-expected.checksum
LayoutTests/platform/mac/media/video-append-source-expected.png
LayoutTests/platform/mac/media/video-autoplay-expected.checksum
LayoutTests/platform/mac/media/video-autoplay-expected.png
LayoutTests/platform/mac/media/video-buffered-expected.checksum
LayoutTests/platform/mac/media/video-buffered-expected.png
LayoutTests/platform/mac/media/video-controls-expected.checksum
LayoutTests/platform/mac/media/video-controls-expected.png
LayoutTests/platform/mac/media/video-controls-rendering-expected.checksum
LayoutTests/platform/mac/media/video-controls-rendering-expected.png
LayoutTests/platform/mac/media/video-controls-rendering-expected.txt
LayoutTests/platform/mac/media/video-currentTime-set2-expected.checksum
LayoutTests/platform/mac/media/video-currentTime-set2-expected.png
LayoutTests/platform/mac/media/video-display-toggle-expected.checksum
LayoutTests/platform/mac/media/video-display-toggle-expected.png
LayoutTests/platform/mac/media/video-display-toggle-expected.txt
LayoutTests/platform/mac/media/video-dom-autoplay-expected.checksum
LayoutTests/platform/mac/media/video-dom-autoplay-expected.png
LayoutTests/platform/mac/media/video-dom-src-expected.checksum
LayoutTests/platform/mac/media/video-dom-src-expected.png
LayoutTests/platform/mac/media/video-dom-start-expected.checksum
LayoutTests/platform/mac/media/video-dom-start-expected.png
LayoutTests/platform/mac/media/video-error-abort-expected.checksum
LayoutTests/platform/mac/media/video-error-abort-expected.png
LayoutTests/platform/mac/media/video-error-does-not-exist-expected.checksum
LayoutTests/platform/mac/media/video-error-does-not-exist-expected.png
LayoutTests/platform/mac/media/video-load-networkState-expected.checksum
LayoutTests/platform/mac/media/video-load-networkState-expected.png
LayoutTests/platform/mac/media/video-load-readyState-expected.checksum
LayoutTests/platform/mac/media/video-load-readyState-expected.png
LayoutTests/platform/mac/media/video-muted-expected.checksum
LayoutTests/platform/mac/media/video-muted-expected.png
LayoutTests/platform/mac/media/video-no-autoplay-expected.checksum
LayoutTests/platform/mac/media/video-no-autoplay-expected.png
LayoutTests/platform/mac/media/video-pause-empty-events-expected.checksum
LayoutTests/platform/mac/media/video-pause-empty-events-expected.png
LayoutTests/platform/mac/media/video-play-empty-events-expected.checksum
LayoutTests/platform/mac/media/video-play-empty-events-expected.png
LayoutTests/platform/mac/media/video-play-pause-events-expected.checksum
LayoutTests/platform/mac/media/video-play-pause-events-expected.png
LayoutTests/platform/mac/media/video-play-pause-exception-expected.checksum
LayoutTests/platform/mac/media/video-play-pause-exception-expected.png
LayoutTests/platform/mac/media/video-seek-past-end-paused-expected.checksum
LayoutTests/platform/mac/media/video-seek-past-end-paused-expected.png
LayoutTests/platform/mac/media/video-seek-past-end-playing-expected.checksum
LayoutTests/platform/mac/media/video-seek-past-end-playing-expected.png
LayoutTests/platform/mac/media/video-seekable-expected.checksum
LayoutTests/platform/mac/media/video-seekable-expected.png
LayoutTests/platform/mac/media/video-seeking-expected.checksum
LayoutTests/platform/mac/media/video-seeking-expected.png
LayoutTests/platform/mac/media/video-size-expected.checksum
LayoutTests/platform/mac/media/video-size-expected.png
LayoutTests/platform/mac/media/video-source-expected.checksum
LayoutTests/platform/mac/media/video-source-expected.png
LayoutTests/platform/mac/media/video-source-media-expected.checksum
LayoutTests/platform/mac/media/video-source-media-expected.png
LayoutTests/platform/mac/media/video-source-type-expected.checksum
LayoutTests/platform/mac/media/video-source-type-expected.png
LayoutTests/platform/mac/media/video-src-change-expected.checksum
LayoutTests/platform/mac/media/video-src-change-expected.png
LayoutTests/platform/mac/media/video-src-expected.checksum
LayoutTests/platform/mac/media/video-src-expected.png
LayoutTests/platform/mac/media/video-src-remove-expected.checksum
LayoutTests/platform/mac/media/video-src-remove-expected.png
LayoutTests/platform/mac/media/video-src-set-expected.checksum
LayoutTests/platform/mac/media/video-src-set-expected.png
LayoutTests/platform/mac/media/video-src-source-expected.checksum
LayoutTests/platform/mac/media/video-src-source-expected.png
LayoutTests/platform/mac/media/video-start-expected.checksum
LayoutTests/platform/mac/media/video-start-expected.png
LayoutTests/platform/mac/media/video-volume-expected.checksum
LayoutTests/platform/mac/media/video-volume-expected.png
LayoutTests/platform/mac/media/video-width-height-expected.checksum
LayoutTests/platform/mac/media/video-width-height-expected.png
WebCore/ChangeLog
WebCore/css/html4.css
WebCore/rendering/RenderSlider.cpp