LayoutTests:
authorjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Jun 2006 21:22:50 +0000 (21:22 +0000)
committerjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Jun 2006 21:22:50 +0000 (21:22 +0000)
commit1525332bb446e5bbcfc9638626f203fe37017ea8
treebb40064b730fdae5d986a4f682c2a101271b4353
parentb9e174f8036f13e8949fe9f280a4d7c3671db16c
LayoutTests:

        Reviewed by levi

        <rdar://problem/4590366>
        REGRESSION: Selection incorrectly paints gaps on TOT

        Added:
        * editing/selection/line-wrap-1-expected.checksum: Added.
        * editing/selection/line-wrap-1-expected.png: Added.
        * editing/selection/line-wrap-1-expected.txt: Added.
        * editing/selection/line-wrap-1.html: Added.
        * editing/selection/line-wrap-2-expected.checksum: Added.
        * editing/selection/line-wrap-2-expected.png: Added.
        * editing/selection/line-wrap-2-expected.txt: Added.
        * editing/selection/line-wrap-2.html: Added.
        Fixes:
        * editing/execCommand/findString-expected.checksum:
        * editing/execCommand/findString-expected.png:
        * editing/execCommand/findString-expected.txt:
        * editing/inserting/editing-empty-divs-expected.checksum:
        * editing/inserting/editing-empty-divs-expected.png:
        * editing/inserting/editing-empty-divs-expected.txt:
        * editing/inserting/insert-3659587-fix-expected.txt:
        * editing/inserting/insert-tab-002-expected.txt:
        * editing/inserting/insert-text-with-newlines-expected.txt:
        * editing/inserting/typing-001-expected.txt:
        * editing/inserting/typing-003-expected.txt:
        * editing/inserting/typing-around-br-001-expected.txt:
        * editing/style/remove-underline-across-paragraph-expected.txt:
        * editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
        * editing/style/remove-underline-after-paragraph-expected.txt:
        * editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
        * editing/style/remove-underline-expected.txt:
        * editing/style/remove-underline-from-stylesheet-expected.txt:
        * editing/style/remove-underline-in-bold-expected.txt:
        * editing/style/typing-style-002-expected.txt:
        * editing/style/typing-style-003-expected.txt:
        * editing/style/unbold-in-bold-expected.txt:
        * editing/style/underline-expected.txt:
        Disabled (9337):
        * editing/input/attributed-substring-from-range-lines.html

WebCore:

        Reviewed by levi

        <rdar://problem/4590366>
        REGRESSION: Selection incorrectly paints gaps on TOT

        * dom/Document.cpp:
        (WebCore::Document::updateSelection): Use the leftmost candidate for the end of the
        selection and the rightmost candidate for the start of the selection.
        * dom/Position.cpp:
        (WebCore::Position::upstream): Cross line wraps so that we can use upstream/downstream
        to get to candidates before/after linewraps.
        (WebCore::Position::downstream):
        (WebCore::Position::inRenderedContent):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        Ensure that the leftmost candidate is used.  We should sample the style from that one.
        When the block to insert is after a br, a br should be inserted even in strict mode.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input):
        Insert at the leftmost candidate, get rid of a use of trailingWhitespacePosition.
        Don't apply a style if its unnecessary.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): "pos" can be invalidated, don't use it.
        * editing/VisiblePosition.cpp:
        Renamed initDeepPosition and made it return the canonical position.
        (WebCore::VisiblePosition::init):
        (WebCore::VisiblePosition::canonicalPosition):
        * editing/VisiblePosition.h:
        (WebCore::VisiblePosition::characterBefore): Added.
        * editing/visible_units.cpp:
        (WebCore::startOfParagraph):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionState): When a selection ends at a line wrap, it shouldn't extend
        onto the next line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
46 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/execCommand/findString-expected.checksum
LayoutTests/editing/execCommand/findString-expected.png
LayoutTests/editing/execCommand/findString-expected.txt
LayoutTests/editing/input/attributed-substring-from-range-lines-expected.txt
LayoutTests/editing/input/attributed-substring-from-range-lines.html-disabled [moved from LayoutTests/editing/input/attributed-substring-from-range-lines.html with 100% similarity]
LayoutTests/editing/inserting/editing-empty-divs-expected.checksum
LayoutTests/editing/inserting/editing-empty-divs-expected.png
LayoutTests/editing/inserting/editing-empty-divs-expected.txt
LayoutTests/editing/inserting/insert-3659587-fix-expected.txt
LayoutTests/editing/inserting/insert-tab-002-expected.txt
LayoutTests/editing/inserting/insert-text-with-newlines-expected.txt
LayoutTests/editing/inserting/typing-001-expected.txt
LayoutTests/editing/inserting/typing-003-expected.txt
LayoutTests/editing/inserting/typing-around-br-001-expected.txt
LayoutTests/editing/selection/line-wrap-1-expected.checksum [new file with mode: 0644]
LayoutTests/editing/selection/line-wrap-1-expected.png [new file with mode: 0644]
LayoutTests/editing/selection/line-wrap-1-expected.txt [new file with mode: 0644]
LayoutTests/editing/selection/line-wrap-1.html [new file with mode: 0644]
LayoutTests/editing/selection/line-wrap-2-expected.checksum [new file with mode: 0644]
LayoutTests/editing/selection/line-wrap-2-expected.png [new file with mode: 0644]
LayoutTests/editing/selection/line-wrap-2-expected.txt [new file with mode: 0644]
LayoutTests/editing/selection/line-wrap-2.html [new file with mode: 0644]
LayoutTests/editing/style/remove-underline-across-paragraph-expected.txt
LayoutTests/editing/style/remove-underline-across-paragraph-in-bold-expected.txt
LayoutTests/editing/style/remove-underline-after-paragraph-expected.txt
LayoutTests/editing/style/remove-underline-after-paragraph-in-bold-expected.txt
LayoutTests/editing/style/remove-underline-expected.txt
LayoutTests/editing/style/remove-underline-from-stylesheet-expected.txt
LayoutTests/editing/style/remove-underline-in-bold-expected.txt
LayoutTests/editing/style/typing-style-002-expected.txt
LayoutTests/editing/style/typing-style-003-expected.txt
LayoutTests/editing/style/unbold-in-bold-expected.txt
LayoutTests/editing/style/underline-expected.txt
WebCore/ChangeLog
WebCore/WebCore.xcodeproj/project.pbxproj
WebCore/dom/Document.cpp
WebCore/dom/Position.cpp
WebCore/editing/DeleteSelectionCommand.cpp
WebCore/editing/InsertParagraphSeparatorCommand.cpp
WebCore/editing/InsertTextCommand.cpp
WebCore/editing/ReplaceSelectionCommand.cpp
WebCore/editing/VisiblePosition.cpp
WebCore/editing/VisiblePosition.h
WebCore/editing/visible_units.cpp
WebCore/rendering/InlineTextBox.cpp