LayoutTests:
authordarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Jun 2006 04:51:30 +0000 (04:51 +0000)
committerdarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Jun 2006 04:51:30 +0000 (04:51 +0000)
commit138dbc10f65c8fe1e82fdd7b795f4b14b253cda9
treee21987a4c10d0661d02731786a3c615038e96c44
parent24d7804c1240a3de358c251e8a2cab0921280f58
LayoutTests:

        Reviewed by Darin.

        Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9185

        * fast/forms/input-appearance-height-expected.png: Added.
        * fast/forms/input-appearance-height-expected.txt: Added.
        * fast/forms/input-appearance-height.html: Added.
        Tests the height attribute on all input types

        * fast/forms/input-type-change-expected.checksum: Added.
        * fast/forms/input-type-change-expected.png: Added.
        * fast/forms/input-type-change-expected.txt: Added.
        * fast/forms/input-type-change.html: Added.
        Tests changing an input type=TEXT to type=IMAGE with
        a height and width specified on the element.

        * fast/forms/input-type-change2-expected.checksum: Added.
        * fast/forms/input-type-change2-expected.png: Added.
        * fast/forms/input-type-change2-expected.txt: Added.
        * fast/forms/input-type-change2.html: Added.
        Tests changing an input type=IMAGE to type=TEXT with
        a height and width specified on the element.

WebCore:

        Reviewed and tweaked by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9185
        REGRESSION: UserID field appears with an incorrect height
        on americanexpresslogin page
        - Height and Width attribute only applies to IMAGE and HIDDEN
        types.

        * dom/NamedMappedAttrMap.h:
        (WebCore::NamedMappedAttrMap::getAttributeItem):
        Added to static_cast method.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
        Update the style decl if input type has changed.
        (WebCore::HTMLInputElement::mapToEntry):
        Only Cache height and width if it is an IMAGE or HIDDEN
        (WebCore::HTMLInputElement::parseMappedAttribute):
        Check type before adding height and width style.
        (WebCore::HTMLInputElement::attach):
        Remove code for discarding width.

        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::respectHeightAndWidthAttrs):
        New method added to report if this input type uses height & width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
16 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/forms/input-appearance-height-expected.png [new file with mode: 0644]
LayoutTests/fast/forms/input-appearance-height-expected.txt [new file with mode: 0644]
LayoutTests/fast/forms/input-appearance-height.html [new file with mode: 0644]
LayoutTests/fast/forms/input-type-change-expected.checksum [new file with mode: 0644]
LayoutTests/fast/forms/input-type-change-expected.png [new file with mode: 0644]
LayoutTests/fast/forms/input-type-change-expected.txt [new file with mode: 0644]
LayoutTests/fast/forms/input-type-change.html [new file with mode: 0644]
LayoutTests/fast/forms/input-type-change2-expected.checksum [new file with mode: 0644]
LayoutTests/fast/forms/input-type-change2-expected.png [new file with mode: 0644]
LayoutTests/fast/forms/input-type-change2-expected.txt [new file with mode: 0644]
LayoutTests/fast/forms/input-type-change2.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/dom/NamedMappedAttrMap.h
WebCore/html/HTMLInputElement.cpp
WebCore/html/HTMLInputElement.h