Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 27 Nov 2012 21:32:06 +0000 (21:32 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 27 Nov 2012 21:32:06 +0000 (21:32 +0000)
commit13724be293fe0246cfecb644b72b7df4fcceee5a
tree46199379e826f89629adb5b360f2269b1771692e
parentfa9dd82276e5c2b31e0e30a0c9171cf935c6b5bc
Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
https://bugs.webkit.org/show_bug.cgi?id=103408

Reviewed by Dirk Pranke.

Remove the use of the deprecated log and error methods by replacing them with
logging through Python's logging.Logger objects.

This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
updates any affected unit test.

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry._parse_entry):
* Scripts/webkitpy/common/checkout/checkout.py:
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CheckoutTest.test_apply_patch):
* Scripts/webkitpy/common/checkout/deps_mock.py:
(MockDEPS.write_variable):
* Scripts/webkitpy/common/checkout/scm/detection.py:
(SCMDetector.default_scm):
* Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
(SCMDetectorTest.test_detect_scm_system):
* Scripts/webkitpy/common/checkout/scm/git.py:
(Git._check_git_architecture):
(Git._commit_on_branch):
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.ensure_clean_working_directory):
(SCM.ensure_no_local_commits):
(SCM.will.commit_locally_with_message):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.apply_reverse_diff):
* Scripts/webkitpy/common/net/bugzilla/attachment.py:
(Attachment._validate_flag_value):
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._fetch_bug_page):
(Bugzilla.bug_id_for_attachment_id):
(Bugzilla.authenticate):
(Bugzilla._commit_queue_flag):
(Bugzilla.add_attachment_to_bug):
(Bugzilla.add_patch_to_bug):
(Bugzilla.create_bug):
(Bugzilla.clear_attachment_flags):
(Bugzilla.set_flag_on_attachment):
(Bugzilla.obsolete_attachment):
(Bugzilla.add_cc_to_bug):
(Bugzilla.post_comment_to_bug):
(Bugzilla.close_bug_as_fixed):
(Bugzilla.reassign_bug):
(reopen_bug):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzilla.create_bug):
(MockBugzilla.reassign_bug):
(MockBugzilla.set_flag_on_attachment):
(MockBugzilla.post_comment_to_bug):
(MockBugzilla.add_attachment_to_bug):
(MockBugzilla.add_patch_to_bug):
(MockBugzilla.reopen_bug):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_add_cc_to_bug):
(_assert_reopen):
(test_reopen_bug):
* Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
(MockBuilder.force_build):
* Scripts/webkitpy/common/net/credentials.py:
(Credentials._run_security_tool):
* Scripts/webkitpy/common/net/credentials_unittest.py:
(_assert_security_call):
* Scripts/webkitpy/common/net/irc/irc_mock.py:
(MockIRC.post):
(MockIRC.disconnect):
* Scripts/webkitpy/common/net/irc/ircproxy.py:
(IRCProxy.__init__):
(IRCProxy.disconnect):
* Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
(IRCProxyTest.test_trivial):
* Scripts/webkitpy/common/net/layouttestresults.py:
(ORWTResultsHTMLParser._failures_from_fail_row):
* Scripts/webkitpy/common/net/layouttestresults_unittest.py:
(test_failures_from_fail_row):
* Scripts/webkitpy/common/net/networktransaction.py:
* Scripts/webkitpy/common/net/resultsjsonparser.py:
(JSONTestResult._tokenize):
(JSONTestResult._failure_types_from_actual_result):
* Scripts/webkitpy/common/net/statusserver.py:
(StatusServer.update_status):
(StatusServer.update_svn_revision):
* Scripts/webkitpy/common/net/statusserver_mock.py:
(MockStatusServer.release_work_item):
(MockStatusServer.update_work_items):
(MockStatusServer.submit_to_ews):
(MockStatusServer.update_status):
* Scripts/webkitpy/common/net/unittestresults.py:
(UnitTestResults.results_from_string):
* Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.running_pids):
(MockExecutive.run_and_throw_if_fail):
(MockExecutive.run_command):
(MockExecutive.popen):
* Scripts/webkitpy/common/system/user_mock.py:
(MockUser.confirm):
(MockUser.open_url):
* Scripts/webkitpy/common/system/workspace_unittest.py:
(WorkspaceTest.test_create_zip):
(WorkspaceTest.test_create_zip_exception):
* Scripts/webkitpy/common/watchlist/watchlist_mock.py:
(MockWatchList.determine_cc_and_messages):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
* Scripts/webkitpy/layout_tests/port/efl_unittest.py:
(EflPortTest.test_show_results_html_file):
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest.test_show_results_html_file):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_show_results_html_file):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(test_build_driver):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_show_results_html_file):
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest.test_show_results_html_file):
* Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
(XvfbDriverTest.assertDriverStartSuccessful):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_start_next_worker):
(XvfbDriverTest.test_stop):
* Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
(TestLayoutTestApacheHttpd.test_start_cmd):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_pause_before_testing):
(test_run_memory_test):
(_test_run_with_json_output):
(test_run_respects_no_results):
(test_run_generates_and_show_results_page):
(test_run_respects_no_show_results):
* Scripts/webkitpy/tool/bot/feeders_unittest.py:
(FeedersTest.test_commit_queue_feeder):
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
(FlakyTestReporterTest.test_create_bug_for_flaky_test):
(test_report_flaky_tests_creating_bug):
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_rollout_updates_working_copy):
* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_exception_during_command):
(IRCBotTest.test_hi):
(IRCBotTest.test_help):
(IRCBotTest.test_restart):
(IRCBotTest.test_rollout):
(IRCBotTest.test_revert):
(IRCBotTest.test_roll_chromium_deps):
(IRCBotTest.test_roll_chromium_deps_to_lkgr):
(IRCBotTest.test_multi_rollout):
(IRCBotTest.test_rollout_with_r_in_svn_revision):
(IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
(IRCBotTest.test_rollout_bananas):
(IRCBotTest.test_rollout_invalidate_revision):
(IRCBotTest.test_rollout_invalidate_reason):
(test_multi_rollout_invalidate_reason):
(test_rollout_no_reason):
(test_multi_rollout_no_reason):
* Scripts/webkitpy/tool/bot/sheriff_unittest.py:
(SheriffTest.test_post_blame_comment_on_bug):
* Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
(ApplyWatchListLocalTest.test_args_parsing):
(test_args_parsing_with_bug):
* Scripts/webkitpy/tool/commands/download_unittest.py:
(test_land_cowboy):
(test_check_style):
(test_create_rollout):
(test_create_rollout_resolved):
(test_rollout):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(AbstractEarlyWarningSystemTest.test_failing_tests_message):
(EarlyWarningSytemTest._default_expected_logs):
(EarlyWarningSytemTest._test_builder_ews):
(EarlyWarningSytemTest._test_testing_ews):
* Scripts/webkitpy/tool/commands/openbugs_unittest.py:
(OpenBugsTest.test_args_parsing):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(QueryCommandsTest.test_bugs_to_commit):
(QueryCommandsTest.test_patches_in_commit_queue):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(FeederQueueTest.test_feeder_queue):
(AbstractPatchQueueTest.test_next_patch):
(AbstractPatchQueueTest.test_upload_results_archive_for_patch):
(CommitQueueTest.test_commit_queue):
(test_commit_queue_failure):
(test_commit_queue_failure_with_failing_tests):
(test_rollout):
(test_rollout_lands):
(test_auto_retry):
(test_manual_reject_during_processing):
(test_report_flaky_tests):
(StyleQueueTest.test_style_queue_with_style_exception):
(test_style_queue_with_watch_list_exception):
* Scripts/webkitpy/tool/commands/queuestest.py:
(QueuesTest._default_begin_work_queue_logs):
* Scripts/webkitpy/tool/commands/roll_unittest.py:
(RollCommandsTest.test_update_chromium_deps):
* Scripts/webkitpy/tool/commands/upload_unittest.py:
(UploadCommandsTest.test_assign_to_committer):
(test_post):
(test_attach_to_bug):
(test_attach_to_bug_no_description_or_comment):
(test_land_safely):
(test_prepare):
(test_upload):
(test_mark_bug_fixed):
* Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
(ApplyWatchListTest.test_apply_watch_list_local):
* Scripts/webkitpy/tool/steps/commit_unittest.py:
(CommitTest._test_check_test_expectations):
* Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):
* Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest._assert_step_output_with_bug):
(StepsTest._assert_post_diff_output_for_bug):
(StepsTest.test_post_diff):
(StepsTest.test_post_diff_for_commit):
(StepsTest.test_ensure_bug_is_open_and_assigned):
(StepsTest.test_runtests_args):
* Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
(SuggestReviewersTest.test_basic):
* Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
(ValidateChangeLogsTest._assert_start_line_produces_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
61 files changed:
Tools/ChangeLog
Tools/Scripts/webkitpy/common/checkout/changelog.py
Tools/Scripts/webkitpy/common/checkout/checkout.py
Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py
Tools/Scripts/webkitpy/common/checkout/deps_mock.py
Tools/Scripts/webkitpy/common/checkout/scm/detection.py
Tools/Scripts/webkitpy/common/checkout/scm/detection_unittest.py
Tools/Scripts/webkitpy/common/checkout/scm/git.py
Tools/Scripts/webkitpy/common/checkout/scm/scm.py
Tools/Scripts/webkitpy/common/checkout/scm/svn.py
Tools/Scripts/webkitpy/common/net/bugzilla/attachment.py
Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py
Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py
Tools/Scripts/webkitpy/common/net/buildbot/buildbot_mock.py
Tools/Scripts/webkitpy/common/net/credentials.py
Tools/Scripts/webkitpy/common/net/credentials_unittest.py
Tools/Scripts/webkitpy/common/net/irc/irc_mock.py
Tools/Scripts/webkitpy/common/net/irc/ircproxy.py
Tools/Scripts/webkitpy/common/net/irc/ircproxy_unittest.py
Tools/Scripts/webkitpy/common/net/layouttestresults.py
Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py
Tools/Scripts/webkitpy/common/net/networktransaction.py
Tools/Scripts/webkitpy/common/net/resultsjsonparser.py
Tools/Scripts/webkitpy/common/net/statusserver.py
Tools/Scripts/webkitpy/common/net/statusserver_mock.py
Tools/Scripts/webkitpy/common/net/unittestresults.py
Tools/Scripts/webkitpy/common/system/executive_mock.py
Tools/Scripts/webkitpy/common/system/user_mock.py
Tools/Scripts/webkitpy/common/system/workspace_unittest.py
Tools/Scripts/webkitpy/common/watchlist/watchlist_mock.py
Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/efl_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py
Tools/Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py
Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py
Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py
Tools/Scripts/webkitpy/tool/bot/feeders_unittest.py
Tools/Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py
Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py
Tools/Scripts/webkitpy/tool/bot/ircbot_unittest.py
Tools/Scripts/webkitpy/tool/bot/sheriff_unittest.py
Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py
Tools/Scripts/webkitpy/tool/commands/download_unittest.py
Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py
Tools/Scripts/webkitpy/tool/commands/openbugs_unittest.py
Tools/Scripts/webkitpy/tool/commands/queries_unittest.py
Tools/Scripts/webkitpy/tool/commands/queues_unittest.py
Tools/Scripts/webkitpy/tool/commands/queuestest.py
Tools/Scripts/webkitpy/tool/commands/roll_unittest.py
Tools/Scripts/webkitpy/tool/commands/upload_unittest.py
Tools/Scripts/webkitpy/tool/steps/applywatchlist_unittest.py
Tools/Scripts/webkitpy/tool/steps/commit_unittest.py
Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py
Tools/Scripts/webkitpy/tool/steps/steps_unittest.py
Tools/Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py
Tools/Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py