Remove Reflect.enumerate
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 24 Jun 2017 08:06:47 +0000 (08:06 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 24 Jun 2017 08:06:47 +0000 (08:06 +0000)
commit130aadbafa7133c0b9abd394420cb5fde32b6301
treea2e24d5cff4d3769bec822263f3f52cc0b6e7fd8
parentd7542946a8cf0f3a6ae4369d97d6a3ea8e7ec76b
Remove Reflect.enumerate
https://bugs.webkit.org/show_bug.cgi?id=173806

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-06-24
Reviewed by Yusuke Suzuki.

JSTests:

* ChakraCore.yaml:
* es6.yaml:
These tests now fail because they use Reflect.enumerate.

* test262.yaml:
This test now passes, it checked that Reflect.enumerate is undefined!

* stress/property-name-enumerator-should-not-look-into-indexed-values-when-it-is-a-dictionary.js:
Convert to for..in which presented the original issue. See bug <https://webkit.org/b/149811>

* stress/reflect-enumerate.js: Removed.
Remove a test solely for Reflect.enumerate.

Source/JavaScriptCore:

* CMakeLists.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties):
(Inspector::JSInjectedScriptHost::iteratorEntries):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSPropertyNameIterator.cpp: Removed.
* runtime/JSPropertyNameIterator.h: Removed.
* runtime/ReflectObject.cpp:
(JSC::reflectObjectEnumerate): Deleted.

Source/WebInspectorUI:

* UserInterface/Models/NativeFunctionParameters.js:

Tools:

* Scripts/run-jsc-stress-tests:

LayoutTests:

* inspector/model/remote-object-expected.txt:
* inspector/model/remote-object.html:
* platform/mac/inspector/model/remote-object-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@218784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
22 files changed:
JSTests/ChakraCore.yaml
JSTests/ChangeLog
JSTests/es6.yaml
JSTests/stress/property-name-enumerator-should-not-look-into-indexed-values-when-it-is-a-dictionary.js
JSTests/stress/reflect-enumerate.js [deleted file]
JSTests/test262.yaml
LayoutTests/ChangeLog
LayoutTests/inspector/model/remote-object-expected.txt
LayoutTests/inspector/model/remote-object.html
LayoutTests/platform/mac/inspector/model/remote-object-expected.txt
Source/JavaScriptCore/CMakeLists.txt
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp
Source/JavaScriptCore/runtime/JSGlobalObject.cpp
Source/JavaScriptCore/runtime/JSPropertyNameIterator.cpp [deleted file]
Source/JavaScriptCore/runtime/JSPropertyNameIterator.h [deleted file]
Source/JavaScriptCore/runtime/ReflectObject.cpp
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js
Tools/ChangeLog
Tools/Scripts/run-jsc-stress-tests