Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 15 Jun 2012 02:04:43 +0000 (02:04 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 15 Jun 2012 02:04:43 +0000 (02:04 +0000)
commit0e25b9baadff1827a84ec6d46c77802075dd3643
tree2a78007623c2429cbcda04368c190c71427ff355
parent6c64197615937223c1090c82a3673cfffc092b6e
Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms.
https://bugs.webkit.org/show_bug.cgi?id=89129

Source/WebCore:

As titled, click-to-pause and double-click-to-play behavior are unwanted on Chromium.  A
long standing issue (~3 years) has been to disable this feature.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

Uses existing click/double-click test.

* html/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):

LayoutTests:

Fixes layout test to actually test what it says it tests.  Previously it was
testing the opposite behavior and passing because MediaDocument auto-plays.

Additionally failing one half of the test would still allow you to pass the
other half.  Both issues have been fixed.

Updates the test expectations for Chromium to reflect a failure.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

* media/video-click-dblckick-standalone-expected.txt:
* media/video-click-dblckick-standalone.html:
* platform/chromium/media/video-click-dblckick-standalone-expected.txt: Copied from LayoutTests/media/video-click-dblckick-standalone-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/media/video-click-dblckick-standalone-expected.txt
LayoutTests/media/video-click-dblckick-standalone.html
LayoutTests/platform/chromium/media/video-click-dblckick-standalone-expected.txt [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/html/MediaDocument.cpp