[iOS] Fast and complex text codepaths disagree about how to lay out bopomofo with...
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 21 Jul 2019 17:23:54 +0000 (17:23 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 21 Jul 2019 17:23:54 +0000 (17:23 +0000)
commit0dc91efbce89742dc142108f74013846f0690345
tree1457521c3a3aa3c4cdac677dc6a558b52265af97
parent8ce87fedfe6b3fcf9d07ccd47af38a7a6c63051e
[iOS] Fast and complex text codepaths disagree about how to lay out bopomofo with tone marks
https://bugs.webkit.org/show_bug.cgi?id=199912
<rdar://problem/52182454>

Reviewed by Simon Fraser.

Source/WebCore:

This is because CoreText has special composition rules for CJK languages, which we don't have in our simple
text codepath. Rather than implementing the composition rules in WebKit, we can simply disable them in
CoreText.

Test: fast/text/international/system-language/composition.html

* platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::Font::getCFStringAttributes const):

Source/WebCore/PAL:

* pal/spi/cocoa/CoreTextSPI.h:

LayoutTests:

* css3/font-feature-font-face-local-expected.html:
* css3/font-feature-font-face-local.html:
* editing/mac/selection/word-thai-expected.txt:
* editing/mac/selection/word-thai.html:
* fast/text/international/system-language/composition-expected.txt: Added.
* fast/text/international/system-language/composition.html: Added.
* platform/ios/fast/text/crash-complex-text-surrogate-expected.txt:
* svg/custom/glyph-selection-arabic-forms-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
14 files changed:
LayoutTests/ChangeLog
LayoutTests/css3/font-feature-font-face-local-expected.html
LayoutTests/css3/font-feature-font-face-local.html
LayoutTests/editing/mac/selection/word-thai-expected.txt
LayoutTests/editing/mac/selection/word-thai.html
LayoutTests/fast/text/international/system-language/composition-expected.txt [new file with mode: 0644]
LayoutTests/fast/text/international/system-language/composition.html [new file with mode: 0644]
LayoutTests/platform/ios/fast/text/crash-complex-text-surrogate-expected.txt
LayoutTests/platform/ios/legacy-animation-engine/fast/text/crash-complex-text-surrogate-expected.txt
LayoutTests/svg/custom/glyph-selection-arabic-forms-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/PAL/ChangeLog
Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h
Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp