table's text aligned on top instead of center because of rowspan
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 23 Apr 2013 06:36:45 +0000 (06:36 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 23 Apr 2013 06:36:45 +0000 (06:36 +0000)
commit0bc407744dd9c209e61a0f9838e5a4a0a0d6d606
tree0c11d857019267935b5f85f2e3b3a6da40fa9043
parentc8b618ef059de5cbe915c2cca23310b38f63e02d
table's text aligned on top instead of center because of rowspan
https://bugs.webkit.org/show_bug.cgi?id=18092

Patch by Suchit Agrawal <a.suchit@samsung.com> on 2013-04-22
Reviewed by Beth Dakin.

Source/WebCore:

Last row in the rowspan is not getting the height of rowspan cell because there is not
enough rows present below rowspan cell and we are strictly applying height of rowspan
to the row which should lay last in the rowspan based of rowspan value.

When row contains rowspan cell and it is last row of the table then
rowspan height is adding to last row of the table.

Test: fast/table/Rowspan-value-more-than-number-of-rows-present.html

It calculates logical height of the rows in the table.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Added test cases, based on rowspan issue.
* fast/table/Rowspan-value-more-than-number-of-rows-present-expected.txt: Added.
* fast/table/Rowspan-value-more-than-number-of-rows-present.html: Added.

Test cases need to do rebaseline in efl, gtk and mac platforms.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

Test case results are updated in qt platform.
* platform/qt/fast/table/giantRowspan-expected.png:
* platform/qt/fast/table/giantRowspan-expected.txt:
* platform/qt/fast/table/giantRowspan2-expected.png:
* platform/qt/fast/table/giantRowspan2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug133756-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug133756-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug133756-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug133756-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug220536-expected.png:
* platform/qt/tables/mozilla/bugs/bug220536-expected.txt:
* platform/qt/tables/mozilla/bugs/bug8858-expected.txt:
* platform/qt/tables/mozilla/core/bloomberg-expected.png:
* platform/qt/tables/mozilla/core/bloomberg-expected.txt:
* platform/qt/tables/mozilla/core/row_span-expected.png:
* platform/qt/tables/mozilla/core/row_span-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
* tables/mozilla/core/bloomberg-expected.txt:
* tables/mozilla/core/row_span-expected.txt:
* tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
* tables/mozilla_expected_failures/bugs/bug23847-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
31 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/table/Rowspan-value-more-than-number-of-rows-present-expected.txt [new file with mode: 0644]
LayoutTests/fast/table/Rowspan-value-more-than-number-of-rows-present.html [new file with mode: 0644]
LayoutTests/platform/efl/TestExpectations
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/mac/TestExpectations
LayoutTests/platform/qt/fast/table/giantRowspan-expected.png
LayoutTests/platform/qt/fast/table/giantRowspan-expected.txt
LayoutTests/platform/qt/fast/table/giantRowspan2-expected.png
LayoutTests/platform/qt/fast/table/giantRowspan2-expected.txt
LayoutTests/platform/qt/tables/mozilla/bugs/bug133756-1-expected.png
LayoutTests/platform/qt/tables/mozilla/bugs/bug133756-1-expected.txt
LayoutTests/platform/qt/tables/mozilla/bugs/bug133756-2-expected.png
LayoutTests/platform/qt/tables/mozilla/bugs/bug133756-2-expected.txt
LayoutTests/platform/qt/tables/mozilla/bugs/bug220536-expected.png
LayoutTests/platform/qt/tables/mozilla/bugs/bug220536-expected.txt
LayoutTests/platform/qt/tables/mozilla/bugs/bug8858-expected.txt
LayoutTests/platform/qt/tables/mozilla/core/bloomberg-expected.png
LayoutTests/platform/qt/tables/mozilla/core/bloomberg-expected.txt
LayoutTests/platform/qt/tables/mozilla/core/row_span-expected.png
LayoutTests/platform/qt/tables/mozilla/core/row_span-expected.txt
LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt
LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png
LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug65372-expected.png
LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug65372-expected.txt
LayoutTests/tables/mozilla/core/bloomberg-expected.txt
LayoutTests/tables/mozilla/core/row_span-expected.txt
LayoutTests/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt
LayoutTests/tables/mozilla_expected_failures/bugs/bug23847-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderTableSection.cpp