2010-11-24 Eric Uhrhane <ericu@chromium.org>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 25 Nov 2010 02:44:12 +0000 (02:44 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 25 Nov 2010 02:44:12 +0000 (02:44 +0000)
commit0a1113ce2056421d635daa3db8f565c08e124b3f
tree54abafb88e4676c0094ce92247d679207dac457b
parente1ea58c862ff19e80912888927c4e0f5cc2b5f75
2010-11-24  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        Implement FileWriterSync
        https://bugs.webkit.org/show_bug.cgi?id=49939

        Tests to follow in a separate CL, once the test framework in 47680 goes in.

        Build file changes to add FileWriterBase and FileWriterBaseCallback.
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:

        FileWriterSync doesn't turn out to need to be an ActiveDOMObject.
        * bindings/scripts/CodeGeneratorV8.pm:

        Added new AsyncFileWriter::waitForOperationToComplete to enable
        synchronous calls.
        * fileapi/AsyncFileWriter.h:

        Added a way to get a FileSystemSync.
        * fileapi/DOMFileSystemSync.cpp:
        * fileapi/FileEntrySync.cpp:
        * fileapi/FileEntrySync.h:
        * fileapi/FileEntrySync.idl:

        Added an error code for OK, rather than just having 0 everywhere.
        * fileapi/FileError.h:

        Turned FileWriterCallback into FileWriterBaseCallback.
        * fileapi/FileSystemCallbacks.cpp:
        * fileapi/FileSystemCallbacks.h:

        Refactored out a common base class, FileWriterBase, for FileWriter and
        FileWriterSync.
        * fileapi/FileWriter.cpp:
        * fileapi/FileWriter.h:
        * fileapi/FileWriterBase.cpp: Added.
        * fileapi/FileWriterBase.h: Added.
        * fileapi/FileWriterBaseCallback.h: Added.
        * fileapi/FileWriterSync.cpp:
        * fileapi/FileWriterSync.h:

        Small tweaks to deal with the base class refactoring.
        * fileapi/DOMFileSystem.cpp:
        * fileapi/DOMFileSystemSync.h:

        Removed "CallWith=ScriptExecutionContext", as FileWriterSync doesn't actually need it.
        * fileapi/FileWriterSync.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
26 files changed:
WebCore/CMakeLists.txt
WebCore/ChangeLog
WebCore/GNUmakefile.am
WebCore/WebCore.gypi
WebCore/WebCore.pro
WebCore/WebCore.vcproj/WebCore.vcproj
WebCore/WebCore.xcodeproj/project.pbxproj
WebCore/bindings/scripts/CodeGeneratorV8.pm
WebCore/fileapi/AsyncFileWriter.h
WebCore/fileapi/DOMFileSystem.cpp
WebCore/fileapi/DOMFileSystemSync.cpp
WebCore/fileapi/DOMFileSystemSync.h
WebCore/fileapi/FileEntrySync.cpp
WebCore/fileapi/FileEntrySync.h
WebCore/fileapi/FileEntrySync.idl
WebCore/fileapi/FileError.h
WebCore/fileapi/FileSystemCallbacks.cpp
WebCore/fileapi/FileSystemCallbacks.h
WebCore/fileapi/FileWriter.cpp
WebCore/fileapi/FileWriter.h
WebCore/fileapi/FileWriterBase.cpp [new file with mode: 0644]
WebCore/fileapi/FileWriterBase.h [new file with mode: 0644]
WebCore/fileapi/FileWriterBaseCallback.h [new file with mode: 0644]
WebCore/fileapi/FileWriterSync.cpp
WebCore/fileapi/FileWriterSync.h
WebCore/fileapi/FileWriterSync.idl