WebCore:
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 26 Apr 2008 16:41:23 +0000 (16:41 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 26 Apr 2008 16:41:23 +0000 (16:41 +0000)
commit0901c4632a244914fa8cc0a3d13160e0c3e81322
treef5af2393255e8ae9ec2e5c28e76a0df673843263
parent7cd669f8f966e765023d55bf16ae5762a2ddb0d0
WebCore:

2008-04-26  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18583
        WebKit should ignore declarations with a negative value for
        line-height and font-size, including in the shorthand font form.

        Tests: fast/css/font-size-negative.html
               fast/css/line-height-negative.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFont):

LayoutTests:

2008-04-26  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dave Hyatt.

        Test for https://bugs.webkit.org/show_bug.cgi?id=18583
        Negative values are invalid for font-size and line-height,
        including in the shorthand "font".

        * fast/css/font-size-negative.html: Added.
        * fast/css/line-height-negative.html: Added.
        * platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum:
        * platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png:
        * platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.txt:
        * platform/mac/fast/css/font-size-negative-expected.checksum: Added.
        * platform/mac/fast/css/font-size-negative-expected.png: Added.
        * platform/mac/fast/css/font-size-negative-expected.txt: Added.
        * platform/mac/fast/css/line-height-negative-expected.checksum: Added.
        * platform/mac/fast/css/line-height-negative-expected.png: Added.
        * platform/mac/fast/css/line-height-negative-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
14 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/css/font-size-negative.html [new file with mode: 0644]
LayoutTests/fast/css/line-height-negative.html [new file with mode: 0644]
LayoutTests/platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum
LayoutTests/platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png
LayoutTests/platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.txt
LayoutTests/platform/mac/fast/css/font-size-negative-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/css/font-size-negative-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/css/font-size-negative-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/fast/css/line-height-negative-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/css/line-height-negative-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/css/line-height-negative-expected.txt [new file with mode: 0644]
WebCore/ChangeLog
WebCore/css/CSSParser.cpp