WebCore:
authorsullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 29 Jul 2005 21:16:56 +0000 (21:16 +0000)
committersullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 29 Jul 2005 21:16:56 +0000 (21:16 +0000)
commit075ffe77a8d6bcc2259889be6b2a624968cacd2b
treee3a645a2b156228791afdc67cac020bee6e43f2c
parent1135282d076de14c926fee7839be1cef8d088cb2
WebCore:

        Reviewed by Dave Hyatt.

        Test cases added: none, this only affects Safari forms autofill

        - WebCore part of <rdar://problem/4187404> Redo form SPI so that it doesn't rely on NSViews

        * khtml/html/html_formimpl.cpp:
        added a FIXME about a bug I ran into while doing this autofill stuff

        * kwq/DOMHTML.mm:
        (viewForElement):
        Moved this function here (was in WebCoreBridge), and simplified it a little. This will go
        away when we have non-NSView ways of implementing all the methods below.
        (-[DOMHTMLInputElement _displayedValue]):
        moved here from Safari
        (-[DOMHTMLInputElement _setDisplayedValue:]):
        ditto
        (-[DOMHTMLInputElement _rectOnScreen]):
        ditto
        (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
        ditto
        (-[DOMHTMLInputElement _selectedRange]):
        ditto
        (-[DOMHTMLInputElement _setBackgroundColor:]):
        ditto
        (-[DOMHTMLSelectElement _activateItemAtIndex:]):
        ditto
        (-[DOMHTMLSelectElement _optionLabels]):
        ditto

        * kwq/DOMPrivate.h:
        moved DOMHTMLInputElement and DOMHTMLSelectElement categories here from Safari

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        removed viewForElement:, which had been added as a temporary measure while I did this conversion.

WebKit:

        Reviewed by Dave Hyatt.

        - WebKit part of <rdar://problem/4187404> Redo form SPI so that it doesn't rely on NSViews

        Much of 4187404 was addressed in earlier checkins. This checkin completes the task.

        * WebView.subproj/WebHTMLRepresentation.h:
        * WebView.subproj/WebHTMLRepresentation.m:
        removed viewForElement:, which was the only remaining NSView-related SPI that Safari autofill was
        still using. I added viewForElement a week ago as a transitional measure, so removing it won't
        affect any other clients.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore/ChangeLog-2005-08-23
WebCore/khtml/html/html_formimpl.cpp
WebCore/kwq/DOMHTML.mm
WebCore/kwq/DOMPrivate.h
WebCore/kwq/WebCoreBridge.h
WebCore/kwq/WebCoreBridge.mm
WebKit/ChangeLog
WebKit/WebView.subproj/WebHTMLRepresentation.h
WebKit/WebView.subproj/WebHTMLRepresentation.m