[chromium] Remove guarded virtual methods from WebFilterOperation API
authordanakj@chromium.org <danakj@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 26 Apr 2012 05:44:22 +0000 (05:44 +0000)
committerdanakj@chromium.org <danakj@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 26 Apr 2012 05:44:22 +0000 (05:44 +0000)
commit056cfbfc94ea23c112043a4347deb493ff7c6df7
tree3b63072bf1889afa17975a6e5ad84f54ed671972
parent9bd8b1339b2487d2facb8b264c0ebb9b9e72ce82
[chromium] Remove guarded virtual methods from WebFilterOperation API
https://bugs.webkit.org/show_bug.cgi?id=84926

Reviewed by James Robinson.

Source/Platform:

We remove the virtual methods from the WebFilterOperation class,
and use an enum in the base class to distinguish which subclass
the object is. Then WebFilterOperations can access the correct
subclass to get the filter operation's data and construct a
WebCore::FilterOperation to store internally.

* chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::WebFilterOperation):
(WebKit::WebBasicColorMatrixFilterOperation::WebBasicColorMatrixFilterOperation):
(WebBasicColorMatrixFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::WebBasicComponentTransferFilterOperation):
(WebBasicComponentTransferFilterOperation):
(WebKit::WebBlurFilterOperation::WebBlurFilterOperation):
(WebKit::WebDropShadowFilterOperation::WebDropShadowFilterOperation):

Source/WebCore:

* WebCore.gypi:
* platform/chromium/support/WebFilterOperation.cpp: Removed.
* platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::append):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/Platform/ChangeLog
Source/Platform/chromium/public/WebFilterOperation.h
Source/WebCore/ChangeLog
Source/WebCore/WebCore.gypi
Source/WebCore/platform/chromium/support/WebFilterOperation.cpp [deleted file]
Source/WebCore/platform/chromium/support/WebFilterOperations.cpp
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/AssertMatchingEnums.cpp