LayoutTests:
authordarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Feb 2007 23:36:34 +0000 (23:36 +0000)
committerdarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Feb 2007 23:36:34 +0000 (23:36 +0000)
commit05468703bc8e470dba2a5415cc2ea80b76e29d4b
tree9fd85e9defd484f206fff874fae0c3c6af953424
parentb067805e883a88b95f1d2e62e001515f1051a6fb
LayoutTests:

        Reviewed by Hyatt.

        - update pixel results in cases where overline and line-through were used,
          because our old code put them 1px too low

        * css1/cascade/cascade_order-expected.checksum: Updated because this has
        line-through style.
        * css1/cascade/cascade_order-expected.png: Ditto.
        * css1/text_properties/text_decoration-expected.checksum: Updated because
        this has overline and line-through.
        * css1/text_properties/text_decoration-expected.png: Ditto.
        * css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum: Ditto.
        * css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Ditto.
        * fast/text/stroking-decorations-expected.checksum: Ditto.
        * fast/text/stroking-decorations-expected.png: Ditto.

        - added some missing pixel-test results

        * fast/forms/disabled-select-change-index-expected.checksum: Added.
        * fast/forms/disabled-select-change-index-expected.png: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12668
          <rdar://problem/4893344> REGRESSION: underline not visible for the international
          input inline hole in most text fields (12668)

        - fix bug where overline and line-through were 1px lower than we intended

        * platform/graphics/GraphicsContext.h: Removed unneeded y offset parameter.
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawLineForText): Removed bogus y offset and +1.
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::drawLineForText): Ditto.
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawLineForText): Ditto.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintTextDecorations): Added the "+1" that used to be
        inside drawLineForText to the underline-drawing code. Changed the other callers
        of drawLineForText to include the y offset in the y coordinate.
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintDecoration): Ditto. Also renamed _tx and _ty to
        remove the gratuitious underscores.
        (WebCore::InlineTextBox::paintMarkedTextUnderline): Made the default thickness
        be 1px instead of 0 (which ends up being roughly 1px in the CG code path anyway).
        Fixed the code computing the position to put the underline at the bottom of the
        line (different from regular underlines which are put 1px under the baseline).
        The old code used to put the underline 1px further down in the thick case, and
        2px further down in the non-thick case. Both of those are bad, because they
        could be completely clipped out in many cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
18 files changed:
LayoutTests/ChangeLog
LayoutTests/css1/cascade/cascade_order-expected.checksum
LayoutTests/css1/cascade/cascade_order-expected.png
LayoutTests/css1/text_properties/text_decoration-expected.checksum
LayoutTests/css1/text_properties/text_decoration-expected.png
LayoutTests/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum
LayoutTests/css2.1/t1504-c543-txt-decor-00-d-g-expected.png
LayoutTests/fast/forms/disabled-select-change-index-expected.checksum [new file with mode: 0644]
LayoutTests/fast/forms/disabled-select-change-index-expected.png [new file with mode: 0644]
LayoutTests/fast/text/stroking-decorations-expected.checksum
LayoutTests/fast/text/stroking-decorations-expected.png
WebCore/ChangeLog
WebCore/platform/graphics/GraphicsContext.h
WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
WebCore/platform/graphics/cg/GraphicsContextCG.cpp
WebCore/platform/graphics/qt/GraphicsContextQt.cpp
WebCore/rendering/InlineFlowBox.cpp
WebCore/rendering/InlineTextBox.cpp