2009-04-07 Dimitri Glazkov <dglazkov@chromium.org>
authordglazkov@chromium.org <dglazkov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 7 Apr 2009 22:37:43 +0000 (22:37 +0000)
committerdglazkov@chromium.org <dglazkov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 7 Apr 2009 22:37:43 +0000 (22:37 +0000)
commit037748ce0992f981f3d27a35141a378b3daf4d84
treea3b030452dc960933694c22efc6ce7ab80daf39b
parent8d19b62d5a00790b601da4dc1e3e7a62f6186086
2009-04-07  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=25063
        Refactor InspectorController to use ScriptObject/State.

        * GNUmakefile.am: Added ScriptState.cpp.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.
        * bindings/js/JSInspectorControllerCustom.cpp:
        (WebCore::JSInspectorController::addSourceToFrame): Fixed argument index typo.
        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::call): Added reportExceptions parameter.
        (WebCore::ScriptFunctionCall::construct): Ditto.
        * bindings/js/ScriptFunctionCall.h: Ditto.
        * bindings/js/ScriptObject.cpp:
        (WebCore::handleException): Added exception-reporting heloper.
        (WebCore::ScriptObject::set): Changed to use handleException.
        (WebCore::ScriptGlobalObject::set): Ditto,
        * bindings/js/ScriptObject.cpp: Added ScriptGlobalObject.
        (WebCore::ScriptGlobalObject::set): Added.
        (WebCore::ScriptGlobalObject::getObject): Added.
        * bindings/js/ScriptObject.h: Added ScriptGlobalObject decls.
        (WebCore::ScriptGlobalObject::ScriptGlobalObject): Added.
        * bindings/js/ScriptState.cpp: Added.
        * bindings/js/ScriptState.h: Added scriptStateFromPage decl.
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToConsole): Changed to not report exceptions
            to avoid re-entrancy.
        * inspector/InspectorController.cpp: Refactored to use ScriptState/Object.
        * inspector/InspectorController.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
16 files changed:
WebCore/ChangeLog
WebCore/GNUmakefile.am
WebCore/WebCore.pro
WebCore/WebCore.vcproj/WebCore.vcproj
WebCore/WebCore.xcodeproj/project.pbxproj
WebCore/WebCoreSources.bkl
WebCore/bindings/js/JSInspectorControllerCustom.cpp
WebCore/bindings/js/ScriptFunctionCall.cpp
WebCore/bindings/js/ScriptFunctionCall.h
WebCore/bindings/js/ScriptObject.cpp
WebCore/bindings/js/ScriptObject.h
WebCore/bindings/js/ScriptState.cpp [new file with mode: 0644]
WebCore/bindings/js/ScriptState.h
WebCore/inspector/ConsoleMessage.cpp
WebCore/inspector/InspectorController.cpp
WebCore/inspector/InspectorController.h