[GTK] AccessibilityUIElement::role() should be consistent across platforms wherever...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Oct 2012 00:07:08 +0000 (00:07 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Oct 2012 00:07:08 +0000 (00:07 +0000)
commit02526ac3e3126046311b3f8ee73a9a23a2d270e2
treebc1833818e8bf34189a84528f42fd004b67ede0d
parentb7d27f889334190083fbb87b3f02a465a46eeaa4
[GTK] AccessibilityUIElement::role() should be consistent across platforms wherever possible
https://bugs.webkit.org/show_bug.cgi?id=99640

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-10-17
Reviewed by Chris Fleizach.

Tools:

Convert AtkRole instances to the Mac/Safari-style AXRole string.

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(roleToString): New method to convert AtkRole instances to the Mac/Safari-style AXRole string
(AccessibilityUIElement::role): Output the Mac/Safair-style AXRole string rather than the AtkRole's name

LayoutTests:

Updated tests and expectations to use the Mac/Safari-style AXRole strings

* platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
* platform/gtk/accessibility/aria-combobox-expected.txt:
* platform/gtk/accessibility/aria-fallback-roles-expected.txt:
* platform/gtk/accessibility/aria-menubar-menuitems-expected.txt:
* platform/gtk/accessibility/aria-roles-expected.txt:
* platform/gtk/accessibility/aria-roles-unignored-expected.txt:
* platform/gtk/accessibility/aria-roles-unignored.html:
* platform/gtk/accessibility/aria-slider-required-attributes-expected.txt:
* platform/gtk/accessibility/aria-slider-required-attributes.html:
* platform/gtk/accessibility/aria-table-hierarchy-expected.txt:
* platform/gtk/accessibility/aria-table-hierarchy.html:
* platform/gtk/accessibility/aria-tables-expected.txt:
* platform/gtk/accessibility/aria-toggle-button-role-expected.txt:
* platform/gtk/accessibility/aria-toggle-button-role.html:
* platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt:
* platform/gtk/accessibility/button-accessible-name-expected.txt:
* platform/gtk/accessibility/button-accessible-name.html:
* platform/gtk/accessibility/canvas-description-and-role-expected.txt:
* platform/gtk/accessibility/caret-browsing-text-focus-expected.txt:
* platform/gtk/accessibility/caret-browsing-text-focus.html:
* platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt:
* platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt:
* platform/gtk/accessibility/entry-and-password-expected.txt:
* platform/gtk/accessibility/input-slider-expected.txt:
* platform/gtk/accessibility/input-slider.html:
* platform/gtk/accessibility/legend-expected.txt:
* platform/gtk/accessibility/list-items-always-exposed-expected.txt:
* platform/gtk/accessibility/list-items-always-exposed.html:
* platform/gtk/accessibility/media-controls-panel-title-expected.txt:
* platform/gtk/accessibility/media-controls-panel-title.html:
* platform/gtk/accessibility/name-from-label-expected.txt:
* platform/gtk/accessibility/name-from-label.html:
* platform/gtk/accessibility/object-with-title-expected.txt:
* platform/gtk/accessibility/object-with-title.html:
* platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
* platform/gtk/accessibility/spans-expected.txt:
* platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt:
* platform/gtk/accessibility/spans-paragraphs-and-divs.html:
* platform/gtk/accessibility/spans.html:
* platform/gtk/accessibility/svg-image-expected.txt:
* platform/gtk/accessibility/table-hierarchy-expected.txt:
* platform/gtk/accessibility/table-hierarchy.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
45 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt
LayoutTests/platform/gtk/accessibility/aria-combobox-expected.txt
LayoutTests/platform/gtk/accessibility/aria-fallback-roles-expected.txt
LayoutTests/platform/gtk/accessibility/aria-menubar-menuitems-expected.txt
LayoutTests/platform/gtk/accessibility/aria-roles-expected.txt
LayoutTests/platform/gtk/accessibility/aria-roles-unignored-expected.txt
LayoutTests/platform/gtk/accessibility/aria-roles-unignored.html
LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt
LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes.html
LayoutTests/platform/gtk/accessibility/aria-table-hierarchy-expected.txt
LayoutTests/platform/gtk/accessibility/aria-table-hierarchy.html
LayoutTests/platform/gtk/accessibility/aria-tables-expected.txt
LayoutTests/platform/gtk/accessibility/aria-toggle-button-role-expected.txt
LayoutTests/platform/gtk/accessibility/aria-toggle-button-role.html
LayoutTests/platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt
LayoutTests/platform/gtk/accessibility/button-accessible-name-expected.txt
LayoutTests/platform/gtk/accessibility/button-accessible-name.html
LayoutTests/platform/gtk/accessibility/canvas-description-and-role-expected.txt
LayoutTests/platform/gtk/accessibility/caret-browsing-text-focus-expected.txt
LayoutTests/platform/gtk/accessibility/caret-browsing-text-focus.html
LayoutTests/platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt
LayoutTests/platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt
LayoutTests/platform/gtk/accessibility/entry-and-password-expected.txt
LayoutTests/platform/gtk/accessibility/input-slider-expected.txt
LayoutTests/platform/gtk/accessibility/input-slider.html
LayoutTests/platform/gtk/accessibility/legend-expected.txt
LayoutTests/platform/gtk/accessibility/list-items-always-exposed-expected.txt
LayoutTests/platform/gtk/accessibility/list-items-always-exposed.html
LayoutTests/platform/gtk/accessibility/media-controls-panel-title-expected.txt
LayoutTests/platform/gtk/accessibility/media-controls-panel-title.html
LayoutTests/platform/gtk/accessibility/name-from-label-expected.txt
LayoutTests/platform/gtk/accessibility/name-from-label.html
LayoutTests/platform/gtk/accessibility/object-with-title-expected.txt
LayoutTests/platform/gtk/accessibility/object-with-title.html
LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt
LayoutTests/platform/gtk/accessibility/spans-expected.txt
LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt
LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs.html
LayoutTests/platform/gtk/accessibility/spans.html
LayoutTests/platform/gtk/accessibility/svg-image-expected.txt
LayoutTests/platform/gtk/accessibility/table-hierarchy-expected.txt
LayoutTests/platform/gtk/accessibility/table-hierarchy.html
Tools/ChangeLog
Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp