X-Git-Url: http://git.webkit.org/?p=WebKit-https.git;a=blobdiff_plain;f=Source%2FWebKit2%2FChangeLog;h=b2db8d7207b6e3e8bf6be0ae92121e8c65120ae9;hp=e58002283e916033dde19066f3786aebf67f89e6;hb=eadceed22b307f96168b5dead8401a40847b1664;hpb=a4216b94fb309e21e9c066c81dd7b3316843629d diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog index e580022..b2db8d7 100644 --- a/Source/WebKit2/ChangeLog +++ b/Source/WebKit2/ChangeLog @@ -1,3 +1,27 @@ +2014-08-07 Timothy Horton + + setCustomSwipeViews inside didChangeBackForwardList client callback is ignored + https://bugs.webkit.org/show_bug.cgi?id=135633 + + + Reviewed by Sam Weinig. + + * UIProcess/PageClient.h: + * UIProcess/WebPageProxy.cpp: + (WebKit::WebPageProxy::didChangeBackForwardList): + * UIProcess/ios/PageClientImplIOS.h: + * UIProcess/ios/PageClientImplIOS.mm: + (WebKit::PageClientImpl::clearCustomSwipeViews): Deleted. + * UIProcess/mac/PageClientImpl.h: + * UIProcess/mac/PageClientImpl.mm: + (WebKit::PageClientImpl::clearCustomSwipeViews): Deleted. + WebKit clears the set of custom swipe views at the end of WebPageProxy::didChangeBackForwardList, + *after* calling into the client. This means that if the client wants to setCustomSwipeViews in + didChangeBackForwardList, it won't be respected. + + Since there's only one client of this SPI, let's just stop clearing the list of custom swipe + views in WebKit and leave that totally up to the client. + 2014-08-07 Enrica Casucci [Services with UI] Action menu does not appear if selection includes both text and an image.