LayoutTests:
[WebKit-https.git] / WebCore / ChangeLog
index b4542f4..72b9d44 100644 (file)
@@ -1,3 +1,336 @@
+2007-01-30  Graham Dennis  <graham.dennis@gmail.com>
+
+        Reviewed by Maciej.
+
+        Part of fix for http://bugs.webkit.org/show_bug.cgi?id=10725
+        Image data in from RTFD clipboard data thrown away
+        
+        ResourceHandles no longer need to be able to defer loading as that is
+        now handled by the ResourceLoader.
+
+        * loader/MainResourceLoader.cpp:
+        (WebCore::MainResourceLoader::loadNow): updated to remove defersLoading argument.
+        * loader/ResourceLoader.cpp:
+        (WebCore::ResourceLoader::releaseResources): release the deferred request.
+        (WebCore::ResourceLoader::load): defer creating the ResourceHandle instead of
+        asking the ResourceHandle to defer loading.
+        (WebCore::ResourceLoader::setDefersLoading): create the ResourceHandle if we have deferred creating it.
+        * loader/ResourceLoader.h:
+        * platform/network/ResourceHandle.cpp: ResourceHandle's don't need to know about deferLoading.
+        (WebCore::ResourceHandle::ResourceHandle):
+        (WebCore::ResourceHandle::create):
+        * platform/network/ResourceHandle.h: ditto.
+        * platform/network/ResourceHandleInternal.h: ditto.
+        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
+        * platform/network/mac/ResourceHandleMac.mm: ditto.
+        (WebCore::ResourceHandle::start):
+
+2007-01-29  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Alice
+
+        Lets use smart pointers, shall we?
+
+        * platform/network/ResourceHandleInternal.h:
+
+2007-01-29  Justin Garcia  <justin.garcia@apple.com>
+
+        Reviewed by harrison
+        
+        <rdar://problem/4960137>
+        ASSERTION FAILURE calling SelectionController::setBaseAndExtent (11833)
+
+        * editing/SelectionController.cpp:
+        (WebCore::SelectionController::setSelection): Hand off the selection
+        to the selectionController responsible for it, instead of asserting.
+        A selection object can't be constructed with endpoints in different 
+        documents, so this code is only necessary for one endpoint.
+
+2007-01-29  Ada Chan  <adachan@apple.com>
+
+        Reviewed by Brady.
+        
+        Moved the update of the title of the current entry in the backforward list to WebCore.
+
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::didChangeTitle):
+
+2007-01-29  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Darin.
+
+        More preparation for event handling fixes.
+
+        * bridge/EditorClient.h: Removed EventTargetNode parameter from handleKeyPress since we can just get that from the event.
+        * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): ditto.
+        * page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): ditto.
+        * page/EventHandler.h: ditto.
+        * platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): ditto.
+
+        * editing/Editor.h:
+        * editing/Editor.cpp:
+        (WebCore::Editor::handleKeyPress): Removed EventTargetNode parameter.
+        (WebCore::Editor::execCommand): Made commandMap use AtomicStringImpls instead of Strings.
+        (WebCore::Editor::insertText): Moved from the bridge.
+
+        * page/mac/WebCoreFrameBridge.h: Moved insertText method to Editor.
+        * page/mac/WebCoreFrameBridge.mm:
+
+        * WebCore.exp: Updated exports.
+
+2007-01-29  Anders Carlsson  <acarlsson@apple.com>
+
+        Reviewed by Geoff.
+
+        <rdar://problem/4960097>
+        http://bugs.webkit.org/show_bug.cgi?id=12444
+        Assertion failure in -[WebCoreFrameBridge installInFrame:]
+        
+        The problem was that the XML tokenizer didn't create elements with 
+        createdByParser set to true.
+        
+        * dom/Document.cpp:
+        (WebCore::Document::createElement):
+        New method which takes a QName. This is used by both the XML tokenizer and createElementNS.
+        
+        (WebCore::Document::createElementNS):
+        Call new createElement method.
+        
+        * dom/XMLTokenizer.h:        
+        * dom/XMLTokenizer.cpp:
+        (WebCore::XMLTokenizer::XMLTokenizer):
+        (WebCore::XMLTokenizer::~XMLTokenizer):
+        Use an OwnPtr for the pending callbacks object. Also, use String instead of StringImpl in the hash map.
+        
+        (WebCore::toString):
+        (WebCore::XMLTokenizer::startElementNs):
+        Call createElement.
+        
+2007-01-29  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Oliver
+
+        http://bugs.webkit.org/show_bug.cgi?id=12465
+        Only set the iconURL port for non-zero ports
+
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::iconURL):
+
+2007-01-29  John Sullivan  <sullivan@apple.com>
+
+        * platform/network/mac/ResourceRequestMac.mm:
+        Build fix -- removed #import of no-longer-extant WebDataProtocol.h (and also one of the
+        two #imports for WebCoreSystemInterface.h, while I was at it)
+
+2007-01-29  Anders Carlsson  <acarlsson@apple.com>
+
+        Reviewed by Oliver.
+
+        * page/DragController.cpp:
+        (WebCore::DragController::dragEnteredOrUpdated):
+        Only try a drag operation if the drag client explicitly specified that it is OK
+
+2007-01-29  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Adam.
+
+        Migrated more drag logic and state to WebCore
+                                              
+        * page/DragClient.h:       
+
+        * page/DragController.cpp:
+        (WebCore::DragController::delegateDragSourceAction):
+          New forwarding method for the UI delegate
+        * page/DragController.h:
+        (WebCore::DragController::dragOffset):
+          Now store the drag offset -- the offset of the cursor relative to the drag image)
+          in DragController
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::allowDHTMLDrag):
+          Moved from WebFrameBridge
+        * page/EventHandler.h:
+        * page/mac/EventHandlerMac.mm:
+        (WebCore::EventHandler::eventMayStartDrag):
+        (WebCore::EventHandler::handleDrag):                  
+          EventHandlerMac now uses EventHandler::allowDHTMLDrag rather than the 
+          implementation in WebFrameBridge
+        * page/mac/WebCoreFrameBridge.h:
+          removed definition of allowDHTMLDrag from WebFrameBridge
+        * platform/graphics/svg/SVGImageEmptyClients.h:
+        (WebCore::SVGEmptyDragClient::dragSourceActionMaskForPoint):
+          Updated empty DragClient
+
+2007-01-29  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Darin.
+
+        http://bugs.webkit.org/show_bug.cgi?id=12359
+        XPathEvaluator may return some nodes more than once in a result set
+
+        Test: fast/xpath/nodeset-duplicates.html
+
+        * xml/XPathPath.cpp:
+        (WebCore::XPath::LocationPath::doEvaluate): Ensure uniqueness of elements
+        in the node-set.
+
+        * xml/XPathPredicate.cpp:
+        (WebCore::XPath::Union::doEvaluate): Fixed a uniqueness algorithm that was
+        already present here. Added a FIXME about incorrect result ordering.
+
+2007-01-29  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Darin.
+
+        http://bugs.webkit.org/show_bug.cgi?id=12340
+        XPathEvaluator behavior does not match Firefox - name() and attribute nodes
+
+        * xml/XPathFunctions.cpp:
+        (WebCore::XPath::FunName::doEvaluate): Do not try to append a prefix if it doesn't exist.
+
+2007-01-29  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Darin.
+
+        http://bugs.webkit.org/show_bug.cgi?id=11815
+        XPathEvaluator behavior does not match Firefox - substring() and empty element
+
+        Test: fast/xpath/empty-string-substring.html
+
+        * xml/XPathValue.cpp:
+        (WebCore::XPath::Value::Value):
+        * xml/XPathValue.h:
+        Added a constructor taking const char*, so that string literals and arrays don't 
+        get converted to boolean values.
+
+2007-01-29  Zack Rusin  <zrusin@trolltech.com>
+
+        Cosmetic fixes - don't resize the widget in the constructor
+        (it was a hack from the initial port) and fix the paint
+        signature.
+
+        * platform/qt/ScrollViewCanvasQt.cpp:
+        (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
+        * platform/qt/WidgetQt.cpp:
+        (WebCore::Widget::paint):
+
+2007-01-29  Maciej Stachowiak  <mjs@apple.com>
+
+        - change from struct to class to make picky compilers happy
+
+        * loader/SubstituteData.h:
+
+2007-01-30  Mark Rowe  <mrowe@apple.com>
+
+        Reviewed by Maciej.
+
+        http://bugs.webkit.org/show_bug.cgi?id=12458
+        Bug 12458: Crash in W3C-SVG-1.1/animate-elem-09-t.svg running layout tests under guard malloc
+
+        * ksvg2/svg/SVGAnimationElement.cpp: 
+        (WebCore::parseValues): ptr either points to a ';' or off the end of the buffer.  We're
+        interested in what comes before the ';', so start there instead.
+
+2007-01-29  Zack Rusin  <zrusin@trolltech.com>
+
+        Reviewed by Lars.
+
+        Take the scrollbars into considation when computing
+        the contents size of the main frame.
+
+        * platform/qt/PlatformScrollBarQt.cpp:
+        (WebCore::PlatformScrollbar::paint):
+        * platform/qt/ScrollViewQt.cpp:
+        (WebCore::ScrollView::visibleWidth):
+        (WebCore::ScrollView::visibleHeight):
+        (WebCore::ScrollView::visibleContentRect):
+        * platform/qt/WidgetQt.cpp:
+        (WebCore::Widget::invalidate):
+        (WebCore::Widget::invalidateRect):
+
+2007-01-29  Maciej Stachowiak  <mjs@apple.com>
+
+        - fix includes
+
+        * loader/SubstituteData.h:
+
+2007-01-29  Maciej Stachowiak  <mjs@apple.com>
+
+        - added new file that I forgot in the last commit
+
+        * loader/SubstituteData.h: Added.
+        (WebCore::SubstituteData::SubstituteData):
+        (WebCore::SubstituteData::isValid):
+        (WebCore::SubstituteData::content):
+        (WebCore::SubstituteData::mimeType):
+        (WebCore::SubstituteData::textEncoding):
+        (WebCore::SubstituteData::failingURL):
+
+2007-01-29  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Mark.
+
+        - made data loading cross-platform
+        - fixed <rdar://problem/4910106>
+
+        * WebCore.exp:
+        * WebCore.xcodeproj/project.pbxproj:
+        * loader/CachedResource.cpp:
+        * loader/CachedResource.h:
+        * loader/DocLoader.cpp:
+        (WebCore::DocLoader::requestResource):
+        * loader/DocumentLoader.cpp:
+        (WebCore::DocumentLoader::DocumentLoader):
+        (WebCore::DocumentLoader::setRequest):
+        (WebCore::DocumentLoader::urlForHistory):
+        (WebCore::DocumentLoader::unreachableURL):
+        * loader/DocumentLoader.h:
+        (WebCore::DocumentLoader::substituteData):
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::load):
+        (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
+        (WebCore::FrameLoader::reloadAllowingStaleData):
+        (WebCore::FrameLoader::reload):
+        (WebCore::FrameLoader::commitProvisionalLoad):
+        (WebCore::FrameLoader::startLoadingMainResource):
+        (WebCore::FrameLoader::startLoading):
+        (WebCore::FrameLoader::checkNavigationPolicy):
+        * loader/FrameLoader.h:
+        * loader/FrameLoaderClient.h:
+        * loader/MainResourceLoader.cpp:
+        (WebCore::MainResourceLoader::willSendRequest):
+        (WebCore::MainResourceLoader::continueAfterContentPolicy):
+        (WebCore::MainResourceLoader::handleEmptyLoad):
+        (WebCore::MainResourceLoader::handleDataLoad):
+        (WebCore::MainResourceLoader::loadNow):
+        (WebCore::MainResourceLoader::load):
+        * loader/MainResourceLoader.h:
+        * loader/mac/DocumentLoaderMac.mm:
+        * loader/mac/WebDataProtocol.h: Removed.
+        * loader/mac/WebDataProtocol.mm: Removed.
+        * loader/qt/DocumentLoaderQt.cpp:
+        * platform/graphics/svg/SVGImageEmptyClients.h:
+        (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):
+
+2007-01-29  Zack Rusin  <zrusin@trolltech.com>
+
+        Order the build files alphabetically instead of
+        the random mess we had before.
+
+        * WebCore.pro:
+
+2007-01-29  Zack Rusin  <zack@kde.org>
+
+        Reviewed by Lars
+
+        Use the platform independent scrollbar code.
+        Remove the redundant empty stubs and forward
+        few missing platform scrollbar calls.
+
+        * WebCore.pro:
+        * platform/qt/PlatformScrollBarQt.cpp:
+        (WebCore::PlatformScrollbar::paint):
+        (WebCore::PlatformScrollbar::setRect):
+
 2007-01-29  Lars Knoll <lars@trolltech.com>
 
         Reviewed by Zack