LayoutTests:
[WebKit-https.git] / WebCore / ChangeLog
index 08a3c68..72b9d44 100644 (file)
@@ -1,3 +1,795 @@
+2007-01-30  Graham Dennis  <graham.dennis@gmail.com>
+
+        Reviewed by Maciej.
+
+        Part of fix for http://bugs.webkit.org/show_bug.cgi?id=10725
+        Image data in from RTFD clipboard data thrown away
+        
+        ResourceHandles no longer need to be able to defer loading as that is
+        now handled by the ResourceLoader.
+
+        * loader/MainResourceLoader.cpp:
+        (WebCore::MainResourceLoader::loadNow): updated to remove defersLoading argument.
+        * loader/ResourceLoader.cpp:
+        (WebCore::ResourceLoader::releaseResources): release the deferred request.
+        (WebCore::ResourceLoader::load): defer creating the ResourceHandle instead of
+        asking the ResourceHandle to defer loading.
+        (WebCore::ResourceLoader::setDefersLoading): create the ResourceHandle if we have deferred creating it.
+        * loader/ResourceLoader.h:
+        * platform/network/ResourceHandle.cpp: ResourceHandle's don't need to know about deferLoading.
+        (WebCore::ResourceHandle::ResourceHandle):
+        (WebCore::ResourceHandle::create):
+        * platform/network/ResourceHandle.h: ditto.
+        * platform/network/ResourceHandleInternal.h: ditto.
+        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
+        * platform/network/mac/ResourceHandleMac.mm: ditto.
+        (WebCore::ResourceHandle::start):
+
+2007-01-29  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Alice
+
+        Lets use smart pointers, shall we?
+
+        * platform/network/ResourceHandleInternal.h:
+
+2007-01-29  Justin Garcia  <justin.garcia@apple.com>
+
+        Reviewed by harrison
+        
+        <rdar://problem/4960137>
+        ASSERTION FAILURE calling SelectionController::setBaseAndExtent (11833)
+
+        * editing/SelectionController.cpp:
+        (WebCore::SelectionController::setSelection): Hand off the selection
+        to the selectionController responsible for it, instead of asserting.
+        A selection object can't be constructed with endpoints in different 
+        documents, so this code is only necessary for one endpoint.
+
+2007-01-29  Ada Chan  <adachan@apple.com>
+
+        Reviewed by Brady.
+        
+        Moved the update of the title of the current entry in the backforward list to WebCore.
+
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::didChangeTitle):
+
+2007-01-29  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Darin.
+
+        More preparation for event handling fixes.
+
+        * bridge/EditorClient.h: Removed EventTargetNode parameter from handleKeyPress since we can just get that from the event.
+        * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): ditto.
+        * page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): ditto.
+        * page/EventHandler.h: ditto.
+        * platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): ditto.
+
+        * editing/Editor.h:
+        * editing/Editor.cpp:
+        (WebCore::Editor::handleKeyPress): Removed EventTargetNode parameter.
+        (WebCore::Editor::execCommand): Made commandMap use AtomicStringImpls instead of Strings.
+        (WebCore::Editor::insertText): Moved from the bridge.
+
+        * page/mac/WebCoreFrameBridge.h: Moved insertText method to Editor.
+        * page/mac/WebCoreFrameBridge.mm:
+
+        * WebCore.exp: Updated exports.
+
+2007-01-29  Anders Carlsson  <acarlsson@apple.com>
+
+        Reviewed by Geoff.
+
+        <rdar://problem/4960097>
+        http://bugs.webkit.org/show_bug.cgi?id=12444
+        Assertion failure in -[WebCoreFrameBridge installInFrame:]
+        
+        The problem was that the XML tokenizer didn't create elements with 
+        createdByParser set to true.
+        
+        * dom/Document.cpp:
+        (WebCore::Document::createElement):
+        New method which takes a QName. This is used by both the XML tokenizer and createElementNS.
+        
+        (WebCore::Document::createElementNS):
+        Call new createElement method.
+        
+        * dom/XMLTokenizer.h:        
+        * dom/XMLTokenizer.cpp:
+        (WebCore::XMLTokenizer::XMLTokenizer):
+        (WebCore::XMLTokenizer::~XMLTokenizer):
+        Use an OwnPtr for the pending callbacks object. Also, use String instead of StringImpl in the hash map.
+        
+        (WebCore::toString):
+        (WebCore::XMLTokenizer::startElementNs):
+        Call createElement.
+        
+2007-01-29  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Oliver
+
+        http://bugs.webkit.org/show_bug.cgi?id=12465
+        Only set the iconURL port for non-zero ports
+
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::iconURL):
+
+2007-01-29  John Sullivan  <sullivan@apple.com>
+
+        * platform/network/mac/ResourceRequestMac.mm:
+        Build fix -- removed #import of no-longer-extant WebDataProtocol.h (and also one of the
+        two #imports for WebCoreSystemInterface.h, while I was at it)
+
+2007-01-29  Anders Carlsson  <acarlsson@apple.com>
+
+        Reviewed by Oliver.
+
+        * page/DragController.cpp:
+        (WebCore::DragController::dragEnteredOrUpdated):
+        Only try a drag operation if the drag client explicitly specified that it is OK
+
+2007-01-29  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Adam.
+
+        Migrated more drag logic and state to WebCore
+                                              
+        * page/DragClient.h:       
+
+        * page/DragController.cpp:
+        (WebCore::DragController::delegateDragSourceAction):
+          New forwarding method for the UI delegate
+        * page/DragController.h:
+        (WebCore::DragController::dragOffset):
+          Now store the drag offset -- the offset of the cursor relative to the drag image)
+          in DragController
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::allowDHTMLDrag):
+          Moved from WebFrameBridge
+        * page/EventHandler.h:
+        * page/mac/EventHandlerMac.mm:
+        (WebCore::EventHandler::eventMayStartDrag):
+        (WebCore::EventHandler::handleDrag):                  
+          EventHandlerMac now uses EventHandler::allowDHTMLDrag rather than the 
+          implementation in WebFrameBridge
+        * page/mac/WebCoreFrameBridge.h:
+          removed definition of allowDHTMLDrag from WebFrameBridge
+        * platform/graphics/svg/SVGImageEmptyClients.h:
+        (WebCore::SVGEmptyDragClient::dragSourceActionMaskForPoint):
+          Updated empty DragClient
+
+2007-01-29  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Darin.
+
+        http://bugs.webkit.org/show_bug.cgi?id=12359
+        XPathEvaluator may return some nodes more than once in a result set
+
+        Test: fast/xpath/nodeset-duplicates.html
+
+        * xml/XPathPath.cpp:
+        (WebCore::XPath::LocationPath::doEvaluate): Ensure uniqueness of elements
+        in the node-set.
+
+        * xml/XPathPredicate.cpp:
+        (WebCore::XPath::Union::doEvaluate): Fixed a uniqueness algorithm that was
+        already present here. Added a FIXME about incorrect result ordering.
+
+2007-01-29  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Darin.
+
+        http://bugs.webkit.org/show_bug.cgi?id=12340
+        XPathEvaluator behavior does not match Firefox - name() and attribute nodes
+
+        * xml/XPathFunctions.cpp:
+        (WebCore::XPath::FunName::doEvaluate): Do not try to append a prefix if it doesn't exist.
+
+2007-01-29  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Darin.
+
+        http://bugs.webkit.org/show_bug.cgi?id=11815
+        XPathEvaluator behavior does not match Firefox - substring() and empty element
+
+        Test: fast/xpath/empty-string-substring.html
+
+        * xml/XPathValue.cpp:
+        (WebCore::XPath::Value::Value):
+        * xml/XPathValue.h:
+        Added a constructor taking const char*, so that string literals and arrays don't 
+        get converted to boolean values.
+
+2007-01-29  Zack Rusin  <zrusin@trolltech.com>
+
+        Cosmetic fixes - don't resize the widget in the constructor
+        (it was a hack from the initial port) and fix the paint
+        signature.
+
+        * platform/qt/ScrollViewCanvasQt.cpp:
+        (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
+        * platform/qt/WidgetQt.cpp:
+        (WebCore::Widget::paint):
+
+2007-01-29  Maciej Stachowiak  <mjs@apple.com>
+
+        - change from struct to class to make picky compilers happy
+
+        * loader/SubstituteData.h:
+
+2007-01-30  Mark Rowe  <mrowe@apple.com>
+
+        Reviewed by Maciej.
+
+        http://bugs.webkit.org/show_bug.cgi?id=12458
+        Bug 12458: Crash in W3C-SVG-1.1/animate-elem-09-t.svg running layout tests under guard malloc
+
+        * ksvg2/svg/SVGAnimationElement.cpp: 
+        (WebCore::parseValues): ptr either points to a ';' or off the end of the buffer.  We're
+        interested in what comes before the ';', so start there instead.
+
+2007-01-29  Zack Rusin  <zrusin@trolltech.com>
+
+        Reviewed by Lars.
+
+        Take the scrollbars into considation when computing
+        the contents size of the main frame.
+
+        * platform/qt/PlatformScrollBarQt.cpp:
+        (WebCore::PlatformScrollbar::paint):
+        * platform/qt/ScrollViewQt.cpp:
+        (WebCore::ScrollView::visibleWidth):
+        (WebCore::ScrollView::visibleHeight):
+        (WebCore::ScrollView::visibleContentRect):
+        * platform/qt/WidgetQt.cpp:
+        (WebCore::Widget::invalidate):
+        (WebCore::Widget::invalidateRect):
+
+2007-01-29  Maciej Stachowiak  <mjs@apple.com>
+
+        - fix includes
+
+        * loader/SubstituteData.h:
+
+2007-01-29  Maciej Stachowiak  <mjs@apple.com>
+
+        - added new file that I forgot in the last commit
+
+        * loader/SubstituteData.h: Added.
+        (WebCore::SubstituteData::SubstituteData):
+        (WebCore::SubstituteData::isValid):
+        (WebCore::SubstituteData::content):
+        (WebCore::SubstituteData::mimeType):
+        (WebCore::SubstituteData::textEncoding):
+        (WebCore::SubstituteData::failingURL):
+
+2007-01-29  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Mark.
+
+        - made data loading cross-platform
+        - fixed <rdar://problem/4910106>
+
+        * WebCore.exp:
+        * WebCore.xcodeproj/project.pbxproj:
+        * loader/CachedResource.cpp:
+        * loader/CachedResource.h:
+        * loader/DocLoader.cpp:
+        (WebCore::DocLoader::requestResource):
+        * loader/DocumentLoader.cpp:
+        (WebCore::DocumentLoader::DocumentLoader):
+        (WebCore::DocumentLoader::setRequest):
+        (WebCore::DocumentLoader::urlForHistory):
+        (WebCore::DocumentLoader::unreachableURL):
+        * loader/DocumentLoader.h:
+        (WebCore::DocumentLoader::substituteData):
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::load):
+        (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
+        (WebCore::FrameLoader::reloadAllowingStaleData):
+        (WebCore::FrameLoader::reload):
+        (WebCore::FrameLoader::commitProvisionalLoad):
+        (WebCore::FrameLoader::startLoadingMainResource):
+        (WebCore::FrameLoader::startLoading):
+        (WebCore::FrameLoader::checkNavigationPolicy):
+        * loader/FrameLoader.h:
+        * loader/FrameLoaderClient.h:
+        * loader/MainResourceLoader.cpp:
+        (WebCore::MainResourceLoader::willSendRequest):
+        (WebCore::MainResourceLoader::continueAfterContentPolicy):
+        (WebCore::MainResourceLoader::handleEmptyLoad):
+        (WebCore::MainResourceLoader::handleDataLoad):
+        (WebCore::MainResourceLoader::loadNow):
+        (WebCore::MainResourceLoader::load):
+        * loader/MainResourceLoader.h:
+        * loader/mac/DocumentLoaderMac.mm:
+        * loader/mac/WebDataProtocol.h: Removed.
+        * loader/mac/WebDataProtocol.mm: Removed.
+        * loader/qt/DocumentLoaderQt.cpp:
+        * platform/graphics/svg/SVGImageEmptyClients.h:
+        (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):
+
+2007-01-29  Zack Rusin  <zrusin@trolltech.com>
+
+        Order the build files alphabetically instead of
+        the random mess we had before.
+
+        * WebCore.pro:
+
+2007-01-29  Zack Rusin  <zack@kde.org>
+
+        Reviewed by Lars
+
+        Use the platform independent scrollbar code.
+        Remove the redundant empty stubs and forward
+        few missing platform scrollbar calls.
+
+        * WebCore.pro:
+        * platform/qt/PlatformScrollBarQt.cpp:
+        (WebCore::PlatformScrollbar::paint):
+        (WebCore::PlatformScrollbar::setRect):
+
+2007-01-29  Lars Knoll <lars@trolltech.com>
+
+        Reviewed by Zack
+
+        Fix the way we handle native widgets (QWidget) inside
+        WebCore. Now WebCore::Widget owns the QWidget in all
+        cases. This is the only way to get well defined semantics
+        for all teh native widgets we have (currently ScrollView
+        and ScrollBar, but plugins will follow).
+
+        This has the side effect that one cannot rely on a defined 
+        lifetime of a QWebFrame when using the API. 
+
+        * platform/Widget.h:
+        * platform/qt/PlatformScrollBarQt.cpp:
+        (WebCore::PlatformScrollbar::PlatformScrollbar):
+        * platform/qt/ScrollViewQt.cpp:
+        (WebCore::ScrollView::addChild):
+        (WebCore::ScrollView::removeChild):
+        * platform/qt/WidgetQt.cpp:
+        (WebCore::WidgetPrivate::WidgetPrivate):
+        (WebCore::WidgetPrivate::~WidgetPrivate):
+        (WebCore::Widget::qwidget):
+
+2007-01-28  George Staikos  <staikos@kde.org>
+
+        Reviewed by Maciej.
+
+        Don't send data during a redirect -> causes assert failure.
+
+        * platform/network/qt/ResourceHandleManagerQt.cpp:
+        (WebCore::ResourceHandleManager::receivedData):
+
+2007-01-29  Mark Rowe  <mrowe@apple.com>
+
+        Reviewed by Brady.
+
+        http://bugs.webkit.org/show_bug.cgi?id=11085
+        Bug 11085: REGRESSION: favicon.ico always looked for on port 80
+
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::iconURL): Copy the port over to the favicon URL.
+
+2007-01-28  Adam Roben  <aroben@apple.com>
+
+        Reviewed by Adele.
+
+        Fix http://bugs.webkit.org/show_bug.cgi?id=12453
+        REGRESSION(r19197): Tabbing into web page requires two key presses
+
+        All layout tests pass.
+
+        * page/FocusController.cpp:
+        (WebCore::FocusController::advanceFocus): If there's no focused frame,
+        actually go ahead and find a focusable node instead of just focusing
+        the main frame and quitting. This behavior was a holdover from a
+        previous desired tabbing behavior with respect to frames.
+
+2007-01-28  David Kilzer  <ddkilzer@webkit.org>
+
+        Reviewed by Darin and David Hyatt.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=12423
+          Mixing white-space:pre text with non white-space:pre text does not wrap properly
+
+        Test: fast/block/basic/white-space-pre-wraps.html
+
+        * rendering/bidi.cpp:
+        (WebCore::RenderBlock::findNextLineBreak): Wrap a non-wrapping text run if it
+        appears on a line with previous text runs that do wrap.
+
+2007-01-28  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=8360
+          Repro crash when onscroll handler deletes the scrolled object
+
+        Test: fast/layers/removed-by-scroll-handler.html
+
+        * page/FrameView.cpp:
+        (WebCore::FrameViewPrivate::FrameViewPrivate): Added a m_enqueueEvents count.
+        (WebCore::FrameView::layout): Raise the enqueue count before starting layout and
+        until after enqueued events are dispatched.
+        (WebCore::FrameView::scheduleEvent): Made this function dispatch the event
+        immediately unless the enqueue count is positive.
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::scrollToOffset): Schedule the scroll event through the
+        FrameView.
+        (WebCore::RenderLayer::scrollRectToVisible):
+        (WebCore::RenderLayer::updateScrollInfoAfterLayout):
+        (WebCore::Marquee::start):
+
+2007-01-28  Charles Ying  <charles_ying@yahoo.com>
+
+        Reviewed by eseidel.  Landed by eseidel.
+
+        Fix http://bugs.webkit.org/show_bug.cgi?id=12429
+            animateTransform rotate, with cx/cy is broken
+            
+        SVGTransform now contains a float point to store the rotation center, needed
+            to track rotation center for interpolation by animateTransform.
+            
+        SVGTransform now has an additional constructor:
+            SVGTransform(type) to make empty base value transforms that match their
+            distanced values.
+            
+        Removed m_colorDistance and m_transformDistance from their respective classes
+            as they are now computed at update time.
+
+        Fix a case where animateTransform did not parse transform values correctly
+            according to BNF in W3C spec:
+
+        Test case in:
+        * manual-tests/animation/animateTransform-toanimation.svg: Added.
+
+        Fix a case where animateTransform only specified a to animation only.
+
+        Test case in:
+        * manual-tests/animation/animateTransform-parser.svg: Added.
+
+        * ksvg2/svg/SVGAnimateColorElement.cpp:
+        (WebCore::SVGAnimateColorElement::updateAnimationBaseValueFromElement):
+        (WebCore::SVGAnimateColorElement::updateAnimatedValue):
+        (WebCore::SVGAnimateColorElement::calculateFromAndToValues):
+        * ksvg2/svg/SVGAnimateColorElement.h:
+        * ksvg2/svg/SVGAnimateTransformElement.cpp:
+        (WebCore::SVGAnimateTransformElement::updateAnimatedValue):
+        (WebCore::SVGAnimateTransformElement::updateAnimationBaseValueFromElement):
+        (WebCore::SVGAnimateTransformElement::calculateFromAndToValues):
+        (WebCore::SVGAnimateTransformElement::parseTransformValue):
+        * ksvg2/svg/SVGAnimateTransformElement.h:
+        * ksvg2/svg/SVGTransform.cpp:
+        (SVGTransform::SVGTransform):
+        (SVGTransform::angle):
+        (SVGTransform::rotationCenter):
+        (SVGTransform::setTranslate):
+        (SVGTransform::setScale):
+        (SVGTransform::setRotate):
+        (SVGTransform::setSkewX):
+        (SVGTransform::setSkewY):
+        * ksvg2/svg/SVGTransform.h:
+        * ksvg2/svg/SVGTransformDistance.cpp:
+        (WebCore::SVGTransformDistance::SVGTransformDistance):
+        (WebCore::SVGTransformDistance::scaledDistance):
+        (WebCore::SVGTransformDistance::addSVGTransforms):
+        (WebCore::SVGTransformDistance::addSVGTransform):
+        (WebCore::SVGTransformDistance::addToSVGTransform):
+        (WebCore::SVGTransformDistance::distance):
+        * ksvg2/svg/SVGTransformDistance.h:
+        * manual-tests/animation/animateTransform-parser.svg: Added.
+        * manual-tests/animation/animateTransform-toanimation.svg: Added.
+
+2007-01-27  Adam Roben  <aroben@apple.com>
+
+        Reviewed by Ada.
+
+        Fix <rdar://problem/4957184> REGRESSION: After creating a new mail
+        message, the caret is automatically in message body
+
+        -[WebHTMLView _updateActiveState] was calling
+        FocusController::focusedOrMainFrame, which had the surprising
+        side-effect of setting the focused frame if there was none. The fix
+        was to remove this side-effect.
+
+        No tests possible, as this bug involves focus outside the WebView,
+        which we have no support for in DRT.
+
+        Change inspired by Dave Harrison.
+
+        * page/FocusController.cpp:
+        (WebCore::FocusController::focusedOrMainFrame): Removed this method's
+        non-obvious side-effect of setting the focused frame.
+        * WebCore.xcodeproj/project.pbxproj: Version wars.
+
+2007-01-27  Don Gibson  <dgibson77@gmail.com>
+
+        Reviewed by Maciej.
+
+        http://bugs.webkit.org/show_bug.cgi?id=11880: Improve some egregious
+        Windows form control drawing issues:
+        Provide Classic mode fallbacks for the button/textfield drawing
+        routines.
+        Provide some basic drawing of menulists (still relatively broken).
+        Some cleanup.
+
+        * platform/win/TemporaryLinkStubs.cpp:
+        (WebCore::RenderThemeWin::systemFont):
+        * rendering/RenderThemeWin.cpp:
+        (WebCore::m_menuListTheme):
+        (WebCore::RenderThemeWin::close):
+        (WebCore::RenderThemeWin::determineClassicState):
+        (WebCore::RenderThemeWin::getThemeData):
+        (WebCore::RenderThemeWin::paintButton):
+        (WebCore::RenderThemeWin::paintTextField):
+        (WebCore::RenderThemeWin::paintMenuList):
+        (WebCore::RenderThemeWin::paintMenuListButton):
+        * rendering/RenderThemeWin.h:
+        (WebCore::ThemeData::m_classicState):
+        (WebCore::RenderThemeWin::setRadioSize):
+        (WebCore::RenderThemeWin::paintTextArea):
+
+2007-01-27  David Kilzer  <ddkilzer@webkit.org>
+
+        Reviewed by Adam.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=12260
+          Windows platform build is not maintained
+
+        * loader/win/FrameLoaderWin.cpp:
+        * platform/network/win/ResourceHandleWin.cpp:
+        * platform/win/TemporaryLinkStubs.cpp:
+        (WebCore::contextMenuItemTagOpenLinkInNewWindow):
+        (WebCore::contextMenuItemTagDownloadLinkToDisk):
+        (WebCore::contextMenuItemTagCopyLinkToClipboard):
+        (WebCore::contextMenuItemTagOpenImageInNewWindow):
+        (WebCore::contextMenuItemTagDownloadImageToDisk):
+        (WebCore::contextMenuItemTagCopyImageToClipboard):
+        (WebCore::contextMenuItemTagOpenFrameInNewWindow):
+        (WebCore::contextMenuItemTagCopy):
+        (WebCore::contextMenuItemTagGoBack):
+        (WebCore::contextMenuItemTagGoForward):
+        (WebCore::contextMenuItemTagStop):
+        (WebCore::contextMenuItemTagReload):
+        (WebCore::contextMenuItemTagCut):
+        (WebCore::contextMenuItemTagPaste):
+        (WebCore::contextMenuItemTagNoGuessesFound):
+        (WebCore::contextMenuItemTagIgnoreSpelling):
+        (WebCore::contextMenuItemTagLearnSpelling):
+        (WebCore::contextMenuItemTagSearchWeb):
+        (WebCore::contextMenuItemTagLookUpInDictionary):
+        (WebCore::contextMenuItemTagOpenLink):
+        (WebCore::contextMenuItemTagIgnoreGrammar):
+        (WebCore::contextMenuItemTagSpellingMenu):
+        (WebCore::contextMenuItemTagShowSpellingPanel):
+        (WebCore::contextMenuItemTagCheckSpelling):
+        (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
+        (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
+        (WebCore::contextMenuItemTagFontMenu):
+        (WebCore::contextMenuItemTagBold):
+        (WebCore::contextMenuItemTagItalic):
+        (WebCore::contextMenuItemTagUnderline):
+        (WebCore::contextMenuItemTagOutline):
+        (WebCore::contextMenuItemTagWritingDirectionMenu):
+        (WebCore::contextMenuItemTagDefaultDirection):
+        (WebCore::contextMenuItemTagLeftToRight):
+        (WebCore::contextMenuItemTagRightToLeft):
+        (WebCore::DocumentLoader::unreachableURL):
+        (WebCore::FrameLoader::redirectDataToPlugin):
+        (WebCore::FrameLoader::partClearedInBegin):
+        (WebCore::FrameLoader::createPlugin):
+
+2007-01-27  Sam Weinig  <sam@webkit.org>
+
+        Reviewed by Mitz.
+
+        - Patch for http://bugs.webkit.org/show_bug.cgi?id=11957
+          REGRESSION: Unordered List Bullets too big and changing from size
+
+        * rendering/RenderListMarker.cpp:
+        (WebCore::RenderListMarker::paint): Explicitly set the stroke size to 1.0f.
+
+2007-01-27  Lars Knoll <lars@trolltech.com>
+
+        Fix the Qt build and disable the usage
+        of QScrollbars for PlatformScrollBar for 
+        now as it causes crashes in the layout tests.
+
+        * WebCore.pro:
+        * ksvg2/svg/SVGTransformDistance.cpp:
+        * page/qt/FrameQt.cpp:
+        (WebCore::FrameQt::FrameQt):
+        (WebCore::FrameQt::bindingRootObject):
+        (WebCore::FrameQt::createRootObject):
+        * page/qt/FrameQt.h:
+        * platform/qt/PlatformScrollBarQt.cpp:
+        (WebCore::PlatformScrollbar::PlatformScrollbar):
+        * platform/qt/ScrollViewQt.cpp:
+        (WebCore::ScrollView::addChild):
+
+2007-01-27  David Kilzer  <ddkilzer@kilzer.net>
+
+        Reviewed by NOBODY (buildbot build fix).
+
+        * ksvg2/svg/ColorDistance.cpp:
+        (WebCore::ColorDistance::scaledDistance): Added static cast of arguments to int.
+
+2007-01-27  Rob Buis  <buis@kde.org>
+
+        Reviewed by NOBODY (typo in method name fix).
+
+        * ksvg2/svg/SVGSVGElement.cpp:
+        (WebCore::SVGSVGElement::addSVGWindowEventListener):
+        (WebCore::SVGSVGElement::parseMappedAttribute):
+        * ksvg2/svg/SVGSVGElement.h:
+
+2007-01-27  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by olliej.
+
+        Fix support for SVG's <set> element.
+
+        Manual test added.
+
+        * ksvg2/svg/SVGSetElement.cpp:
+        (WebCore::SVGSetElement::updateAnimatedValue):
+        (WebCore::SVGSetElement::calculateFromAndToValues):
+        * ksvg2/svg/SVGSetElement.h:
+        * manual-tests/animation/set-to.svg: Added.
+
+2007-01-27  Alexey Proskuryakov  <ap@webkit.org>
+
+        Release build fix.
+
+        * loader/TextResourceDecoder.cpp:
+        (WebCore::TextResourceDecoder::checkForHeadCharset):
+
+2007-01-27  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Darin.
+
+        http://bugs.webkit.org/show_bug.cgi?id=12389
+        Chinese decoding error at hk.antispam.yahoo.com
+
+        Test: fast/encoding/noscript-in-head.html
+
+        * loader/TextResourceDecoder.cpp:
+        (WebCore::TextResourceDecoder::checkForHeadCharset): We were already allowing 
+        NOSCRIPT tags in head, let's actually skip over their content.
+
+2007-01-26  Geoffrey Garen  <ggaren@apple.com>
+
+        Reviewed by Maciej Stachowiak.
+        
+        Fixed <rdar://problem/4608404> WebScriptObject's _executionContext lack 
+        of ownership policy causes crashes (e.g., in Dashcode)
+
+        Added RootObject ref-counting goodness.
+
+        * page/mac/FrameMac.h:
+        * page/mac/FrameMac.mm:
+        (WebCore::FrameMac::cleanupPluginObjects): Invalidate our RootObjects 
+        instead of detroying them. Track _bindingRootObject separately from the
+        rest of our RootObjects, since it has its own variable.
+
+        * page/mac/WebCoreFrameBridge.mm:
+        (createRootObject): Use the Frame's new, more encapsulated function to
+        create a RootObject.
+
+        * bindings/objc/WebScriptObject.mm: Nixed rootObject setters, since they
+        were unused and they complicated reference-counting.
+
+2007-01-26  David Kilzer  <ddkilzer@webkit.org>
+
+        Reviewed by Eric.
+
+        Release build fix.
+
+        * ksvg2/svg/SVGAnimationElement.cpp:
+        (WebCore::SVGAnimationElement::calculateValueIndexAndPercentagePast): Added static cast
+        to unsigned when calculating flooredValueIndex.
+
+2007-01-26  Darin Adler  <darin@apple.com>
+
+        - checked in slightly newer revision of the patch below
+
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+        Grouped all the unimplemented values at the bottom. Fixed the ifdef for
+        CSS_PROP__WEBKIT_DASHBOARD_REGION so that it compiles on all platforms.
+
+        * css/cssparser.cpp: (WebCore::CSSParser::parseValue): Removed default
+        case and added type so that the compiler warns about missing properties.
+        * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Ditto.
+
+2007-01-26  Darin Adler  <darin@apple.com>
+
+        Reviewed by Beth.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=12412
+          "unimplemented propertyID: 46" seen at dojotoolkit.org
+
+        Covered by fast/css/computed-style.html
+
+        * css/CSSPropertyNames.in: Sorted the file into two separate sections, one
+        for properties without the -webkit- prefix and another for properties with.
+
+        * css/makeprop: Generate a CSSPropertyID enum instead of a set of #defines.
+        Removed unused CSS_PROP_MIN and CSS_PROP_MAX. Renamed CSS_PROP_TOTAL to
+        numCSSProperties and changed it to a const int instead of #define.
+        Added a declaration of getPropertyName in the header. Changed the return
+        type of getPropertyName to const char* and the parameter type to CSSPropertyID.
+
+        * css/CSSComputedStyleDeclaration.cpp: Sort the lists of properties in
+        an easier to maintain order -- properties without a WebKit prefix first.
+        (WebCore::valueForLength): Changed return value to PassRefPtr.
+        (WebCore::valueForMaxLength): Ditto.
+        (WebCore::valueForBorderStyle): Ditto.
+        (WebCore::valueForTextAlign): Ditto.
+        (WebCore::valueForAppearance): Added.
+        (WebCore::valueForMarginCollapse): Added.
+        (WebCore::valueForShadow): Changed return value to PassRefPtr.
+        (WebCore::getPositionOffsetValue): Ditto.
+        (WebCore::currentColorOrValidColor): Ditto.
+        (WebCore::CSSComputedStyleDeclaration::cssText): Added cast since
+        getPropertyName now takes an enum value.
+        (WebCore::primitiveValueFromLength): Changed return value to PassRefPtr.
+        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+        Added cast to CSSPropertyID so that gcc will detect missing enums in the
+        switch statement. Simplified the background-size and border-spacing
+        implementations so they don't have local variables. Added lots of cases
+        to the switch statement for unimplemented properties. Implemented the
+        outline-width, box-sizing, -webkit-appearance, -webkit-rtl-ordering,
+        -webkit-user-drag, and -webkit-user-select properties.
+        (WebCore::CSSComputedStyleDeclaration::item): Added cast since
+        getPropertyName now takes an enum value.
+
+        * css/CSSMutableStyleDeclaration.cpp: Removed declaration of getPropertyName.
+        (WebCore::CSSMutableStyleDeclaration::item): Added cast since
+        getPropertyName now takes an enum value.
+
+        * css/CSSProperty.cpp: Removed declaration of getPropertyName.
+        (WebCore::CSSProperty::cssText): Added cast since
+        getPropertyName now takes an enum value and returns a const char*.
+
+        * css/CSSStyleDeclaration.cpp: Removed declaration of getPropertyName.
+        (WebCore::CSSStyleDeclaration::getPropertyShorthand): Added cast since
+        getPropertyName now takes an enum value and returns a const char*.
+
+2007-01-26  Alice Liu  <alice.liu@apple.com>
+
+        Reviewed by Brady.
+
+        Fixed <rdar://problem/4838076> CrashTracer: 10 crashes in Mail at com.apple.WebCore: WTF::HashMap<WebCore::String
+
+        * loader/DocLoader.cpp:
+        (WebCore::DocLoader::requestResource):
+        Added nil check around resource from cache.
+
+2007-01-26  Adam Roben  <aroben@apple.com>
+
+        Reviewed by Oliver.
+
+        Build fix.
+
+        * ksvg2/svg/SVGAnimationElement.cpp:
+        (WebCore::SVGAnimationElement::calculateValueIndexAndPercentagePast):
+        Keep index variables as unsigned until we need to convert to float.
+
+2007-01-26  Alice Liu  <alice.liu@apple.com>
+
+        Reviewed by Ada.
+
+        Fixed <rdar://problem/4919097> REGRESSION: Ctrl-Y fails to yank (11076)
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::deleteWithDirection):
+        If there's no selection, locally create a range that is to the end of the granularity unit and pass that to deleteRange(). 
+
 2007-01-26  Sam Weinig  <sam@webkit.org>
 
         Reviewed by Maciej.
 
         Reviewed by Maciej.
 
-        Fixed an issue on tivofaq.com where you could never tab forward into
-        the left frame after tabbing out of the document.
+        Fixed <rdar://problem/4946499>, which made it impossible to tab
+        forward into the left frame of tivofaq.com after tabbing out of the
+        document.
 
         * page/FocusController.cpp:
         (WebCore::FocusController::advanceFocus): Clear the focused frame